* [PATCH] usb: remove the invalid comments
@ 2025-03-14 7:09 Li Qiong
2025-03-14 7:12 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Li Qiong @ 2025-03-14 7:09 UTC (permalink / raw)
To: Peter Chen, Pawel Laszczak
Cc: Roger Quadros, Greg Kroah-Hartman, Michal Simek, linux-usb,
linux-kernel, linux-arm-kernel, Li Qiong
These function don't return value, remove the invalid comments.
Signed-off-by: Li Qiong <liqiong@nfschina.com>
---
drivers/usb/cdns3/cdns3-plat.c | 2 --
drivers/usb/gadget/udc/udc-xilinx.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/usb/cdns3/cdns3-plat.c b/drivers/usb/cdns3/cdns3-plat.c
index 59ec505e198a..735df88774e4 100644
--- a/drivers/usb/cdns3/cdns3-plat.c
+++ b/drivers/usb/cdns3/cdns3-plat.c
@@ -179,8 +179,6 @@ static int cdns3_plat_probe(struct platform_device *pdev)
/**
* cdns3_plat_remove() - unbind drd driver and clean up
* @pdev: Pointer to Linux platform device
- *
- * Returns 0 on success otherwise negative errno
*/
static void cdns3_plat_remove(struct platform_device *pdev)
{
diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/udc/udc-xilinx.c
index ae2aeb271897..fa94cc065274 100644
--- a/drivers/usb/gadget/udc/udc-xilinx.c
+++ b/drivers/usb/gadget/udc/udc-xilinx.c
@@ -2178,8 +2178,6 @@ static int xudc_probe(struct platform_device *pdev)
/**
* xudc_remove - Releases the resources allocated during the initialization.
* @pdev: pointer to the platform device structure.
- *
- * Return: 0 always
*/
static void xudc_remove(struct platform_device *pdev)
{
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] usb: remove the invalid comments
2025-03-14 7:09 [PATCH] usb: remove the invalid comments Li Qiong
@ 2025-03-14 7:12 ` Greg Kroah-Hartman
2025-03-14 7:32 ` liqiong
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2025-03-14 7:12 UTC (permalink / raw)
To: Li Qiong
Cc: Peter Chen, Pawel Laszczak, Roger Quadros, Michal Simek,
linux-usb, linux-kernel, linux-arm-kernel
On Fri, Mar 14, 2025 at 03:09:21PM +0800, Li Qiong wrote:
> These function don't return value, remove the invalid comments.
>
> Signed-off-by: Li Qiong <liqiong@nfschina.com>
> ---
> drivers/usb/cdns3/cdns3-plat.c | 2 --
> drivers/usb/gadget/udc/udc-xilinx.c | 2 --
This should be 2 different patches, right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: remove the invalid comments
2025-03-14 7:12 ` Greg Kroah-Hartman
@ 2025-03-14 7:32 ` liqiong
0 siblings, 0 replies; 3+ messages in thread
From: liqiong @ 2025-03-14 7:32 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Peter Chen, Pawel Laszczak, Roger Quadros, Michal Simek,
linux-usb, linux-kernel, linux-arm-kernel
在 2025/3/14 15:12, Greg Kroah-Hartman 写道:
> On Fri, Mar 14, 2025 at 03:09:21PM +0800, Li Qiong wrote:
>> These function don't return value, remove the invalid comments.
>>
>> Signed-off-by: Li Qiong <liqiong@nfschina.com>
>> ---
>> drivers/usb/cdns3/cdns3-plat.c | 2 --
>> drivers/usb/gadget/udc/udc-xilinx.c | 2 --
> This should be 2 different patches, right?
Yeah, I will split this patch and send again.
thanks.
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-14 7:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-14 7:09 [PATCH] usb: remove the invalid comments Li Qiong
2025-03-14 7:12 ` Greg Kroah-Hartman
2025-03-14 7:32 ` liqiong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox