From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Kim Seer Paller" <kimseer.paller@analog.com>,
"Anshul Dalal" <anshulusr@gmail.com>,
"Ramona Gradinariu" <ramona.gradinariu@analog.com>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Robert Budai" <robert.budai@analog.com>,
"Petre Rodan" <petre.rodan@subdimension.ro>,
"Andreas Klinger" <ak@it-klinger.de>,
"Fabrice Gasnier" <fabrice.gasnier@foss.st.com>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: Correct indentation and style in DTS example
Date: Fri, 28 Mar 2025 09:44:54 +0000 [thread overview]
Message-ID: <20250328094454.3ec9dd7d@jic23-huawei> (raw)
In-Reply-To: <20250324125313.82226-1-krzysztof.kozlowski@linaro.org>
On Mon, 24 Mar 2025 13:53:12 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> DTS example in the bindings should be indented with 2- or 4-spaces and
> aligned with opening '- |', so correct any differences like 3-spaces or
> mixtures 2- and 4-spaces in one binding.
>
> No functional changes here, but saves some comments during reviews of
> new patches built on existing code.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied both patches to my testing branch. I'll rebase on rc1 once
that is available and push out as togreg.
Thanks,
Jonathan
> ---
> .../bindings/iio/adc/st,stm32-adc.yaml | 102 +++++++++---------
> 1 file changed, 51 insertions(+), 51 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml
> index ef9dcc365eab..17bb60e18a1c 100644
> --- a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml
> @@ -498,7 +498,7 @@ patternProperties:
> examples:
> - |
> // Example 1: with stm32f429, ADC1, single-ended channel 8
> - adc123: adc@40012000 {
> + adc123: adc@40012000 {
> compatible = "st,stm32f4-adc-core";
> reg = <0x40012000 0x400>;
> interrupts = <18>;
> @@ -512,28 +512,28 @@ examples:
> #address-cells = <1>;
> #size-cells = <0>;
> adc@0 {
> - compatible = "st,stm32f4-adc";
> - #io-channel-cells = <1>;
> - reg = <0x0>;
> - clocks = <&rcc 0 168>;
> - interrupt-parent = <&adc123>;
> - interrupts = <0>;
> - st,adc-channels = <8>;
> - dmas = <&dma2 0 0 0x400 0x0>;
> - dma-names = "rx";
> - assigned-resolution-bits = <8>;
> + compatible = "st,stm32f4-adc";
> + #io-channel-cells = <1>;
> + reg = <0x0>;
> + clocks = <&rcc 0 168>;
> + interrupt-parent = <&adc123>;
> + interrupts = <0>;
> + st,adc-channels = <8>;
> + dmas = <&dma2 0 0 0x400 0x0>;
> + dma-names = "rx";
> + assigned-resolution-bits = <8>;
> };
> // ...
> // other adc child nodes follow...
> - };
> + };
>
> - |
> // Example 2: with stm32mp157c to setup ADC1 with:
> // - channels 0 & 1 as single-ended
> // - channels 2 & 3 as differential (with resp. 6 & 7 negative inputs)
> - #include <dt-bindings/interrupt-controller/arm-gic.h>
> - #include <dt-bindings/clock/stm32mp1-clks.h>
> - adc12: adc@48003000 {
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/stm32mp1-clks.h>
> + adc12: adc@48003000 {
> compatible = "st,stm32mp1-adc-core";
> reg = <0x48003000 0x400>;
> interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>,
> @@ -550,27 +550,27 @@ examples:
> #address-cells = <1>;
> #size-cells = <0>;
> adc@0 {
> - compatible = "st,stm32mp1-adc";
> - #io-channel-cells = <1>;
> - reg = <0x0>;
> - interrupt-parent = <&adc12>;
> - interrupts = <0>;
> - st,adc-channels = <0 1>;
> - st,adc-diff-channels = <2 6>, <3 7>;
> - st,min-sample-time-nsecs = <5000>;
> - dmas = <&dmamux1 9 0x400 0x05>;
> - dma-names = "rx";
> + compatible = "st,stm32mp1-adc";
> + #io-channel-cells = <1>;
> + reg = <0x0>;
> + interrupt-parent = <&adc12>;
> + interrupts = <0>;
> + st,adc-channels = <0 1>;
> + st,adc-diff-channels = <2 6>, <3 7>;
> + st,min-sample-time-nsecs = <5000>;
> + dmas = <&dmamux1 9 0x400 0x05>;
> + dma-names = "rx";
> };
> // ...
> // other adc child node follow...
> - };
> + };
>
> - |
> // Example 3: with stm32mp157c to setup ADC2 with:
> // - internal channels 13, 14, 15.
> - #include <dt-bindings/interrupt-controller/arm-gic.h>
> - #include <dt-bindings/clock/stm32mp1-clks.h>
> - adc122: adc@48003000 {
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/stm32mp1-clks.h>
> + adc122: adc@48003000 {
> compatible = "st,stm32mp1-adc-core";
> reg = <0x48003000 0x400>;
> interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>,
> @@ -587,28 +587,28 @@ examples:
> #address-cells = <1>;
> #size-cells = <0>;
> adc@100 {
> - compatible = "st,stm32mp1-adc";
> - #io-channel-cells = <1>;
> - reg = <0x100>;
> - interrupts = <1>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> - channel@13 {
> - reg = <13>;
> - label = "vrefint";
> - st,min-sample-time-ns = <9000>;
> - };
> - channel@14 {
> - reg = <14>;
> - label = "vddcore";
> - st,min-sample-time-ns = <9000>;
> - };
> - channel@15 {
> - reg = <15>;
> - label = "vbat";
> - st,min-sample-time-ns = <9000>;
> - };
> + compatible = "st,stm32mp1-adc";
> + #io-channel-cells = <1>;
> + reg = <0x100>;
> + interrupts = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + channel@13 {
> + reg = <13>;
> + label = "vrefint";
> + st,min-sample-time-ns = <9000>;
> + };
> + channel@14 {
> + reg = <14>;
> + label = "vddcore";
> + st,min-sample-time-ns = <9000>;
> + };
> + channel@15 {
> + reg = <15>;
> + label = "vbat";
> + st,min-sample-time-ns = <9000>;
> + };
> };
> - };
> + };
>
> ...
prev parent reply other threads:[~2025-03-28 9:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 12:53 [PATCH 1/2] dt-bindings: iio: Correct indentation and style in DTS example Krzysztof Kozlowski
2025-03-24 12:53 ` [PATCH 2/2] dt-bindings: iio: Use unevaluatedProperties for SPI devices Krzysztof Kozlowski
2025-03-24 20:31 ` Rob Herring (Arm)
2025-03-25 6:06 ` Matti Vaittinen
2025-03-28 9:44 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250328094454.3ec9dd7d@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=ak@it-klinger.de \
--cc=alexandre.torgue@foss.st.com \
--cc=anshulusr@gmail.com \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@foss.st.com \
--cc=kimseer.paller@analog.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mazziesaccount@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nuno.sa@analog.com \
--cc=petre.rodan@subdimension.ro \
--cc=ramona.gradinariu@analog.com \
--cc=robert.budai@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox