Re: [PATCH v4 3/7] firmware: arm_scmi: imx: Add i.MX95 LMM protocol

[Peng Fan <peng.fan@oss.nxp.com>]

On Tue, Apr 08, 2025 at 12:21:56PM +0300, Dan Carpenter wrote:
>On Tue, Apr 08, 2025 at 04:44:27PM +0800, Peng Fan (OSS) wrote:
>> From: Peng Fan <peng.fan@nxp.com>
>> 
>> Add Logical Machine Management(LMM) protocol which is intended for boot,
>> shutdown, and reset of other logical machines (LM). It is usually used to
>> allow one LM to manager another used as an offload or accelerator engine.
>> 
>> Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> ---
>>  drivers/firmware/arm_scmi/vendors/imx/Kconfig      |  11 +
>>  drivers/firmware/arm_scmi/vendors/imx/Makefile     |   1 +
>>  drivers/firmware/arm_scmi/vendors/imx/imx-sm-lmm.c | 262 +++++++++++++++++++++
>>  include/linux/scmi_imx_protocol.h                  |  32 +++
>>  4 files changed, 306 insertions(+)
>> 
>> diff --git a/drivers/firmware/arm_scmi/vendors/imx/Kconfig b/drivers/firmware/arm_scmi/vendors/imx/Kconfig
>> index a01bf5e47301d2f93c9bfc7eebc77e083ea4ed75..1a936fc87d2350e2a21bccd45dfbeebfa3b90286 100644
>> --- a/drivers/firmware/arm_scmi/vendors/imx/Kconfig
>> +++ b/drivers/firmware/arm_scmi/vendors/imx/Kconfig
>> @@ -12,6 +12,17 @@ config IMX_SCMI_BBM_EXT
>>  	  To compile this driver as a module, choose M here: the
>>  	  module will be called imx-sm-bbm.
>>  
>> +config IMX_SCMI_LMM_EXT
>> +	tristate "i.MX SCMI LMM EXTENSION"
>> +	depends on ARM_SCMI_PROTOCOL || (COMPILE_TEST && OF)
>> +	default y if ARCH_MXC
>> +	help
>> +	  This enables i.MX System Logical Machine Protocol to
>> +	  manage Logical Machines boot, shutdown and etc.
>> +
>> +	  To compile this driver as a module, choose M here: the
>> +	  module will be called imx-sm-lmm.
>> +
>
>Remind me again what happens if you have both the default and the
>extension modules enabled?

With update defconfig to m, it will be built as module as below output:

  MODPOST Module.symvers
  CC [M]  drivers/firmware/arm_scmi/vendors/imx/imx-sm-lmm.mod.o
  CC [M]  drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.mod.o
  LD [M]  drivers/firmware/arm_scmi/vendors/imx/imx-sm-lmm.ko
  LD [M]  drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.ko

Regards,
Peng
>
>regards,
>dan carpenter
>