public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: kyrie.wu <kyrie.wu@mediatek.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	kyrie wu <kyrie.wu@mediatek.corp-partner.google.com>,
	<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>
Cc: kyrie.wu <kyrie.wu@mediatek.com>
Subject: [PATCH v2 11/12] media: mediatek: jpeg: refactor decoding resolution change operation
Date: Thu, 10 Apr 2025 14:30:04 +0800	[thread overview]
Message-ID: <20250410063006.5313-12-kyrie.wu@mediatek.com> (raw)
In-Reply-To: <20250410063006.5313-1-kyrie.wu@mediatek.com>

For multi-core:
1.if there are only two src buffers, hw0 and hw1 are decoding
at the same time. When resolution change occurred on one hw,
the src buffer cannot be got in the stop streaming function,
which will cause a crash.
2.When a resolution change occurs, immediately set the new
resolution parameter to save the new resolution;
3.After a resolution change occurred, decoding should not continue,
needs to wait until new buffers are ready and the state machine
changed.

Signed-off-by: kyrie.wu <kyrie.wu@mediatek.com>
---
 drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
index 4c5e47b678d4..0a4a503ecbd8 100644
--- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
@@ -890,7 +890,8 @@ static void mtk_jpeg_dec_stop_streaming(struct vb2_queue *q)
 
 		vb = v4l2_m2m_next_src_buf(ctx->fh.m2m_ctx);
 		src_buf = mtk_jpeg_vb2_to_srcbuf(&vb->vb2_buf);
-		mtk_jpeg_set_queue_data(ctx, &src_buf->dec_param);
+		if (!IS_ERR_OR_NULL(src_buf))
+			mtk_jpeg_set_queue_data(ctx, &src_buf->dec_param);
 		ctx->state = MTK_JPEG_RUNNING;
 	} else if (V4L2_TYPE_IS_OUTPUT(q->type)) {
 		ctx->state = MTK_JPEG_INIT;
@@ -1781,11 +1782,15 @@ static void mtk_jpegdec_worker(struct work_struct *work)
 
 	if (mtk_jpeg_check_resolution_change(ctx,
 					     &jpeg_src_buf->dec_param)) {
-		mtk_jpeg_queue_src_chg_event(ctx);
+		mtk_jpeg_set_queue_data(ctx, &jpeg_src_buf->dec_param);
 		ctx->state = MTK_JPEG_SOURCE_CHANGE;
+		mtk_jpeg_queue_src_chg_event(ctx);
 		goto getbuf_fail;
 	}
 
+	if (ctx->state == MTK_JPEG_SOURCE_CHANGE)
+		goto getbuf_fail;
+
 	mtk_jpegdec_set_hw_param(ctx, hw_id, src_buf, dst_buf);
 	ret = pm_runtime_resume_and_get(comp_jpeg[hw_id]->dev);
 	if (ret < 0) {
-- 
2.46.0



  parent reply	other threads:[~2025-04-10  6:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-10  6:29 [PATCH v2 00/12] Enable jpeg enc & dec multi-hardwares for MT8196 kyrie.wu
2025-04-10  6:29 ` [PATCH v2 01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible kyrie.wu
2025-04-10  6:39   ` Krzysztof Kozlowski
2025-04-11  2:54     ` Kyrie Wu (吴晗)
2025-04-12 10:13       ` Krzysztof Kozlowski
2025-04-13  9:41         ` Kyrie Wu (吴晗)
2025-04-10  6:29 ` [PATCH v2 02/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgenc compatible kyrie.wu
2025-04-10  6:40   ` Krzysztof Kozlowski
2025-04-11  2:48     ` Kyrie Wu (吴晗)
2025-04-12 10:13       ` Krzysztof Kozlowski
2025-04-13  9:56         ` Kyrie Wu (吴晗)
2025-04-10  6:29 ` [PATCH v2 03/12] media: mediatek: jpeg: add jpeg compatible kyrie.wu
2025-04-10  6:29 ` [PATCH v2 04/12] media: mediatek: jpeg: add jpeg smmu sid setting kyrie.wu
2025-04-10  6:29 ` [PATCH v2 05/12] media: mediatek: jpeg: fix jpeg hw count setting kyrie.wu
2025-04-10  6:29 ` [PATCH v2 06/12] media: mediatek: jpeg: refactor jpeg buffer payload setting kyrie.wu
2025-04-10  6:30 ` [PATCH v2 07/12] media: mediatek: jpeg: refactor jpeg dst buffer layout kyrie.wu
2025-04-10  6:30 ` [PATCH v2 08/12] media: mediatek: jpeg: fix stop streaming flow for multi-core kyrie.wu
2025-04-10  6:30 ` [PATCH v2 09/12] media: mediatek: jpeg: refactor multi-core clk suspend and resume setting kyrie.wu
2025-04-10  6:30 ` [PATCH v2 10/12] media: mediatek: jpeg: fix decoding buffer number setting timing issue kyrie.wu
2025-04-10  6:30 ` kyrie.wu [this message]
2025-04-10  6:30 ` [PATCH v2 12/12] media: mediatek: jpeg: fix remove buffer operation for multi-core kyrie.wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250410063006.5313-12-kyrie.wu@mediatek.com \
    --to=kyrie.wu@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=krzk+dt@kernel.org \
    --cc=kyrie.wu@mediatek.corp-partner.google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox