From: kyrie.wu <kyrie.wu@mediatek.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
kyrie wu <kyrie.wu@mediatek.corp-partner.google.com>,
<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>
Cc: kyrie.wu <kyrie.wu@mediatek.com>
Subject: [PATCH v2 07/12] media: mediatek: jpeg: refactor jpeg dst buffer layout
Date: Thu, 10 Apr 2025 14:30:00 +0800 [thread overview]
Message-ID: <20250410063006.5313-8-kyrie.wu@mediatek.com> (raw)
In-Reply-To: <20250410063006.5313-1-kyrie.wu@mediatek.com>
1. change dst buffer size to same as struct mtk_jpeg_src_buf
to make sure all params of mtk_jpeg_src_buf could get a memory.
2. For memory alloc operation:
the v4l2 framework malloc a memory, the base addr is vb2_buffer and
the size is sizeof(struct mtk_jpeg_src_buf), mtk_jpeg_src_buf could get
itself addr by container_of like that:
vb2_buffer -> vb2_v4l2_buffer -> mtk_jpeg_src_buf.
vb2_v4l2_buffer must keep on the top of mtk_jpeg_src_buf.
Signed-off-by: kyrie.wu <kyrie.wu@mediatek.com>
---
drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 2 +-
drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
index 3b386ec44b36..79a47a59caba 100644
--- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
@@ -1102,7 +1102,7 @@ static int mtk_jpeg_queue_init(void *priv, struct vb2_queue *src_vq,
dst_vq->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
dst_vq->io_modes = VB2_DMABUF | VB2_MMAP;
dst_vq->drv_priv = ctx;
- dst_vq->buf_struct_size = sizeof(struct v4l2_m2m_buffer);
+ dst_vq->buf_struct_size = sizeof(struct mtk_jpeg_src_buf);
dst_vq->ops = jpeg->variant->qops;
dst_vq->mem_ops = &vb2_dma_contig_memops;
dst_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY;
diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h
index cff156697603..25ba21d80de7 100644
--- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h
+++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.h
@@ -86,10 +86,10 @@ struct mtk_jpeg_variant {
};
struct mtk_jpeg_src_buf {
- u32 frame_num;
struct vb2_v4l2_buffer b;
struct list_head list;
u32 bs_size;
+ u32 frame_num;
struct mtk_jpeg_dec_param dec_param;
struct mtk_jpeg_ctx *curr_ctx;
--
2.46.0
next prev parent reply other threads:[~2025-04-10 7:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 6:29 [PATCH v2 00/12] Enable jpeg enc & dec multi-hardwares for MT8196 kyrie.wu
2025-04-10 6:29 ` [PATCH v2 01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible kyrie.wu
2025-04-10 6:39 ` Krzysztof Kozlowski
2025-04-11 2:54 ` Kyrie Wu (吴晗)
2025-04-12 10:13 ` Krzysztof Kozlowski
2025-04-13 9:41 ` Kyrie Wu (吴晗)
2025-04-10 6:29 ` [PATCH v2 02/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgenc compatible kyrie.wu
2025-04-10 6:40 ` Krzysztof Kozlowski
2025-04-11 2:48 ` Kyrie Wu (吴晗)
2025-04-12 10:13 ` Krzysztof Kozlowski
2025-04-13 9:56 ` Kyrie Wu (吴晗)
2025-04-10 6:29 ` [PATCH v2 03/12] media: mediatek: jpeg: add jpeg compatible kyrie.wu
2025-04-10 6:29 ` [PATCH v2 04/12] media: mediatek: jpeg: add jpeg smmu sid setting kyrie.wu
2025-04-10 6:29 ` [PATCH v2 05/12] media: mediatek: jpeg: fix jpeg hw count setting kyrie.wu
2025-04-10 6:29 ` [PATCH v2 06/12] media: mediatek: jpeg: refactor jpeg buffer payload setting kyrie.wu
2025-04-10 6:30 ` kyrie.wu [this message]
2025-04-10 6:30 ` [PATCH v2 08/12] media: mediatek: jpeg: fix stop streaming flow for multi-core kyrie.wu
2025-04-10 6:30 ` [PATCH v2 09/12] media: mediatek: jpeg: refactor multi-core clk suspend and resume setting kyrie.wu
2025-04-10 6:30 ` [PATCH v2 10/12] media: mediatek: jpeg: fix decoding buffer number setting timing issue kyrie.wu
2025-04-10 6:30 ` [PATCH v2 11/12] media: mediatek: jpeg: refactor decoding resolution change operation kyrie.wu
2025-04-10 6:30 ` [PATCH v2 12/12] media: mediatek: jpeg: fix remove buffer operation for multi-core kyrie.wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410063006.5313-8-kyrie.wu@mediatek.com \
--to=kyrie.wu@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=krzk+dt@kernel.org \
--cc=kyrie.wu@mediatek.corp-partner.google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox