[PATCH 1/1] arm64: dts: allwinner: correct the model name for Radxa Cubie A5E

[PATCH 1/1] arm64: dts: allwinner: correct the model name for Radxa Cubie A5E

[Chukun Pan]

According to https://radxa.com/products/cubie/a5e,
the name of this board should be "Radxa Cubie A5E".
This is also consistent with the dt-bindings.

Fixes: 80e0fb4e491b ("arm64: dts: allwinner: a523: add Radxa A5E support")
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 arch/arm64/boot/dts/allwinner/sun55i-a527-radxa-a5e.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a527-radxa-a5e.dts b/arch/arm64/boot/dts/allwinner/sun55i-a527-radxa-a5e.dts
index 912e1bda974c..03c9a9ef5adc 100644
--- a/arch/arm64/boot/dts/allwinner/sun55i-a527-radxa-a5e.dts
+++ b/arch/arm64/boot/dts/allwinner/sun55i-a527-radxa-a5e.dts
@@ -8,7 +8,7 @@
 #include <dt-bindings/gpio/gpio.h>
 
 / {
-	model = "Radxa A5E";
+	model = "Radxa Cubie A5E";
 	compatible = "radxa,cubie-a5e", "allwinner,sun55i-a527";
 
 	aliases {
-- 
2.25.1

Re: [PATCH 1/1] arm64: dts: allwinner: correct the model name for Radxa Cubie A5E

[Andre Przywara]

On Wed, 16 Apr 2025 18:00:06 +0800
Chukun Pan <amadeus@jmu.edu.cn> wrote:

> According to https://radxa.com/products/cubie/a5e,
> the name of this board should be "Radxa Cubie A5E".
> This is also consistent with the dt-bindings.
> 
> Fixes: 80e0fb4e491b ("arm64: dts: allwinner: a523: add Radxa A5E support")
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>

Indeed, thanks for sending a patch!

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
>  arch/arm64/boot/dts/allwinner/sun55i-a527-radxa-a5e.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a527-radxa-a5e.dts b/arch/arm64/boot/dts/allwinner/sun55i-a527-radxa-a5e.dts
> index 912e1bda974c..03c9a9ef5adc 100644
> --- a/arch/arm64/boot/dts/allwinner/sun55i-a527-radxa-a5e.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun55i-a527-radxa-a5e.dts
> @@ -8,7 +8,7 @@
>  #include <dt-bindings/gpio/gpio.h>
>  
>  / {
> -	model = "Radxa A5E";
> +	model = "Radxa Cubie A5E";
>  	compatible = "radxa,cubie-a5e", "allwinner,sun55i-a527";
>  
>  	aliases {

Re: [PATCH 1/1] arm64: dts: allwinner: correct the model name for Radxa Cubie A5E

[Chen-Yu Tsai]

On Wed, 16 Apr 2025 18:00:06 +0800, Chukun Pan wrote:
> According to https://radxa.com/products/cubie/a5e,
> the name of this board should be "Radxa Cubie A5E".
> This is also consistent with the dt-bindings.
> 
> 

Applied to dt-for-6.16 in git@github.com:linux-sunxi/linux-sunxi.git, thanks!

[1/1] arm64: dts: allwinner: correct the model name for Radxa Cubie A5E
      commit: 1e5a69d67d1b3c55c9b0cd3933af1436b5d52aa1

Best regards,
-- 
Chen-Yu Tsai <wens@csie.org>

Re: [PATCH 1/1] arm64: dts: allwinner: correct the model name for Radxa Cubie A5E

[Yixun Lan]

Hi Chukun, Chen-Yu,

On 01:52 Fri 25 Apr     , Chen-Yu Tsai wrote:
> On Wed, 16 Apr 2025 18:00:06 +0800, Chukun Pan wrote:
> > According to https://radxa.com/products/cubie/a5e,
> > the name of this board should be "Radxa Cubie A5E".
> > This is also consistent with the dt-bindings.
> > 
> > 
> 
> Applied to dt-for-6.16 in git@github.com:linux-sunxi/linux-sunxi.git, thanks!
> 
> [1/1] arm64: dts: allwinner: correct the model name for Radxa Cubie A5E
>       commit: 1e5a69d67d1b3c55c9b0cd3933af1436b5d52aa1
> 
It seems I'm a little bit late for this, but while we are here,
Can we also append 'cubie' to dts file name? e.g. - sun55i-a527-radxa-cubie-a5e.dts

for the reasons:
1) there are already too many product lines from Radxa - Rock, Orion, Zero..
some dts file in rockchip already adopt this name scheme:
  arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3e.dts
2) there might be more products in the future for the cubie series..

Chukun, if people agree on this, could you send a follow-up patch
to address this?

-- 
Yixun Lan (dlan)

Re: [PATCH 1/1] arm64: dts: allwinner: correct the model name for Radxa Cubie A5E

[Chukun Pan]

Hi,

> It seems I'm a little bit late for this, but while we are here,
> Can we also append 'cubie' to dts file name?
> e.g. - sun55i-a527-radxa-cubie-a5e.dts

Usually we use the device name (without the vendor name),
maybe sun55i-a527-cubie-a5e.dts would be better?

Thanks,
Chukun

--
2.25.1

Re: [PATCH 1/1] arm64: dts: allwinner: correct the model name for Radxa Cubie A5E

[Chen-Yu Tsai]

On Fri, Apr 25, 2025 at 11:00 AM Chukun Pan <amadeus@jmu.edu.cn> wrote:
>
> Hi,
>
> > It seems I'm a little bit late for this, but while we are here,
> > Can we also append 'cubie' to dts file name?
> > e.g. - sun55i-a527-radxa-cubie-a5e.dts
>
> Usually we use the device name (without the vendor name),
> maybe sun55i-a527-cubie-a5e.dts would be better?

I agree with this one.

I can probably squash in a name change (since I'll be squashing in the
SD card slot fix anyway). Andre?


In that case would you prefer to keep your current patch separate, or
squashed in so that everything is clean from the first commit?

It's up to you since you lose out on commit stats.


Thanks
ChenYu

> Thanks,
> Chukun
>
> --
> 2.25.1
>
>

Re: [PATCH 1/1] arm64: dts: allwinner: correct the model name for Radxa Cubie A5E

[Yixun Lan]

Hi Chukun, Chen-Yu,

On 11:52 Fri 25 Apr     , Chen-Yu Tsai wrote:
> On Fri, Apr 25, 2025 at 11:00 AM Chukun Pan <amadeus@jmu.edu.cn> wrote:
> >
> > Hi,
> >
> > > It seems I'm a little bit late for this, but while we are here,
> > > Can we also append 'cubie' to dts file name?
> > > e.g. - sun55i-a527-radxa-cubie-a5e.dts
> >
> > Usually we use the device name (without the vendor name),
> > maybe sun55i-a527-cubie-a5e.dts would be better?
> 
> I agree with this one.
> 
I personally would prefer to keep vendor name, it's more explicit
and easy for poeple to distinguish/find the board dts

but, this isn't something I really care, so I won't insist on this,
please proceed either way, thanks

> I can probably squash in a name change (since I'll be squashing in the
> SD card slot fix anyway). Andre?
> 
I think it is better

> 
> In that case would you prefer to keep your current patch separate, or
> squashed in so that everything is clean from the first commit?
> 
> It's up to you since you lose out on commit stats.
> 
> 
> Thanks
> ChenYu
> 
> > Thanks,
> > Chukun
> >
> > --
> > 2.25.1
> >
> >

-- 
Yixun Lan (dlan)

Re: [PATCH 1/1] arm64: dts: allwinner: correct the model name for Radxa Cubie A5E

[Andre Przywara]

On Fri, 25 Apr 2025 11:52:42 +0800
Chen-Yu Tsai <wens@csie.org> wrote:

> On Fri, Apr 25, 2025 at 11:00 AM Chukun Pan <amadeus@jmu.edu.cn> wrote:
> >
> > Hi,
> >  
> > > It seems I'm a little bit late for this, but while we are here,
> > > Can we also append 'cubie' to dts file name?
> > > e.g. - sun55i-a527-radxa-cubie-a5e.dts  
> >
> > Usually we use the device name (without the vendor name),
> > maybe sun55i-a527-cubie-a5e.dts would be better?  
> 
> I agree with this one.
> 
> I can probably squash in a name change (since I'll be squashing in the
> SD card slot fix anyway). Andre?

Yes, I noticed that yesterday as well. So that's fine with me: both the
name change and the squash.

Cheers,
Andre

> In that case would you prefer to keep your current patch separate, or
> squashed in so that everything is clean from the first commit?
> 
> It's up to you since you lose out on commit stats.
> 
> 
> Thanks
> ChenYu
> 
> > Thanks,
> > Chukun
> >
> > --
> > 2.25.1
> >
> >  

Re: [PATCH 1/1] arm64: dts: allwinner: correct the model name for Radxa Cubie A5E

[Chen-Yu Tsai]

On Fri, Apr 25, 2025 at 12:47 PM Yixun Lan <dlan@gentoo.org> wrote:
>
> Hi Chukun, Chen-Yu,
>
> On 11:52 Fri 25 Apr     , Chen-Yu Tsai wrote:
> > On Fri, Apr 25, 2025 at 11:00 AM Chukun Pan <amadeus@jmu.edu.cn> wrote:
> > >
> > > Hi,
> > >
> > > > It seems I'm a little bit late for this, but while we are here,
> > > > Can we also append 'cubie' to dts file name?
> > > > e.g. - sun55i-a527-radxa-cubie-a5e.dts
> > >
> > > Usually we use the device name (without the vendor name),
> > > maybe sun55i-a527-cubie-a5e.dts would be better?
> >
> > I agree with this one.
> >
> I personally would prefer to keep vendor name, it's more explicit
> and easy for poeple to distinguish/find the board dts

We really only have the board name, which sometimes combines a brand
name, but not the vendor name.

Same goes for all of Radxa's other Rockchip boards. The file names
are all rk3xxx-rock?????.dts. And all the LibreELEC boards are
????-nanopi-???.dts.

ChenYu

> but, this isn't something I really care, so I won't insist on this,
> please proceed either way, thanks
>
> > I can probably squash in a name change (since I'll be squashing in the
> > SD card slot fix anyway). Andre?
> >
> I think it is better
>
> >
> > In that case would you prefer to keep your current patch separate, or
> > squashed in so that everything is clean from the first commit?
> >
> > It's up to you since you lose out on commit stats.
> >
> >
> > Thanks
> > ChenYu
> >
> > > Thanks,
> > > Chukun
> > >
> > > --
> > > 2.25.1
> > >
> > >
>
> --
> Yixun Lan (dlan)
>