* [PATCH] arm64: dts: ti: k3-am6*: Set eMMC clock parents to default
@ 2025-04-29 14:23 Judith Mendez
2025-04-29 14:28 ` Nishanth Menon
0 siblings, 1 reply; 3+ messages in thread
From: Judith Mendez @ 2025-04-29 14:23 UTC (permalink / raw)
To: Judith Mendez, Nishanth Menon, Vignesh Raghavendra
Cc: Tero Kristo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-kernel, devicetree, linux-kernel
Set eMMC clock parents to the defaults which is MAIN_PLL0_HSDIV5_CLKOUT
for eMMC. This change is necessary since DM is not implementing the
correct procedure to switch PLL clock source for eMMC and we have a
non-glich-free mux. To remove any potential issues, lets switch back to
the defaults.
Fixes: c37c58fdeb8a ("arm64: dts: ti: k3-am62: Add more peripheral nodes")
Fixes: d3ae4e8d8b6a ("arm64: dts: ti: k3-am62a-main: Add sdhci0 instance")
Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs")
Cc: stable@vger.kernel.org
Signed-off-by: Judith Mendez <jm@ti.com>
Acked-by: Udit Kumar <u-kumar1@ti.com>
---
This patch was split from "Misc MMC udates" patch series [0] to help
with backporting.
[0] https://lore.kernel.org/linux-devicetree/20250417233040.3658761-1-jm@ti.com/
---
arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 2 --
arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 2 --
arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 2 --
3 files changed, 6 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
index 7d355aa73ea2..0c286f600296 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
@@ -552,8 +552,6 @@ sdhci0: mmc@fa10000 {
power-domains = <&k3_pds 57 TI_SCI_PD_EXCLUSIVE>;
clocks = <&k3_clks 57 5>, <&k3_clks 57 6>;
clock-names = "clk_ahb", "clk_xin";
- assigned-clocks = <&k3_clks 57 6>;
- assigned-clock-parents = <&k3_clks 57 8>;
bus-width = <8>;
mmc-ddr-1_8v;
mmc-hs200-1_8v;
diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
index a1daba7b1fad..455ccc770f16 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
@@ -575,8 +575,6 @@ sdhci0: mmc@fa10000 {
power-domains = <&k3_pds 57 TI_SCI_PD_EXCLUSIVE>;
clocks = <&k3_clks 57 5>, <&k3_clks 57 6>;
clock-names = "clk_ahb", "clk_xin";
- assigned-clocks = <&k3_clks 57 6>;
- assigned-clock-parents = <&k3_clks 57 8>;
bus-width = <8>;
mmc-hs200-1_8v;
ti,clkbuf-sel = <0x7>;
diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
index 7b65538110e8..fa55c43ca28d 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
@@ -573,8 +573,6 @@ sdhci0: mmc@fa10000 {
power-domains = <&k3_pds 57 TI_SCI_PD_EXCLUSIVE>;
clocks = <&k3_clks 57 1>, <&k3_clks 57 2>;
clock-names = "clk_ahb", "clk_xin";
- assigned-clocks = <&k3_clks 57 2>;
- assigned-clock-parents = <&k3_clks 57 4>;
bus-width = <8>;
mmc-ddr-1_8v;
mmc-hs200-1_8v;
base-commit: d864bb528a6725e775d564fd4430762acbb9dd0d
--
2.49.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am6*: Set eMMC clock parents to default
2025-04-29 14:23 [PATCH] arm64: dts: ti: k3-am6*: Set eMMC clock parents to default Judith Mendez
@ 2025-04-29 14:28 ` Nishanth Menon
2025-04-29 14:46 ` Judith Mendez
0 siblings, 1 reply; 3+ messages in thread
From: Nishanth Menon @ 2025-04-29 14:28 UTC (permalink / raw)
To: Judith Mendez
Cc: Vignesh Raghavendra, Tero Kristo, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree
On 09:23-20250429, Judith Mendez wrote:
> Set eMMC clock parents to the defaults which is MAIN_PLL0_HSDIV5_CLKOUT
> for eMMC. This change is necessary since DM is not implementing the
> correct procedure to switch PLL clock source for eMMC and we have a
> non-glich-free mux. To remove any potential issues, lets switch back to
> the defaults.
>
> Fixes: c37c58fdeb8a ("arm64: dts: ti: k3-am62: Add more peripheral nodes")
> Fixes: d3ae4e8d8b6a ("arm64: dts: ti: k3-am62a-main: Add sdhci0 instance")
> Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs")
I thought I had given this comment previously as well, please DONOT put
multiple fixes in a single patch -> All three are solving the similar
problems, but on three different baseline - please think through how
this patch needs to be automatically backported to previous stable
kernels.
> Cc: stable@vger.kernel.org
> Signed-off-by: Judith Mendez <jm@ti.com>
> Acked-by: Udit Kumar <u-kumar1@ti.com>
> ---
> This patch was split from "Misc MMC udates" patch series [0] to help
> with backporting.
> [0] https://lore.kernel.org/linux-devicetree/20250417233040.3658761-1-jm@ti.com/
> ---
> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 2 --
> arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 2 --
> arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 2 --
> 3 files changed, 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index 7d355aa73ea2..0c286f600296 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -552,8 +552,6 @@ sdhci0: mmc@fa10000 {
> power-domains = <&k3_pds 57 TI_SCI_PD_EXCLUSIVE>;
> clocks = <&k3_clks 57 5>, <&k3_clks 57 6>;
> clock-names = "clk_ahb", "clk_xin";
> - assigned-clocks = <&k3_clks 57 6>;
> - assigned-clock-parents = <&k3_clks 57 8>;
> bus-width = <8>;
> mmc-ddr-1_8v;
> mmc-hs200-1_8v;
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> index a1daba7b1fad..455ccc770f16 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> @@ -575,8 +575,6 @@ sdhci0: mmc@fa10000 {
> power-domains = <&k3_pds 57 TI_SCI_PD_EXCLUSIVE>;
> clocks = <&k3_clks 57 5>, <&k3_clks 57 6>;
> clock-names = "clk_ahb", "clk_xin";
> - assigned-clocks = <&k3_clks 57 6>;
> - assigned-clock-parents = <&k3_clks 57 8>;
> bus-width = <8>;
> mmc-hs200-1_8v;
> ti,clkbuf-sel = <0x7>;
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> index 7b65538110e8..fa55c43ca28d 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> @@ -573,8 +573,6 @@ sdhci0: mmc@fa10000 {
> power-domains = <&k3_pds 57 TI_SCI_PD_EXCLUSIVE>;
> clocks = <&k3_clks 57 1>, <&k3_clks 57 2>;
> clock-names = "clk_ahb", "clk_xin";
> - assigned-clocks = <&k3_clks 57 2>;
> - assigned-clock-parents = <&k3_clks 57 4>;
> bus-width = <8>;
> mmc-ddr-1_8v;
> mmc-hs200-1_8v;
>
> base-commit: d864bb528a6725e775d564fd4430762acbb9dd0d
> --
> 2.49.0
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am6*: Set eMMC clock parents to default
2025-04-29 14:28 ` Nishanth Menon
@ 2025-04-29 14:46 ` Judith Mendez
0 siblings, 0 replies; 3+ messages in thread
From: Judith Mendez @ 2025-04-29 14:46 UTC (permalink / raw)
To: Nishanth Menon
Cc: Vignesh Raghavendra, Tero Kristo, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree
Hi Nishanth,
On 4/29/25 9:28 AM, Nishanth Menon wrote:
> On 09:23-20250429, Judith Mendez wrote:
>> Set eMMC clock parents to the defaults which is MAIN_PLL0_HSDIV5_CLKOUT
>> for eMMC. This change is necessary since DM is not implementing the
>> correct procedure to switch PLL clock source for eMMC and we have a
>> non-glich-free mux. To remove any potential issues, lets switch back to
>> the defaults.
>>
>> Fixes: c37c58fdeb8a ("arm64: dts: ti: k3-am62: Add more peripheral nodes")
>> Fixes: d3ae4e8d8b6a ("arm64: dts: ti: k3-am62a-main: Add sdhci0 instance")
>> Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs")
>
> I thought I had given this comment previously as well, please DONOT put
> multiple fixes in a single patch -> All three are solving the similar
> problems, but on three different baseline - please think through how
> this patch needs to be automatically backported to previous stable
> kernels.
>
I understand now, will split this patch in three, thanks.
~ Judith
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-29 16:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-29 14:23 [PATCH] arm64: dts: ti: k3-am6*: Set eMMC clock parents to default Judith Mendez
2025-04-29 14:28 ` Nishanth Menon
2025-04-29 14:46 ` Judith Mendez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox