Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: usb: dwc3-xilinx: allow dma-coherent
@ 2025-05-16 13:18 Radhey Shyam Pandey
  2025-05-16 14:16 ` Conor Dooley
  2025-05-27 19:26 ` Rob Herring (Arm)
  0 siblings, 2 replies; 4+ messages in thread
From: Radhey Shyam Pandey @ 2025-05-16 13:18 UTC (permalink / raw)
  To: gregkh, robh, krzk+dt, conor+dt, michal.simek
  Cc: linux-usb, devicetree, linux-arm-kernel, linux-kernel, git,
	Radhey Shyam Pandey

On Versal Gen 2 SoC the LPD USB DMA controller is coherent with the CPU
so allow specifying the information.

Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
---
 Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml b/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml
index 379dacacb526..36f5c644d959 100644
--- a/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml
+++ b/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml
@@ -26,6 +26,8 @@ properties:
 
   ranges: true
 
+  dma-coherent: true
+
   power-domains:
     description: specifies a phandle to PM domain provider node
     maxItems: 1

base-commit: 8566fc3b96539e3235909d6bdda198e1282beaed
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: usb: dwc3-xilinx: allow dma-coherent
  2025-05-16 13:18 [PATCH] dt-bindings: usb: dwc3-xilinx: allow dma-coherent Radhey Shyam Pandey
@ 2025-05-16 14:16 ` Conor Dooley
  2025-05-27 19:26   ` Rob Herring
  2025-05-27 19:26 ` Rob Herring (Arm)
  1 sibling, 1 reply; 4+ messages in thread
From: Conor Dooley @ 2025-05-16 14:16 UTC (permalink / raw)
  To: Radhey Shyam Pandey
  Cc: gregkh, robh, krzk+dt, conor+dt, michal.simek, linux-usb,
	devicetree, linux-arm-kernel, linux-kernel, git

[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]

On Fri, May 16, 2025 at 06:48:36PM +0530, Radhey Shyam Pandey wrote:
> On Versal Gen 2 SoC the LPD USB DMA controller is coherent with the CPU
> so allow specifying the information.

Sounds like it should actually be marked required on this platform, no?

> 
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> ---
>  Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml b/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml
> index 379dacacb526..36f5c644d959 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml
> +++ b/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml
> @@ -26,6 +26,8 @@ properties:
>  
>    ranges: true
>  
> +  dma-coherent: true
> +
>    power-domains:
>      description: specifies a phandle to PM domain provider node
>      maxItems: 1
> 
> base-commit: 8566fc3b96539e3235909d6bdda198e1282beaed
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: usb: dwc3-xilinx: allow dma-coherent
  2025-05-16 14:16 ` Conor Dooley
@ 2025-05-27 19:26   ` Rob Herring
  0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2025-05-27 19:26 UTC (permalink / raw)
  To: Conor Dooley
  Cc: Radhey Shyam Pandey, gregkh, krzk+dt, conor+dt, michal.simek,
	linux-usb, devicetree, linux-arm-kernel, linux-kernel, git

On Fri, May 16, 2025 at 03:16:02PM +0100, Conor Dooley wrote:
> On Fri, May 16, 2025 at 06:48:36PM +0530, Radhey Shyam Pandey wrote:
> > On Versal Gen 2 SoC the LPD USB DMA controller is coherent with the CPU
> > so allow specifying the information.
> 
> Sounds like it should actually be marked required on this platform, no?

Should still work without it, just more overhead of unnecessary cache 
flushes.

Rob


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: usb: dwc3-xilinx: allow dma-coherent
  2025-05-16 13:18 [PATCH] dt-bindings: usb: dwc3-xilinx: allow dma-coherent Radhey Shyam Pandey
  2025-05-16 14:16 ` Conor Dooley
@ 2025-05-27 19:26 ` Rob Herring (Arm)
  1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-05-27 19:26 UTC (permalink / raw)
  To: Radhey Shyam Pandey
  Cc: linux-usb, linux-kernel, michal.simek, git, linux-arm-kernel,
	krzk+dt, gregkh, devicetree, conor+dt


On Fri, 16 May 2025 18:48:36 +0530, Radhey Shyam Pandey wrote:
> On Versal Gen 2 SoC the LPD USB DMA controller is coherent with the CPU
> so allow specifying the information.
> 
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> ---
>  Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

Applied, thanks!



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-05-27 19:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-16 13:18 [PATCH] dt-bindings: usb: dwc3-xilinx: allow dma-coherent Radhey Shyam Pandey
2025-05-16 14:16 ` Conor Dooley
2025-05-27 19:26   ` Rob Herring
2025-05-27 19:26 ` Rob Herring (Arm)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox