Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: "Kumar, Udit" <u-kumar1@ti.com>
Cc: <vigneshr@ti.com>, <linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <kristo@kernel.org>,
	<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<linux-kernel@vger.kernel.org>, <b-padhi@ti.com>
Subject: Re: [RESEND PATCH] arm64: dts: ti: k3-j784s4-mcu-wakeup: Configure wkup_uart0 with clock settings
Date: Mon, 9 Jun 2025 07:00:32 -0500	[thread overview]
Message-ID: <20250609120032.yxmcyiw7dchv2kmp@wanted> (raw)
In-Reply-To: <51c56999-5f47-45fd-a4b2-4b79ecae0227@ti.com>

On 12:47-20250608, Kumar, Udit wrote:
> Hello Nishanth
> 
> On 6/3/2025 9:31 PM, Nishanth Menon wrote:
> > On 09:54-20250603, Udit Kumar wrote:
> > > From: Bhavya Kapoor <b-kapoor@ti.com>
> > > 
> > > This commit adds the assigned-clocks and assigned-clock-parents
> > > properties for wkup_uart0 in J784S4. Specifically, the assigned-clocks
> > > property is set to reference the clock identified by
> > > "wkup_usart_mcupll_bypass_out0", ensuring the UART operates with the
> > > correct clock source.
> > > 
> > > The assigned-clock-parents property specifies "wkup_usart_clksel_out0"
> > > as the parent clock. This configuration is critical for establishing
> > > the proper clocking hierarchy, enabling the UART device to function
> > > reliably across different baud rates.
> > Please fix the commit message - not clear what specifically in the clock
> > hierarchy does permit the multiple baud rates.
> 
> need your advise here .
> 
> unlike other UART of main domain.  wkup_uart currently has two parents clock
> (clock-1 is at 96Mhz and clock-0 is at 19.2 Mhz).
> 
> By default, current fw selects clock-1 as parent.
> 
> Let me know, if explicitly we need to set parent as clock-1.
> 
> If yes then i will roll out v2 with current message , if no then please drop
> this patch

I personally do not see a need for the patch, then.
> 
> Thanks
> 
> Udit
> 
> > 
> > > Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> > You need to add your SoB.
> > > ---
> > > Link to v1: https://lore.kernel.org/all/20241009072056.3511346-1-b-kapoor@ti.com/
> > [..]

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


      reply	other threads:[~2025-06-09 12:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-03  4:24 [RESEND PATCH] arm64: dts: ti: k3-j784s4-mcu-wakeup: Configure wkup_uart0 with clock settings Udit Kumar
2025-06-03  9:22 ` Beleswar Prasad Padhi
2025-06-03  9:26 ` Beleswar Prasad Padhi
2025-06-03 16:01 ` Nishanth Menon
2025-06-04  9:55   ` Kumar, Udit
2025-06-08  7:17   ` Kumar, Udit
2025-06-09 12:00     ` Nishanth Menon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250609120032.yxmcyiw7dchv2kmp@wanted \
    --to=nm@ti.com \
    --cc=b-padhi@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox