From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sean Anderson <sean.anderson@linux.dev>
Cc: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Michal Simek <michal.simek@amd.com>,
Saravana Kannan <saravanak@google.com>,
Leon Romanovsky <leon@kernel.org>,
Dave Ertman <david.m.ertman@intel.com>,
linux-kernel@vger.kernel.org, Ira Weiny <ira.weiny@intel.com>,
linux-arm-kernel@lists.infradead.org,
Danilo Krummrich <dakr@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH net 1/4] auxiliary: Allow empty id
Date: Fri, 20 Jun 2025 07:13:21 +0200 [thread overview]
Message-ID: <2025062004-essay-pecan-d5be@gregkh> (raw)
In-Reply-To: <20250619200537.260017-2-sean.anderson@linux.dev>
On Thu, Jun 19, 2025 at 04:05:34PM -0400, Sean Anderson wrote:
> Support creating auxiliary devices with the id included as part of the
> name. This allows for non-decimal ids, which may be more appropriate for
> auxiliary devices created as children of memory-mapped devices. For
> example, a name like "xilinx_emac.mac.802c0000" could be achieved by
> setting .name to "mac.802c0000" and .id to AUXILIARY_DEVID_NONE.
I don't see the justification for this, sorry. An id is just an id, it
doesn't matter what is is and nothing should be relying on it to be the
same across reboots or anywhere else. The only requirement is that it
be unique at this point in time in the system.
We're having this same discussion on a different thread for a different
bus as well. This isn't something new, it's been hashed out and
resolved 20+ years ago...
So no, this change isn't ok to make at this point in time, sorry.
greg k-h
next prev parent reply other threads:[~2025-06-20 5:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 20:05 [PATCH net 0/4] net: axienet: Fix deferred probe loop Sean Anderson
2025-06-19 20:05 ` [PATCH net 1/4] auxiliary: Allow empty id Sean Anderson
2025-06-20 5:13 ` Greg Kroah-Hartman [this message]
2025-06-20 15:37 ` Sean Anderson
2025-06-20 16:02 ` Greg Kroah-Hartman
2025-06-20 16:09 ` Sean Anderson
2025-06-20 16:15 ` Greg Kroah-Hartman
2025-06-20 16:33 ` Sean Anderson
2025-06-19 20:05 ` [PATCH net 2/4] net: axienet: Fix resource release ordering Sean Anderson
2025-06-19 20:05 ` [PATCH net 3/4] net: axienet: Rearrange lifetime functions Sean Anderson
2025-06-19 20:05 ` [PATCH net 4/4] net: axienet: Split into MAC and MDIO drivers Sean Anderson
2025-06-19 23:10 ` Jakub Kicinski
2025-06-19 23:19 ` Sean Anderson
2025-06-20 14:03 ` kernel test robot
2025-06-21 7:33 ` Andrew Lunn
2025-06-23 15:16 ` Sean Anderson
2025-06-23 18:27 ` Andrew Lunn
2025-06-23 18:48 ` Sean Anderson
2025-06-23 22:45 ` Andrew Lunn
2025-06-23 23:16 ` Sean Anderson
2025-07-10 23:37 ` Sean Anderson
2025-06-20 5:10 ` [PATCH net 0/4] net: axienet: Fix deferred probe loop Greg Kroah-Hartman
2025-06-20 15:41 ` Sean Anderson
2025-06-20 16:01 ` Greg Kroah-Hartman
2025-06-20 16:34 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025062004-essay-pecan-d5be@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andrew+netdev@lunn.ch \
--cc=dakr@kernel.org \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=edumazet@google.com \
--cc=ira.weiny@intel.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
--cc=sean.anderson@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox