From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sean Anderson <sean.anderson@linux.dev>
Cc: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Michal Simek <michal.simek@amd.com>,
Saravana Kannan <saravanak@google.com>,
Leon Romanovsky <leon@kernel.org>,
Dave Ertman <david.m.ertman@intel.com>,
linux-kernel@vger.kernel.org, Ira Weiny <ira.weiny@intel.com>,
linux-arm-kernel@lists.infradead.org,
Danilo Krummrich <dakr@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH net 0/4] net: axienet: Fix deferred probe loop
Date: Fri, 20 Jun 2025 18:01:01 +0200 [thread overview]
Message-ID: <2025062054-tameness-canal-2204@gregkh> (raw)
In-Reply-To: <56f52836-545a-45aa-8a6b-04aa589c2583@linux.dev>
On Fri, Jun 20, 2025 at 11:41:52AM -0400, Sean Anderson wrote:
> On 6/20/25 01:10, Greg Kroah-Hartman wrote:
> > On Thu, Jun 19, 2025 at 04:05:33PM -0400, Sean Anderson wrote:
> >> Upon further investigation, the EPROBE_DEFER loop outlined in [1] can
> >> occur even without the PCS subsystem, as described in patch 4/4. The
> >> second patch is a general fix, and could be applied even without the
> >> auxdev conversion.
> >>
> >> [1] https://lore.kernel.org/all/20250610183459.3395328-1-sean.anderson@linux.dev/
> >
> > I have no idea what this summary means at all, which isn't a good start
> > to a patch series :(
> >
> > What problem are you trying to solve?
>
> See patch 4/4.
That's not what should be in patch 0/4 then, right?
> > What overall solution did you come up with?
>
> See patch 4/4.
Again, why write a 0/4 summary at all then?
> > Who is supposed to be reviewing any of this?
>
> Netdev. Hence "PATCH net".
>
> And see [1] above for background. I will quote it more-extensively next time.
Referring to random links doesn't always work as we deal with thousands
of patches daily, and sometimes don't even have internet access (like
when reviewing patches on long flights/train rides...)
Make things self-contained please.
thanks,
greg k-h
next prev parent reply other threads:[~2025-06-20 16:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 20:05 [PATCH net 0/4] net: axienet: Fix deferred probe loop Sean Anderson
2025-06-19 20:05 ` [PATCH net 1/4] auxiliary: Allow empty id Sean Anderson
2025-06-20 5:13 ` Greg Kroah-Hartman
2025-06-20 15:37 ` Sean Anderson
2025-06-20 16:02 ` Greg Kroah-Hartman
2025-06-20 16:09 ` Sean Anderson
2025-06-20 16:15 ` Greg Kroah-Hartman
2025-06-20 16:33 ` Sean Anderson
2025-06-19 20:05 ` [PATCH net 2/4] net: axienet: Fix resource release ordering Sean Anderson
2025-06-19 20:05 ` [PATCH net 3/4] net: axienet: Rearrange lifetime functions Sean Anderson
2025-06-19 20:05 ` [PATCH net 4/4] net: axienet: Split into MAC and MDIO drivers Sean Anderson
2025-06-19 23:10 ` Jakub Kicinski
2025-06-19 23:19 ` Sean Anderson
2025-06-20 14:03 ` kernel test robot
2025-06-21 7:33 ` Andrew Lunn
2025-06-23 15:16 ` Sean Anderson
2025-06-23 18:27 ` Andrew Lunn
2025-06-23 18:48 ` Sean Anderson
2025-06-23 22:45 ` Andrew Lunn
2025-06-23 23:16 ` Sean Anderson
2025-07-10 23:37 ` Sean Anderson
2025-06-20 5:10 ` [PATCH net 0/4] net: axienet: Fix deferred probe loop Greg Kroah-Hartman
2025-06-20 15:41 ` Sean Anderson
2025-06-20 16:01 ` Greg Kroah-Hartman [this message]
2025-06-20 16:34 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025062054-tameness-canal-2204@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andrew+netdev@lunn.ch \
--cc=dakr@kernel.org \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=edumazet@google.com \
--cc=ira.weiny@intel.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
--cc=sean.anderson@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox