Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: phy: imx8mq-usb: Drop ref for fsl,phy-pcs-tx-deemph-3p5db-attenuation-db
@ 2025-07-21  6:54 Peng Fan
  2025-07-21  9:39 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Peng Fan @ 2025-07-21  6:54 UTC (permalink / raw)
  To: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, Li Jun, Peng Fan, Xu Yang,
	Frank Li, open list:GENERIC PHY FRAMEWORK,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	open list

Address the device tree check warning: "phy@4c1f0040 (fsl,imx95-usb-phy):
fsl,phy-pcs-tx-deemph-3p5db-attenuation-db: 17 is not of type 'array'"

And dt_binding_check reports:
properties:fsl,phy-pcs-tx-deemph-3p5db-attenuation-db: '$ref' should not be
valid under {'const': '$ref'}
hint: Standard unit suffix properties don't need a type $ref

So remove ref for fsl,phy-pcs-tx-deemph-3p5db-attenuation-db.

Fixes: 04c9dd9c7d19 ("arm64: dts: imx95-evk: add USB3 PHY tuning properties")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml b/Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml
index 22dd91591a09..6a47e08e0e97 100644
--- a/Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml
@@ -76,7 +76,6 @@ properties:
     description:
       Adjust TX de-emphasis attenuation in dB at nominal
       3.5dB point as per USB specification
-    $ref: /schemas/types.yaml#/definitions/uint32
     minimum: 0
     maximum: 36
 
-- 
2.37.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: phy: imx8mq-usb: Drop ref for fsl,phy-pcs-tx-deemph-3p5db-attenuation-db
  2025-07-21  6:54 [PATCH] dt-bindings: phy: imx8mq-usb: Drop ref for fsl,phy-pcs-tx-deemph-3p5db-attenuation-db Peng Fan
@ 2025-07-21  9:39 ` Krzysztof Kozlowski
  2025-07-21 13:39   ` Peng Fan
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-21  9:39 UTC (permalink / raw)
  To: Peng Fan
  Cc: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, Li Jun, Xu Yang, Frank Li,
	open list:GENERIC PHY FRAMEWORK,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	open list

On Mon, Jul 21, 2025 at 02:54:24PM +0800, Peng Fan wrote:
> Address the device tree check warning: "phy@4c1f0040 (fsl,imx95-usb-phy):
> fsl,phy-pcs-tx-deemph-3p5db-attenuation-db: 17 is not of type 'array'"
> 
> And dt_binding_check reports:
> properties:fsl,phy-pcs-tx-deemph-3p5db-attenuation-db: '$ref' should not be
> valid under {'const': '$ref'}
> hint: Standard unit suffix properties don't need a type $ref
> 

I already sent it, since I did the change in dtschema...

https://lore.kernel.org/linux-devicetree/20250627-dt-bindings-db-v1-2-d5c7072acbee@linaro.org/

Best regards,
Krzysztof



^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: phy: imx8mq-usb: Drop ref for fsl,phy-pcs-tx-deemph-3p5db-attenuation-db
  2025-07-21  9:39 ` Krzysztof Kozlowski
@ 2025-07-21 13:39   ` Peng Fan
  0 siblings, 0 replies; 3+ messages in thread
From: Peng Fan @ 2025-07-21 13:39 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Peng Fan, Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, Li Jun, Xu Yang, Frank Li,
	open list:GENERIC PHY FRAMEWORK,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	open list

On Mon, Jul 21, 2025 at 11:39:11AM +0200, Krzysztof Kozlowski wrote:
>On Mon, Jul 21, 2025 at 02:54:24PM +0800, Peng Fan wrote:
>> Address the device tree check warning: "phy@4c1f0040 (fsl,imx95-usb-phy):
>> fsl,phy-pcs-tx-deemph-3p5db-attenuation-db: 17 is not of type 'array'"
>> 
>> And dt_binding_check reports:
>> properties:fsl,phy-pcs-tx-deemph-3p5db-attenuation-db: '$ref' should not be
>> valid under {'const': '$ref'}
>> hint: Standard unit suffix properties don't need a type $ref
>> 
>
>I already sent it, since I did the change in dtschema...
>
>https://lore.kernel.org/linux-devicetree/20250627-dt-bindings-db-v1-2-d5c7072acbee@linaro.org/

Thanks for letting me know, then drop my patch.

Thanks,
Peng

>
>Best regards,
>Krzysztof
>


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-21 13:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-21  6:54 [PATCH] dt-bindings: phy: imx8mq-usb: Drop ref for fsl,phy-pcs-tx-deemph-3p5db-attenuation-db Peng Fan
2025-07-21  9:39 ` Krzysztof Kozlowski
2025-07-21 13:39   ` Peng Fan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox