* [PATCH 03/13] PCI: rockchip-ep: Drop superfluous pci_epc_features initialization
2025-08-14 15:21 [PATCH 00/13] PCI: Drop superfluous pci_epc_features initialization Niklas Cassel
@ 2025-08-14 15:21 ` Niklas Cassel
2025-08-14 15:21 ` [PATCH 04/13] PCI: dra7xx: " Niklas Cassel
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Niklas Cassel @ 2025-08-14 15:21 UTC (permalink / raw)
To: Shawn Lin, Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas, Heiko Stuebner
Cc: Niklas Cassel, linux-pci, linux-rockchip, linux-arm-kernel
struct pci_epc_features has static storage duration, so all struct members
are zero initialized implicitly. Thus, remove explicit zero initialization
of struct members.
Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
drivers/pci/controller/pcie-rockchip-ep.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/controller/pcie-rockchip-ep.c
index 300cd85fa035..799461335762 100644
--- a/drivers/pci/controller/pcie-rockchip-ep.c
+++ b/drivers/pci/controller/pcie-rockchip-ep.c
@@ -694,7 +694,6 @@ static int rockchip_pcie_ep_setup_irq(struct pci_epc *epc)
static const struct pci_epc_features rockchip_pcie_epc_features = {
.linkup_notifier = true,
.msi_capable = true,
- .msix_capable = false,
.intx_capable = true,
.align = ROCKCHIP_PCIE_AT_SIZE_ALIGN,
};
--
2.50.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 04/13] PCI: dra7xx: Drop superfluous pci_epc_features initialization
2025-08-14 15:21 [PATCH 00/13] PCI: Drop superfluous pci_epc_features initialization Niklas Cassel
2025-08-14 15:21 ` [PATCH 03/13] PCI: rockchip-ep: " Niklas Cassel
@ 2025-08-14 15:21 ` Niklas Cassel
2025-08-14 15:21 ` [PATCH 05/13] PCI: imx6: " Niklas Cassel
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Niklas Cassel @ 2025-08-14 15:21 UTC (permalink / raw)
To: Vignesh Raghavendra, Siddharth Vadapalli, Lorenzo Pieralisi,
Krzysztof Wilczyński, Manivannan Sadhasivam, Rob Herring,
Bjorn Helgaas
Cc: Niklas Cassel, linux-omap, linux-pci, linux-arm-kernel
struct pci_epc_features has static storage duration, so all struct members
are zero initialized implicitly. Thus, remove explicit zero initialization
of struct members.
Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
drivers/pci/controller/dwc/pci-dra7xx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
index f97f5266d196..01cfd9aeb0b8 100644
--- a/drivers/pci/controller/dwc/pci-dra7xx.c
+++ b/drivers/pci/controller/dwc/pci-dra7xx.c
@@ -426,7 +426,6 @@ static int dra7xx_pcie_raise_irq(struct dw_pcie_ep *ep, u8 func_no,
static const struct pci_epc_features dra7xx_pcie_epc_features = {
.linkup_notifier = true,
.msi_capable = true,
- .msix_capable = false,
};
static const struct pci_epc_features*
--
2.50.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 05/13] PCI: imx6: Drop superfluous pci_epc_features initialization
2025-08-14 15:21 [PATCH 00/13] PCI: Drop superfluous pci_epc_features initialization Niklas Cassel
2025-08-14 15:21 ` [PATCH 03/13] PCI: rockchip-ep: " Niklas Cassel
2025-08-14 15:21 ` [PATCH 04/13] PCI: dra7xx: " Niklas Cassel
@ 2025-08-14 15:21 ` Niklas Cassel
2025-08-14 15:21 ` [PATCH 09/13] PCI: dw-rockchip: " Niklas Cassel
2025-08-14 15:50 ` [PATCH 00/13] PCI: " Bjorn Helgaas
4 siblings, 0 replies; 6+ messages in thread
From: Niklas Cassel @ 2025-08-14 15:21 UTC (permalink / raw)
To: Richard Zhu, Lucas Stach, Lorenzo Pieralisi,
Krzysztof Wilczyński, Manivannan Sadhasivam, Rob Herring,
Bjorn Helgaas, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam
Cc: Niklas Cassel, linux-pci, linux-arm-kernel, imx
struct pci_epc_features has static storage duration, so all struct members
are zero initialized implicitly. Thus, remove explicit zero initialization
of struct members.
Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
drivers/pci/controller/dwc/pci-imx6.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
index 80e48746bbaf..7ee21fac81a6 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -1387,9 +1387,7 @@ static int imx_pcie_ep_raise_irq(struct dw_pcie_ep *ep, u8 func_no,
}
static const struct pci_epc_features imx8m_pcie_epc_features = {
- .linkup_notifier = false,
.msi_capable = true,
- .msix_capable = false,
.bar[BAR_1] = { .type = BAR_RESERVED, },
.bar[BAR_3] = { .type = BAR_RESERVED, },
.bar[BAR_4] = { .type = BAR_FIXED, .fixed_size = SZ_256, },
@@ -1398,9 +1396,7 @@ static const struct pci_epc_features imx8m_pcie_epc_features = {
};
static const struct pci_epc_features imx8q_pcie_epc_features = {
- .linkup_notifier = false,
.msi_capable = true,
- .msix_capable = false,
.bar[BAR_1] = { .type = BAR_RESERVED, },
.bar[BAR_3] = { .type = BAR_RESERVED, },
.bar[BAR_5] = { .type = BAR_RESERVED, },
--
2.50.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 09/13] PCI: dw-rockchip: Drop superfluous pci_epc_features initialization
2025-08-14 15:21 [PATCH 00/13] PCI: Drop superfluous pci_epc_features initialization Niklas Cassel
` (2 preceding siblings ...)
2025-08-14 15:21 ` [PATCH 05/13] PCI: imx6: " Niklas Cassel
@ 2025-08-14 15:21 ` Niklas Cassel
2025-08-14 15:50 ` [PATCH 00/13] PCI: " Bjorn Helgaas
4 siblings, 0 replies; 6+ messages in thread
From: Niklas Cassel @ 2025-08-14 15:21 UTC (permalink / raw)
To: Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas, Heiko Stuebner
Cc: Niklas Cassel, linux-pci, linux-arm-kernel, linux-rockchip
struct pci_epc_features has static storage duration, so all struct members
are zero initialized implicitly. Thus, remove explicit zero initialization
of struct members.
Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
drivers/pci/controller/dwc/pcie-dw-rockchip.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
index b5f5eee5a50e..c045353fa493 100644
--- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c
+++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
@@ -325,7 +325,6 @@ static const struct pci_epc_features rockchip_pcie_epc_features_rk3568 = {
.linkup_notifier = true,
.msi_capable = true,
.msix_capable = true,
- .intx_capable = false,
.align = SZ_64K,
.bar[BAR_0] = { .type = BAR_RESIZABLE, },
.bar[BAR_1] = { .type = BAR_RESIZABLE, },
@@ -346,7 +345,6 @@ static const struct pci_epc_features rockchip_pcie_epc_features_rk3588 = {
.linkup_notifier = true,
.msi_capable = true,
.msix_capable = true,
- .intx_capable = false,
.align = SZ_64K,
.bar[BAR_0] = { .type = BAR_RESIZABLE, },
.bar[BAR_1] = { .type = BAR_RESIZABLE, },
--
2.50.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 00/13] PCI: Drop superfluous pci_epc_features initialization
2025-08-14 15:21 [PATCH 00/13] PCI: Drop superfluous pci_epc_features initialization Niklas Cassel
` (3 preceding siblings ...)
2025-08-14 15:21 ` [PATCH 09/13] PCI: dw-rockchip: " Niklas Cassel
@ 2025-08-14 15:50 ` Bjorn Helgaas
4 siblings, 0 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2025-08-14 15:50 UTC (permalink / raw)
To: Niklas Cassel
Cc: Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas,
Vignesh Raghavendra, Siddharth Vadapalli, Richard Zhu,
Lucas Stach, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, Jesper Nilsson, Jingoo Han, Heiko Stuebner,
Srikanth Thokala, Marek Vasut, Yoshihiro Shimoda,
Geert Uytterhoeven, Magnus Damm, Thierry Reding, Jonathan Hunter,
Shawn Lin, linux-pci, linux-omap, linux-arm-kernel, imx,
linux-arm-kernel, linux-rockchip, linux-arm-msm,
linux-renesas-soc, linux-tegra
On Thu, Aug 14, 2025 at 05:21:19PM +0200, Niklas Cassel wrote:
> Hello all,
>
> struct pci_epc_features has static storage duration, so all struct members
> are zero initialized implicitly. Thus, remove explicit zero initialization
> of struct members.
>
> Series is based on pci/next.
>
> Feel free to squash to a single commit if that is preferable.
>
> Kind regards,
> Niklas
>
>
> Niklas Cassel (13):
> PCI: cadence-ep: Drop superfluous pci_epc_features initialization
> PCI: rcar-ep: Drop superfluous pci_epc_features initialization
> PCI: rockchip-ep: Drop superfluous pci_epc_features initialization
> PCI: dra7xx: Drop superfluous pci_epc_features initialization
> PCI: imx6: Drop superfluous pci_epc_features initialization
> PCI: keystone: Drop superfluous pci_epc_features initialization
> PCI: artpec6: Drop superfluous pci_epc_features initialization
> PCI: designware-plat: Drop superfluous pci_epc_features initialization
> PCI: dw-rockchip: Drop superfluous pci_epc_features initialization
> PCI: keembay: Drop superfluous pci_epc_features initialization
> PCI: qcom-ep: Drop superfluous pci_epc_features initialization
> PCI: rcar-gen4: Drop superfluous pci_epc_features initialization
> PCI: tegra194: Drop superfluous pci_epc_features initialization
>
> drivers/pci/controller/cadence/pcie-cadence-ep.c | 2 --
> drivers/pci/controller/dwc/pci-dra7xx.c | 1 -
> drivers/pci/controller/dwc/pci-imx6.c | 4 ----
> drivers/pci/controller/dwc/pci-keystone.c | 1 -
> drivers/pci/controller/dwc/pcie-artpec6.c | 2 --
> drivers/pci/controller/dwc/pcie-designware-plat.c | 1 -
> drivers/pci/controller/dwc/pcie-dw-rockchip.c | 2 --
> drivers/pci/controller/dwc/pcie-keembay.c | 1 -
> drivers/pci/controller/dwc/pcie-qcom-ep.c | 1 -
> drivers/pci/controller/dwc/pcie-rcar-gen4.c | 2 --
> drivers/pci/controller/dwc/pcie-tegra194.c | 2 --
> drivers/pci/controller/pcie-rcar-ep.c | 2 --
> drivers/pci/controller/pcie-rockchip-ep.c | 1 -
> 13 files changed, 22 deletions(-)
Squashed into one, added "remove explicit zero initialization for
features that are *not* supported so we don't have to touch existing
drivers as new features are added" to commit log, and applied to
pci/endpoint for v6.18, thanks, Niklas!
^ permalink raw reply [flat|nested] 6+ messages in thread