Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Randolph Sapp <rs@ti.com>
Cc: <vigneshr@ti.com>, <kristo@kernel.org>, <robh@kernel.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>, <d-gole@ti.com>,
	<afd@ti.com>, <bb@ti.com>, <linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<detheridge@ti.com>, <matt.coster@imgtec.com>,
	Michael Walle <mwalle@kernel.org>
Subject: Re: [PATCH 2/3] arm64: dts: ti: k3-am62p-j722s: enable the bxs-4-64
Date: Thu, 14 Aug 2025 20:16:21 -0500	[thread overview]
Message-ID: <20250815011621.rrdurnk6ueexwldw@hertz> (raw)
In-Reply-To: <DC2FWE35CXPV.YM6MK820R2PV@ti.com>

On 15:40-20250814, Randolph Sapp wrote:
> On Wed Aug 13, 2025 at 1:42 PM CDT, Nishanth Menon wrote:
> > On 12:56-20250813, Randolph Sapp wrote:
> > [...]
> >
> >> >> +		reg = <0x00 0x0fd80000 0x00 0x80000>;
> >> >> +		clocks = <&k3_clks 237 1>;
> >> >> +		clock-names = "core";
> >> >> +		assigned-clocks = <&k3_clks 237 1>;
> >> >> +		assigned-clock-rates = <800000000>;
> >
> > btw, as per https://www.ti.com/lit/ds/symlink/tda4aen-q1.pdf (page 86)
> > 720MHz when vdd_core is 0.75v (default)
> > and 800MHz when vdd_core is 0.85v
> >
> > 0.85v is set in the board dts and higher OPPs are enabled depending on
> > board capability.
> >
> > You might want to check the assigned-clock-rates based on data sheet,
> > default should'nt need a assigned-clock-rate.
> 
> Are you suggesting that we set assigned-clock-rates in the board dts instead, or
> do you just want to do away with assigned-clock-rates in general and eat the
> perf difference?

The higher frequency is possible unless you know that the board is setup
for the higher voltage. So, set it board device tree file.

Look at what we did with OPP-High support on AM625 for example. That
frequency can only be reliably achieved if vdd_core is 0.85v. And base
SoC dtsi must assume safe default (min voltage of 0.75v) as the node is
enabled by default.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
https://ti.com/opensource


  reply	other threads:[~2025-08-15  1:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-08 23:25 [PATCH 1/3] arm64: dts: ti: k3-am62p: Fix memory ranges for GPU rs
2025-08-08 23:25 ` [PATCH 2/3] arm64: dts: ti: k3-am62p-j722s: enable the bxs-4-64 rs
2025-08-13 15:17   ` Nishanth Menon
2025-08-13 17:56     ` Randolph Sapp
2025-08-13 18:10       ` Nishanth Menon
2025-08-13 18:42       ` Nishanth Menon
2025-08-14 20:40         ` Randolph Sapp
2025-08-15  1:16           ` Nishanth Menon [this message]
2025-08-08 23:25 ` [PATCH 3/3] arm64: dts: ti: k3-j784s4-j742s2: " rs
2025-08-13 15:18   ` Nishanth Menon
2025-08-13 17:58     ` Randolph Sapp
2025-08-13 18:13       ` Nishanth Menon
2025-08-18  6:22         ` Michael Walle
2025-08-18 19:43           ` Randolph Sapp
2025-08-19  6:38             ` Michael Walle
2025-08-19 20:47               ` Randolph Sapp
2025-08-21 11:33                 ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250815011621.rrdurnk6ueexwldw@hertz \
    --to=nm@ti.com \
    --cc=afd@ti.com \
    --cc=bb@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=d-gole@ti.com \
    --cc=detheridge@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.coster@imgtec.com \
    --cc=mwalle@kernel.org \
    --cc=robh@kernel.org \
    --cc=rs@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox