* [PATCH 2/2] usb: chipidea: imx: add USB support for i.MX94
2025-09-19 7:11 [PATCH 1/2] dt-bindings: usb: usbmisc-imx: add fsl,imx94-usbmisc compatible Xu Yang
@ 2025-09-19 7:11 ` Xu Yang
2025-09-19 15:45 ` Frank Li
2025-09-25 1:38 ` Peter Chen (CIX)
2025-09-19 15:43 ` [PATCH 1/2] dt-bindings: usb: usbmisc-imx: add fsl,imx94-usbmisc compatible Frank Li
2025-09-19 17:14 ` Conor Dooley
2 siblings, 2 replies; 6+ messages in thread
From: Xu Yang @ 2025-09-19 7:11 UTC (permalink / raw)
To: gregkh, robh, krzk+dt, conor+dt, peter.chen, shawnguo, s.hauer,
kernel, festevam, peng.fan, jun.li
Cc: linux-usb, devicetree, linux-kernel, imx, linux-arm-kernel
Add new imx94_usbmisc_ops for i.MX94 due to it has same wakeup logic
as i.MX95, but it doesn't need workaround for ERR051725, so pullup
is not needed.
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
drivers/usb/chipidea/usbmisc_imx.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
index b1418885707c..bb027d2bd700 100644
--- a/drivers/usb/chipidea/usbmisc_imx.c
+++ b/drivers/usb/chipidea/usbmisc_imx.c
@@ -1224,6 +1224,14 @@ static const struct usbmisc_ops imx7ulp_usbmisc_ops = {
.power_lost_check = usbmisc_imx7d_power_lost_check,
};
+static const struct usbmisc_ops imx94_usbmisc_ops = {
+ .init = usbmisc_imx7d_init,
+ .set_wakeup = usbmisc_imx95_set_wakeup,
+ .charger_detection = imx7d_charger_detection,
+ .power_lost_check = usbmisc_imx7d_power_lost_check,
+ .vbus_comparator_on = usbmisc_imx7d_vbus_comparator_on,
+};
+
static const struct usbmisc_ops imx95_usbmisc_ops = {
.init = usbmisc_imx7d_init,
.set_wakeup = usbmisc_imx95_set_wakeup,
@@ -1481,6 +1489,10 @@ static const struct of_device_id usbmisc_imx_dt_ids[] = {
.compatible = "fsl,imx8ulp-usbmisc",
.data = &imx7ulp_usbmisc_ops,
},
+ {
+ .compatible = "fsl,imx94-usbmisc",
+ .data = &imx94_usbmisc_ops,
+ },
{
.compatible = "fsl,imx95-usbmisc",
.data = &imx95_usbmisc_ops,
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] usb: chipidea: imx: add USB support for i.MX94
2025-09-19 7:11 ` [PATCH 2/2] usb: chipidea: imx: add USB support for i.MX94 Xu Yang
@ 2025-09-19 15:45 ` Frank Li
2025-09-25 1:38 ` Peter Chen (CIX)
1 sibling, 0 replies; 6+ messages in thread
From: Frank Li @ 2025-09-19 15:45 UTC (permalink / raw)
To: Xu Yang
Cc: gregkh, robh, krzk+dt, conor+dt, peter.chen, shawnguo, s.hauer,
kernel, festevam, peng.fan, jun.li, linux-usb, devicetree,
linux-kernel, imx, linux-arm-kernel
On Fri, Sep 19, 2025 at 03:11:11PM +0800, Xu Yang wrote:
> Add new imx94_usbmisc_ops for i.MX94 due to it has same wakeup logic
> as i.MX95, but it doesn't need workaround for ERR051725, so pullup
> is not needed.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
> drivers/usb/chipidea/usbmisc_imx.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
> index b1418885707c..bb027d2bd700 100644
> --- a/drivers/usb/chipidea/usbmisc_imx.c
> +++ b/drivers/usb/chipidea/usbmisc_imx.c
> @@ -1224,6 +1224,14 @@ static const struct usbmisc_ops imx7ulp_usbmisc_ops = {
> .power_lost_check = usbmisc_imx7d_power_lost_check,
> };
>
> +static const struct usbmisc_ops imx94_usbmisc_ops = {
> + .init = usbmisc_imx7d_init,
> + .set_wakeup = usbmisc_imx95_set_wakeup,
> + .charger_detection = imx7d_charger_detection,
> + .power_lost_check = usbmisc_imx7d_power_lost_check,
> + .vbus_comparator_on = usbmisc_imx7d_vbus_comparator_on,
> +};
> +
> static const struct usbmisc_ops imx95_usbmisc_ops = {
> .init = usbmisc_imx7d_init,
> .set_wakeup = usbmisc_imx95_set_wakeup,
> @@ -1481,6 +1489,10 @@ static const struct of_device_id usbmisc_imx_dt_ids[] = {
> .compatible = "fsl,imx8ulp-usbmisc",
> .data = &imx7ulp_usbmisc_ops,
> },
> + {
> + .compatible = "fsl,imx94-usbmisc",
> + .data = &imx94_usbmisc_ops,
> + },
> {
> .compatible = "fsl,imx95-usbmisc",
> .data = &imx95_usbmisc_ops,
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] usb: chipidea: imx: add USB support for i.MX94
2025-09-19 7:11 ` [PATCH 2/2] usb: chipidea: imx: add USB support for i.MX94 Xu Yang
2025-09-19 15:45 ` Frank Li
@ 2025-09-25 1:38 ` Peter Chen (CIX)
1 sibling, 0 replies; 6+ messages in thread
From: Peter Chen (CIX) @ 2025-09-25 1:38 UTC (permalink / raw)
To: Xu Yang
Cc: gregkh, robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, peng.fan, jun.li, linux-usb, devicetree, linux-kernel,
imx, linux-arm-kernel
On 25-09-19 15:11:11, Xu Yang wrote:
> Add new imx94_usbmisc_ops for i.MX94 due to it has same wakeup logic
> as i.MX95, but it doesn't need workaround for ERR051725, so pullup
> is not needed.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
Acked-by: Peter Chen <peter.chen@kernel.org>
Peter
> ---
> drivers/usb/chipidea/usbmisc_imx.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
> index b1418885707c..bb027d2bd700 100644
> --- a/drivers/usb/chipidea/usbmisc_imx.c
> +++ b/drivers/usb/chipidea/usbmisc_imx.c
> @@ -1224,6 +1224,14 @@ static const struct usbmisc_ops imx7ulp_usbmisc_ops = {
> .power_lost_check = usbmisc_imx7d_power_lost_check,
> };
>
> +static const struct usbmisc_ops imx94_usbmisc_ops = {
> + .init = usbmisc_imx7d_init,
> + .set_wakeup = usbmisc_imx95_set_wakeup,
> + .charger_detection = imx7d_charger_detection,
> + .power_lost_check = usbmisc_imx7d_power_lost_check,
> + .vbus_comparator_on = usbmisc_imx7d_vbus_comparator_on,
> +};
> +
> static const struct usbmisc_ops imx95_usbmisc_ops = {
> .init = usbmisc_imx7d_init,
> .set_wakeup = usbmisc_imx95_set_wakeup,
> @@ -1481,6 +1489,10 @@ static const struct of_device_id usbmisc_imx_dt_ids[] = {
> .compatible = "fsl,imx8ulp-usbmisc",
> .data = &imx7ulp_usbmisc_ops,
> },
> + {
> + .compatible = "fsl,imx94-usbmisc",
> + .data = &imx94_usbmisc_ops,
> + },
> {
> .compatible = "fsl,imx95-usbmisc",
> .data = &imx95_usbmisc_ops,
> --
> 2.34.1
>
--
Best regards,
Peter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: usb: usbmisc-imx: add fsl,imx94-usbmisc compatible
2025-09-19 7:11 [PATCH 1/2] dt-bindings: usb: usbmisc-imx: add fsl,imx94-usbmisc compatible Xu Yang
2025-09-19 7:11 ` [PATCH 2/2] usb: chipidea: imx: add USB support for i.MX94 Xu Yang
@ 2025-09-19 15:43 ` Frank Li
2025-09-19 17:14 ` Conor Dooley
2 siblings, 0 replies; 6+ messages in thread
From: Frank Li @ 2025-09-19 15:43 UTC (permalink / raw)
To: Xu Yang
Cc: gregkh, robh, krzk+dt, conor+dt, peter.chen, shawnguo, s.hauer,
kernel, festevam, peng.fan, jun.li, linux-usb, devicetree,
linux-kernel, imx, linux-arm-kernel
On Fri, Sep 19, 2025 at 03:11:10PM +0800, Xu Yang wrote:
> Add "fsl,imx94-usbmisc" compatible.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
> Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> index ca677d1a8274..d06efe4dbb3b 100644
> --- a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> @@ -36,6 +36,7 @@ properties:
> - fsl,imx8mm-usbmisc
> - fsl,imx8mn-usbmisc
> - fsl,imx8ulp-usbmisc
> + - fsl,imx94-usbmisc
> - fsl,imx95-usbmisc
> - const: fsl,imx7d-usbmisc
> - const: fsl,imx6q-usbmisc
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: usb: usbmisc-imx: add fsl,imx94-usbmisc compatible
2025-09-19 7:11 [PATCH 1/2] dt-bindings: usb: usbmisc-imx: add fsl,imx94-usbmisc compatible Xu Yang
2025-09-19 7:11 ` [PATCH 2/2] usb: chipidea: imx: add USB support for i.MX94 Xu Yang
2025-09-19 15:43 ` [PATCH 1/2] dt-bindings: usb: usbmisc-imx: add fsl,imx94-usbmisc compatible Frank Li
@ 2025-09-19 17:14 ` Conor Dooley
2 siblings, 0 replies; 6+ messages in thread
From: Conor Dooley @ 2025-09-19 17:14 UTC (permalink / raw)
To: Xu Yang
Cc: gregkh, robh, krzk+dt, conor+dt, peter.chen, shawnguo, s.hauer,
kernel, festevam, peng.fan, jun.li, linux-usb, devicetree,
linux-kernel, imx, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 52 bytes --]
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread