From: Bjorn Helgaas <helgaas@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
chester62515@gmail.com, mbrugger@suse.com,
ghennadi.procopciuc@oss.nxp.com, s32@nxp.com,
bhelgaas@google.com, jingoohan1@gmail.com, lpieralisi@kernel.org,
kwilczynski@kernel.org, mani@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, Ionut.Vicovan@nxp.com,
larisa.grigore@nxp.com, Ghennadi.Procopciuc@nxp.com,
ciprianmarian.costea@nxp.com, bogdan.hamciuc@nxp.com,
Frank.li@nxp.com, linux-arm-kernel@lists.infradead.org,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
cassel@kernel.org
Subject: Re: [PATCH 2/3 v2] PCI: s32g: Add initial PCIe support (RC)
Date: Thu, 25 Sep 2025 14:15:20 -0500 [thread overview]
Message-ID: <20250925191520.GA2175949@bhelgaas> (raw)
In-Reply-To: <CAL_JsqJMibSgsEFeUvHswVy6zsHMn7ZXkpbhch06oQxPY9NocQ@mail.gmail.com>
On Mon, Sep 22, 2025 at 09:52:21AM -0500, Rob Herring wrote:
> On Fri, Sep 19, 2025 at 10:58 AM Vincent Guittot
> > Add initial support of the PCIe controller for S32G Soc family. Only
> > host mode is supported.
> > +++ b/drivers/pci/controller/dwc/Kconfig
> > @@ -255,6 +255,17 @@ config PCIE_TEGRA194_EP
> > in order to enable device-specific features PCIE_TEGRA194_EP must be
> > selected. This uses the DesignWare core.
> >
> > +config PCIE_S32G
> > + bool "NXP S32G PCIe controller (host mode)"
> > + depends on ARCH_S32 || (OF && COMPILE_TEST)
>
> Why the OF dependency? All the DT API should be available with !CONFIG_OF.
We have lots of similar OF dependencies. Do we really want it to be
possible to build a non-working driver in the !COMPILE_TEST case?
Maybe we should retain the OF dependency but only for !COMPILE_TEST,
like this:
config PCIE_S32G
depends on (ARCH_S32 && OF) || COMPILE_TEST
next prev parent reply other threads:[~2025-09-25 19:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 15:58 [PATCH 0/4 v2] PCI: s32g: Add support for PCIe controller Vincent Guittot
2025-09-19 15:58 ` [PATCH 1/3 v2] dt-bindings: PCI: s32g: Add NXP " Vincent Guittot
2025-09-19 16:39 ` Frank Li
2025-09-23 14:49 ` Vincent Guittot
2025-09-23 16:28 ` Frank Li
2025-09-22 6:21 ` Manivannan Sadhasivam
2025-09-23 17:40 ` Vincent Guittot
2025-10-07 15:41 ` Lorenzo Pieralisi
2025-10-07 22:28 ` Manivannan Sadhasivam
2025-10-08 8:26 ` Arnd Bergmann
2025-10-08 8:35 ` Arnd Bergmann
2025-10-08 15:19 ` Manivannan Sadhasivam
2025-10-08 17:56 ` Arnd Bergmann
2025-10-09 18:47 ` Manivannan Sadhasivam
2025-10-09 21:16 ` Arnd Bergmann
2025-10-17 15:12 ` Manivannan Sadhasivam
2025-10-08 15:14 ` Manivannan Sadhasivam
2025-09-19 15:58 ` [PATCH 2/3 v2] PCI: s32g: Add initial PCIe support (RC) Vincent Guittot
2025-09-19 17:03 ` [External] : " ALOK TIWARI
2025-09-19 18:37 ` Frank Li
2025-09-25 17:09 ` Vincent Guittot
2025-09-22 4:07 ` kernel test robot
2025-09-22 7:56 ` Manivannan Sadhasivam
2025-09-25 16:52 ` Vincent Guittot
2025-09-29 13:57 ` Manivannan Sadhasivam
2025-09-29 16:23 ` Vincent Guittot
2025-09-29 16:32 ` Manivannan Sadhasivam
2025-09-30 16:11 ` Vincent Guittot
2025-09-22 14:52 ` Rob Herring
2025-09-25 16:56 ` Vincent Guittot
2025-09-25 19:15 ` Bjorn Helgaas [this message]
2025-09-26 14:18 ` Rob Herring
2025-09-19 15:58 ` [PATCH 3/3 v2] MAINTAINERS: Add MAINTAINER for NXP S32G PCIe driver Vincent Guittot
2025-09-19 16:58 ` Frank Li
2025-09-25 17:16 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250925191520.GA2175949@bhelgaas \
--to=helgaas@kernel.org \
--cc=Frank.li@nxp.com \
--cc=Ghennadi.Procopciuc@nxp.com \
--cc=Ionut.Vicovan@nxp.com \
--cc=bhelgaas@google.com \
--cc=bogdan.hamciuc@nxp.com \
--cc=cassel@kernel.org \
--cc=chester62515@gmail.com \
--cc=ciprianmarian.costea@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ghennadi.procopciuc@oss.nxp.com \
--cc=imx@lists.linux.dev \
--cc=jingoohan1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=larisa.grigore@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=mbrugger@suse.com \
--cc=robh@kernel.org \
--cc=s32@nxp.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox