Re: [PATCH v3 1/6] dt-bindings: arm: fsl: Add GOcontroll Moduline IV/Mini

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1624 bytes --]

On Thu, Oct 30, 2025 at 07:35:37AM +0100, Maud Spierings via B4 Relay wrote:
> From: Maud Spierings <maudspierings@gocontroll.com>
> 
> Document the compatible strings for the Moduline IV and Mini.

> Also add a compatible for the Ka-Ro Electronics TX8M-1610

This is not very helpful to say, makes what you've done seem accidental.
I assumed this was wrong, until I looked up this device and found out it
was a SoM. Please put that in the commit message.
With that info,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: changes-requested

> 
> Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 00cdf490b0620..15000923b648a 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -996,6 +996,14 @@ properties:
>            - const: engicam,icore-mx8mm             # i.MX8MM Engicam i.Core MX8M Mini SoM
>            - const: fsl,imx8mm
>  
> +      - description: Ka-Ro Electronics TX8M-1610 based boards
> +        items:
> +          - enum:
> +              - gocontroll,moduline-iv-306-d
> +              - gocontroll,moduline-mini-111
> +          - const: karo,imx8mm-tx8m-1610
> +          - const: fsl,imx8mm
> +
>        - description: Kontron BL i.MX8MM (N801X S) Board
>          items:
>            - const: kontron,imx8mm-bl
> 
> -- 
> 2.51.2
> 
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]