Re: [PATCH 01/11] dt-bindings: hwinfo: samsung,exynos-chipid: add google,gs101 compatible

[Krzysztof Kozlowski <krzk@kernel.org>]

On Fri, Oct 31, 2025 at 12:56:00PM +0000, Tudor Ambarus wrote:
> Google GS101 Chip ID references the nvmem cells from the OTP controller,
> it doesn't need a reg space. Add the google,gs101-chipid compatible.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
>  .../bindings/hwinfo/samsung,exynos-chipid.yaml     | 51 +++++++++++++++++++++-
>  1 file changed, 50 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
> index b9cdfe52b62ff3a365d61368c39db21facff6565..6d6260be02d47712ebf1e4d31973802e8340cdfe 100644
> --- a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
> +++ b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
> @@ -33,6 +33,16 @@ properties:
>                - samsung,exynosautov9-chipid
>                - samsung,exynosautov920-chipid
>            - const: samsung,exynos850-chipid
> +      - items:
> +          - const: google,gs101-chipid

That's a part of first enum at the beginning.

> +
> +  nvmem-cells:
> +    maxItems: 2
> +
> +  nvmem-cell-names:
> +    items:
> +      - const: product-id
> +      - const: chip-id
>  
>    reg:
>      maxItems: 1
> @@ -47,7 +57,46 @@ properties:
>  
>  required:
>    - compatible
> -  - reg
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            oneOf:

No, don't copy. It's just redundant. Just like the fallbacks under one
enum.

> +              - enum:
> +                  - samsung,exynos4210-chipid
> +                  - samsung,exynos850-chipid
> +              - items:
> +                  - enum:
> +                      - samsung,exynos5433-chipid
> +                      - samsung,exynos7-chipid
> +                      - samsung,exynos7870-chipid
> +                      - samsung,exynos8890-chipid
> +                  - const: samsung,exynos4210-chipid
> +              - items:
> +                  - enum:
> +                      - samsung,exynos2200-chipid
> +                      - samsung,exynos7885-chipid
> +                      - samsung,exynos8895-chipid
> +                      - samsung,exynos9610-chipid
> +                      - samsung,exynos9810-chipid
> +                      - samsung,exynos990-chipid
> +                      - samsung,exynosautov9-chipid
> +                      - samsung,exynosautov920-chipid
> +                  - const: samsung,exynos850-chipid
> +    then:

properties:
  nvmem-cells: false
  same for names

> +      required:
> +        - reg
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: google,gs101-chipid
> +    then:

reg: false, similarly.

> +      required:
> +        - nvmem-cells
> +        - nvmem-cell-names
>  
>  additionalProperties: false
>  
> 
> -- 
> 2.51.1.930.gacf6e81ea2-goog
>