From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Peter Griffin" <peter.griffin@linaro.org>,
"André Draszik" <andre.draszik@linaro.org>,
semen.protsenko@linaro.org, willmcvicker@google.com,
kernel-team@android.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/11] arm64: dts: exynos: gs101: add the chipid node
Date: Mon, 3 Nov 2025 11:18:15 +0100 [thread overview]
Message-ID: <20251103-pompous-lean-jerboa-c7b8ee@kuoka> (raw)
In-Reply-To: <20251031-gs101-chipid-v1-10-d78d1076b210@linaro.org>
On Fri, Oct 31, 2025 at 12:56:09PM +0000, Tudor Ambarus wrote:
> Add the chipid node.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> arch/arm64/boot/dts/exynos/google/gs101.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> index d06d1d05f36408137a8acd98e43d48ea7d4f4292..11622da2d46ff257b447a3dfdc98abdf29a45b9a 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> @@ -467,6 +467,12 @@ opp-2802000000 {
> };
> };
>
> + chipid {
> + compatible = "google,gs101-chipid";
That's not a real device, sorry.
I had some doubts when reading the bindings, then more when reading
driver - like chipid probe() was basically empty, no single device
access, except calling other kernel subsystem - and now here no single
actual hardware resource, except reference to other node.
Are you REALLY REALLY sure you have in your datasheet such device as
chipid?
It is damn basic question, which you should start with.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-03 10:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 12:55 [PATCH 00/11] soc: samsung: exynos-chipid: add gs101 support Tudor Ambarus
2025-10-31 12:56 ` [PATCH 01/11] dt-bindings: hwinfo: samsung,exynos-chipid: add google,gs101 compatible Tudor Ambarus
2025-11-03 9:58 ` Krzysztof Kozlowski
2025-10-31 12:56 ` [PATCH 02/11] soc: samsung: exynos-chipid: use a local dev variable Tudor Ambarus
2025-11-03 10:02 ` (subset) " Krzysztof Kozlowski
2025-10-31 12:56 ` [PATCH 03/11] soc: samsung: exynos-chipid: use heap allocated driver data Tudor Ambarus
2025-11-03 10:03 ` Krzysztof Kozlowski
2025-10-31 12:56 ` [PATCH 04/11] soc: samsung: exynos-chipid: refer to match->data as data Tudor Ambarus
2025-11-03 10:05 ` Krzysztof Kozlowski
2025-10-31 12:56 ` [PATCH 05/11] soc: samsung: exynos-chipid: introduce match_data->get_chipid_info() Tudor Ambarus
2025-11-03 10:15 ` Krzysztof Kozlowski
2025-10-31 12:56 ` [PATCH 06/11] soc: samsung: exynos-chipid: make asv_init opt-in Tudor Ambarus
2025-10-31 12:56 ` [PATCH 07/11] soc: samsung: exynos-chipid: add support for google,gs101-chipid Tudor Ambarus
2025-10-31 12:56 ` [PATCH 08/11] soc: samsung: exynos-chipid: prepend exynos_ to a method's name Tudor Ambarus
2025-10-31 12:56 ` [PATCH 09/11] soc: samsung: exynos-chipid: downgrade dev_info to dev_dbg for soc info Tudor Ambarus
2025-10-31 12:56 ` [PATCH 10/11] arm64: dts: exynos: gs101: add the chipid node Tudor Ambarus
2025-11-03 10:18 ` Krzysztof Kozlowski [this message]
2025-11-03 10:50 ` Tudor Ambarus
2025-11-03 11:01 ` Krzysztof Kozlowski
2025-11-03 11:26 ` Tudor Ambarus
2025-11-04 7:14 ` Krzysztof Kozlowski
2025-11-10 9:28 ` Tudor Ambarus
2025-10-31 12:56 ` [PATCH 11/11] arm64: defconfig: enable Samsung Exynos chipid driver Tudor Ambarus
2025-11-03 10:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251103-pompous-lean-jerboa-c7b8ee@kuoka \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox