[PATCH v2] remoteproc: imx_rproc: Check return value of regmap_attach_dev() in imx_rproc_mmio_detect_mode()

[PATCH v2] remoteproc: imx_rproc: Check return value of regmap_attach_dev() in imx_rproc_mmio_detect_mode()

[Chen Ni]

Add error checking for regmap_attach_dev() call in
imx_rproc_mmio_detect_mode() function to ensure proper error
propagation.

Return the value of regmap_attach_dev() if it fails to prevent
proceeding with an incomplete regmap setup.

Suggested-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
Changes in v2:
- Use dev_err() + return ret instead of dev_err_probe()
---
 drivers/remoteproc/imx_rproc.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index f5f916d67905..75baf905988b 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -1007,7 +1007,11 @@ static int imx_rproc_mmio_detect_mode(struct rproc *rproc)
 	}
 
 	priv->regmap = regmap;
-	regmap_attach_dev(dev, regmap, &config);
+	ret = regmap_attach_dev(dev, regmap, &config);
+	if (ret) {
+		dev_err(dev, "regmap attach failed\n");
+		return ret;
+	}
 
 	if (priv->gpr) {
 		ret = regmap_read(priv->gpr, dcfg->gpr_reg, &val);
-- 
2.25.1

Re: [PATCH v2] remoteproc: imx_rproc: Check return value of regmap_attach_dev() in imx_rproc_mmio_detect_mode()

[Frank Li]

On Mon, Feb 09, 2026 at 01:14:07PM +0800, Chen Ni wrote:
> Add error checking for regmap_attach_dev() call in
> imx_rproc_mmio_detect_mode() function to ensure proper error
> propagation.
>
> Return the value of regmap_attach_dev() if it fails to prevent
> proceeding with an incomplete regmap setup.
>
> Suggested-by: Peng Fan <peng.fan@nxp.com>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> Changes in v2:
> - Use dev_err() + return ret instead of dev_err_probe()

why?

Frank
> ---
>  drivers/remoteproc/imx_rproc.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index f5f916d67905..75baf905988b 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -1007,7 +1007,11 @@ static int imx_rproc_mmio_detect_mode(struct rproc *rproc)
>  	}
>
>  	priv->regmap = regmap;
> -	regmap_attach_dev(dev, regmap, &config);
> +	ret = regmap_attach_dev(dev, regmap, &config);
> +	if (ret) {
> +		dev_err(dev, "regmap attach failed\n");
> +		return ret;
> +	}
>
>  	if (priv->gpr) {
>  		ret = regmap_read(priv->gpr, dcfg->gpr_reg, &val);
> --
> 2.25.1
>

Re: [PATCH v2] remoteproc: imx_rproc: Check return value of regmap_attach_dev() in imx_rproc_mmio_detect_mode()

[Chen Ni]

On Mon, Feb 09, 2026 at 11:36:51AM -0500, Frank Li wrote:
> On Mon, Feb 09, 2026 at 01:14:07PM +0800, Chen Ni wrote:
> > Changes in v2:
> > - Use dev_err() + return ret instead of dev_err_probe()
> 
> why?
> 
> Frank

Hi Frank,

The replacement of dev_err_probe() with dev_err() + return ret is based
on two key reasons:

1. Consistency with existing code style in imx_rproc_mmio_detect_mode():
   The upper-level probe function already uses dev_err_probe() to handle
   errors from this function, and all other error paths here also use
   "dev_err() + return ret", so this change aligns with the existing
   coding style.

2. Technical rationale from community feedback:
   regmap_attach_dev() only returns -ENOMEM errors, and dev_err_probe() is
   silent for -ENOMEM errors [1]. Using dev_err() ensures the error is
   logged clearly, while returning the original ret maintains proper error
   propagation.

[1] 2f3cfd2f4b7c ("driver core: Make dev_err_probe() silent for -ENOMEM")

Best regards,
Chen Ni

Re: [PATCH v2] remoteproc: imx_rproc: Check return value of regmap_attach_dev() in imx_rproc_mmio_detect_mode()

[Frank Li]

On Tue, Feb 10, 2026 at 01:07:44PM +0800, Chen Ni wrote:
> On Mon, Feb 09, 2026 at 11:36:51AM -0500, Frank Li wrote:
> > On Mon, Feb 09, 2026 at 01:14:07PM +0800, Chen Ni wrote:
> > > Changes in v2:
> > > - Use dev_err() + return ret instead of dev_err_probe()
> >
> > why?
> >
> > Frank
>
> Hi Frank,
>
> The replacement of dev_err_probe() with dev_err() + return ret is based
> on two key reasons:
>
> 1. Consistency with existing code style in imx_rproc_mmio_detect_mode():
>    The upper-level probe function already uses dev_err_probe() to handle
>    errors from this function, and all other error paths here also use
>    "dev_err() + return ret", so this change aligns with the existing
>    coding style.

You should update existing code to use dev_err_probe()

>
> 2. Technical rationale from community feedback:
>    regmap_attach_dev() only returns -ENOMEM errors, and dev_err_probe() is
>    silent for -ENOMEM errors [1]. Using dev_err() ensures the error is
>    logged clearly, while returning the original ret maintains proper error
>    propagation.
>
> [1] 2f3cfd2f4b7c ("driver core: Make dev_err_probe() silent for -ENOMEM")
>

That means you needn't error message. just "return ret" is enough.

Frank

> Best regards,
> Chen Ni
>

Re: [PATCH v2] remoteproc: imx_rproc: Check return value of regmap_attach_dev() in imx_rproc_mmio_detect_mode()

[Mathieu Poirier]

On Sun, 8 Feb 2026 at 22:18, Chen Ni <nichen@iscas.ac.cn> wrote:
>
> Add error checking for regmap_attach_dev() call in
> imx_rproc_mmio_detect_mode() function to ensure proper error
> propagation.
>
> Return the value of regmap_attach_dev() if it fails to prevent
> proceeding with an incomplete regmap setup.
>
> Suggested-by: Peng Fan <peng.fan@nxp.com>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> Changes in v2:
> - Use dev_err() + return ret instead of dev_err_probe()
> ---
>  drivers/remoteproc/imx_rproc.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index f5f916d67905..75baf905988b 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -1007,7 +1007,11 @@ static int imx_rproc_mmio_detect_mode(struct rproc *rproc)
>         }
>
>         priv->regmap = regmap;
> -       regmap_attach_dev(dev, regmap, &config);
> +       ret = regmap_attach_dev(dev, regmap, &config);
> +       if (ret) {
> +               dev_err(dev, "regmap attach failed\n");
> +               return ret;
> +       }
>

I will add this to my tree when the next cycle starts.

Thanks,
Mathieu

>         if (priv->gpr) {
>                 ret = regmap_read(priv->gpr, dcfg->gpr_reg, &val);
> --
> 2.25.1
>