public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH v2] firmware: raspberrypi: Change dependency to ARCH_BCM2835 and COMPILE_TEST
@ 2026-04-27  9:10 Chen-Yu Tsai
  2026-05-05 17:49 ` Florian Fainelli
  0 siblings, 1 reply; 2+ messages in thread
From: Chen-Yu Tsai @ 2026-04-27  9:10 UTC (permalink / raw)
  To: Florian Fainelli, Broadcom internal kernel review list
  Cc: Chen-Yu Tsai, linux-rpi-kernel, linux-arm-kernel, linux-kernel

The Raspberry Pi firmware driver has no compile dependencies on the
BCM2835 mailbox driver. It's just a indirect runtime dependency: the
driver only works on a Raspberry Pi.

Change the dependency from BCM2835_MBOX to ARCH_BCM2835. Also allow
compile tests. This allows drivers that have build time dependencies
on this firmware driver to be compile tested as well. More dependencies
are added to account for build time dependencies:

  - depends on MAILBOX for mailbox API (not stubbed) usage
  - depends on ARM || ARM64 for dsb() usage

Also make it built by default if ARCH_BCM2835, since many functions will
not work without this firmware driver.

Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
Changes since v1:
- Added depends on MAILBOX for API usage (pointed out by Sashiko)
- Added depends on ARM || ARM64 for dsb() usage
  (build failure report from kernel test robot)
- Added default ARCH_BCM2835 as Florian suggested
---
 drivers/firmware/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
index bbd2155d8483..bcfda01c2ab8 100644
--- a/drivers/firmware/Kconfig
+++ b/drivers/firmware/Kconfig
@@ -114,7 +114,10 @@ config ISCSI_IBFT
 
 config RASPBERRYPI_FIRMWARE
 	tristate "Raspberry Pi Firmware Driver"
-	depends on BCM2835_MBOX
+	depends on ARCH_BCM2835 || COMPILE_TEST
+	depends on ARM || ARM64
+	depends on MAILBOX
+	default ARCH_BCM2835
 	help
 	  This option enables support for communicating with the firmware on the
 	  Raspberry Pi.
-- 
2.54.0.rc2.544.gc7ae2d5bb8-goog



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] firmware: raspberrypi: Change dependency to ARCH_BCM2835 and COMPILE_TEST
  2026-04-27  9:10 [PATCH v2] firmware: raspberrypi: Change dependency to ARCH_BCM2835 and COMPILE_TEST Chen-Yu Tsai
@ 2026-05-05 17:49 ` Florian Fainelli
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2026-05-05 17:49 UTC (permalink / raw)
  To: bcm-kernel-feedback-list, Chen-Yu Tsai, Florian Fainelli
  Cc: Florian Fainelli, linux-rpi-kernel, linux-arm-kernel,
	linux-kernel

From: Florian Fainelli <f.fainelli@gmail.com>

On Mon, 27 Apr 2026 17:10:57 +0800, Chen-Yu Tsai <wenst@chromium.org> wrote:
> The Raspberry Pi firmware driver has no compile dependencies on the
> BCM2835 mailbox driver. It's just a indirect runtime dependency: the
> driver only works on a Raspberry Pi.
> 
> Change the dependency from BCM2835_MBOX to ARCH_BCM2835. Also allow
> compile tests. This allows drivers that have build time dependencies
> on this firmware driver to be compile tested as well. More dependencies
> are added to account for build time dependencies:
> 
>   - depends on MAILBOX for mailbox API (not stubbed) usage
>   - depends on ARM || ARM64 for dsb() usage
> 
> Also make it built by default if ARCH_BCM2835, since many functions will
> not work without this firmware driver.
> 
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/drivers/next, thanks!
--
Florian


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-05-05 17:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-27  9:10 [PATCH v2] firmware: raspberrypi: Change dependency to ARCH_BCM2835 and COMPILE_TEST Chen-Yu Tsai
2026-05-05 17:49 ` Florian Fainelli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox