From: Jonathan Cameron <jic23@kernel.org>
To: Caio Morais <caiomorais@usp.br>
Cc: andy@kernel.org, dlechner@baylibre.com, michal.simek@amd.com,
nuno.sa@analog.com, linux-arm-kernel@lists.infradead.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/3] iio: buffer: industrialio-triggered-buffer: fix includes with IWYU
Date: Mon, 27 Apr 2026 11:08:49 +0100 [thread overview]
Message-ID: <20260427110849.44bc83b3@jic23-huawei> (raw)
In-Reply-To: <20260426211834.3318306-3-caiomorais@usp.br>
On Sun, 26 Apr 2026 18:18:01 -0300
Caio Morais <caiomorais@usp.br> wrote:
> From: Caio Morais <caiomorais@usp.br>
>
> Signed-off-by: Caio Morais <caiomorais@usp.br>
> ---
> drivers/iio/buffer/industrialio-triggered-buffer.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/buffer/industrialio-triggered-buffer.c b/drivers/iio/buffer/industrialio-triggered-buffer.c
> index 9bf75dee7..a91d439d7 100644
> --- a/drivers/iio/buffer/industrialio-triggered-buffer.c
> +++ b/drivers/iio/buffer/industrialio-triggered-buffer.c
> @@ -4,9 +4,11 @@
> * Author: Lars-Peter Clausen <lars@metafoo.de>
> */
>
> -#include <linux/kernel.h>
> -#include <linux/export.h>
Why? There are numerous uses of EXPORT_SYMBOL() in this file.
> +#include <linux/errno.h>
> +#include <linux/linkage.h>
Wow. That one is obscure. What needed that?
For these, IWYU patches, I prefer to add that info after the ---
so it's easy to review them without opening the code up to take a closer look.
> #include <linux/module.h>
> +#include <linux/stddef.h>
> +
> #include <linux/iio/iio.h>
> #include <linux/iio/buffer.h>
> #include <linux/iio/buffer_impl.h>
next prev parent reply other threads:[~2026-04-27 10:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-26 21:17 [PATCH v2 0/3]: fix unnecessary includes and add missing ones across multiple drivers Caio Morais
2026-04-26 21:18 ` [PATCH 1/3] iio: adc: xilinx-xadc: remove unnecessary includes and add missing ones Caio Morais
2026-04-27 6:42 ` Joshua Crofts
2026-04-27 9:50 ` Andy Shevchenko
2026-04-27 10:00 ` Joshua Crofts
2026-04-27 10:05 ` Jonathan Cameron
2026-04-26 21:18 ` [PATCH 2/3] iio: buffer: industrialio-triggered-buffer: fix includes with IWYU Caio Morais
2026-04-27 9:59 ` Andy Shevchenko
2026-04-27 10:08 ` Jonathan Cameron [this message]
2026-04-26 21:18 ` [PATCH 3/3] iio: common: st_sensors: " Caio Morais
2026-04-27 10:10 ` Jonathan Cameron
2026-04-27 10:03 ` [PATCH v2 0/3]: fix unnecessary includes and add missing ones across multiple drivers Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260427110849.44bc83b3@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=caiomorais@usp.br \
--cc=dlechner@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox