From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: Caio Morais <caiomorais@usp.br>,
andy@kernel.org, dlechner@baylibre.com, jic23@kernel.org,
michal.simek@amd.com, nuno.sa@analog.com,
linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/3] iio: adc: xilinx-xadc: remove unnecessary includes and add missing ones
Date: Mon, 27 Apr 2026 12:50:48 +0300 [thread overview]
Message-ID: <ae8xeI8VVUWn6OqQ@ashevche-desk.local> (raw)
In-Reply-To: <CALoEA-zz-2cG7SJr1iKNQ0H81TVMXLQh3omkxJc9YRW673Kqqw@mail.gmail.com>
On Mon, Apr 27, 2026 at 08:42:55AM +0200, Joshua Crofts wrote:
> On Sun, 26 Apr 2026 at 23:20, Caio Morais <caiomorais@usp.br> wrote:
> >
> > Signed-off-by: Caio Morais <caiomorais@usp.br>
> > ---
>
> You're missing the commit message body. While it's understandable
> what changes you've done in this patch, it's good to expand the idea
> further (what you did, how you did it, why you did it). This goes for all
> of the patches in your series.
Dunno if it's your first review (congrats in that case!), but I fully agree with.
We do not accept patches with the empty commit message bodies.
(*Yes, it used to be okay twenty ears ago, but now.)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-27 9:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-26 21:17 [PATCH v2 0/3]: fix unnecessary includes and add missing ones across multiple drivers Caio Morais
2026-04-26 21:18 ` [PATCH 1/3] iio: adc: xilinx-xadc: remove unnecessary includes and add missing ones Caio Morais
2026-04-27 6:42 ` Joshua Crofts
2026-04-27 9:50 ` Andy Shevchenko [this message]
2026-04-27 10:00 ` Joshua Crofts
2026-04-27 10:05 ` Jonathan Cameron
2026-04-26 21:18 ` [PATCH 2/3] iio: buffer: industrialio-triggered-buffer: fix includes with IWYU Caio Morais
2026-04-27 9:59 ` Andy Shevchenko
2026-04-27 10:08 ` Jonathan Cameron
2026-04-26 21:18 ` [PATCH 3/3] iio: common: st_sensors: " Caio Morais
2026-04-27 10:10 ` Jonathan Cameron
2026-04-27 10:03 ` [PATCH v2 0/3]: fix unnecessary includes and add missing ones across multiple drivers Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae8xeI8VVUWn6OqQ@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=caiomorais@usp.br \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox