From: Hans Zhang <18255117159@163.com>
To: broonie@kernel.org, sunny.luo@amlogic.com,
xianwei.zhao@amlogic.com, neil.armstrong@linaro.org,
khilman@baylibre.com, han.xu@nxp.com, haibo.chen@nxp.com,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
lhjeff911@gmail.com, hayashi.kunihiko@socionext.com,
mhiramat@kernel.org, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
linux-stm32@st-md-mailman.stormreply.com,
Hans Zhang <18255117159@163.com>
Subject: [PATCH 04/10] spi: meson-spicc: Use FIELD_MODIFY()
Date: Thu, 30 Apr 2026 23:54:50 +0800 [thread overview]
Message-ID: <20260430155456.36998-5-18255117159@163.com> (raw)
In-Reply-To: <20260430155456.36998-1-18255117159@163.com>
Use FIELD_MODIFY() to remove open-coded bit manipulation.
No functional change intended.
Signed-off-by: Hans Zhang <18255117159@163.com>
---
drivers/spi/spi-meson-spicc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c
index b80f9f457b66..682dda114412 100644
--- a/drivers/spi/spi-meson-spicc.c
+++ b/drivers/spi/spi-meson-spicc.c
@@ -539,9 +539,8 @@ static void meson_spicc_setup_xfer(struct meson_spicc_device *spicc,
conf = conf_orig = readl_relaxed(spicc->base + SPICC_CONREG);
/* Setup word width */
- conf &= ~SPICC_BITLENGTH_MASK;
- conf |= FIELD_PREP(SPICC_BITLENGTH_MASK,
- (spicc->bytes_per_word << 3) - 1);
+ FIELD_MODIFY(SPICC_BITLENGTH_MASK, &conf,
+ (spicc->bytes_per_word << 3) - 1);
/* Ignore if unchanged */
if (conf != conf_orig)
--
2.34.1
next prev parent reply other threads:[~2026-04-30 15:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 15:54 [PATCH 00/10] spi: Use FIELD_MODIFY() for bitfield operations Hans Zhang
2026-04-30 15:54 ` [PATCH 01/10] spi: amlogic-spifc-a1: Use FIELD_MODIFY() Hans Zhang
2026-04-30 15:54 ` [PATCH 02/10] spi: amlogic-spisg: " Hans Zhang
2026-04-30 15:54 ` [PATCH 03/10] spi: cadence-xspi: " Hans Zhang
2026-05-01 0:52 ` Mark Brown
2026-04-30 15:54 ` Hans Zhang [this message]
2026-04-30 15:54 ` [PATCH 05/10] spi: nxp-xspi: " Hans Zhang
2026-04-30 15:54 ` [PATCH 06/10] spi: sn-f-ospi: " Hans Zhang
2026-04-30 15:54 ` [PATCH 07/10] spi: stm32-ospi: " Hans Zhang
2026-04-30 15:54 ` [PATCH 08/10] spi: stm32-qspi: " Hans Zhang
2026-04-30 15:54 ` [PATCH 09/10] spi: sunplus-sp7021: " Hans Zhang
2026-04-30 15:54 ` [PATCH 10/10] spi: uniphier: " Hans Zhang
2026-05-01 8:30 ` [PATCH 00/10] spi: Use FIELD_MODIFY() for bitfield operations David Laight
2026-05-05 4:23 ` Hans Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260430155456.36998-5-18255117159@163.com \
--to=18255117159@163.com \
--cc=alexandre.torgue@foss.st.com \
--cc=broonie@kernel.org \
--cc=haibo.chen@nxp.com \
--cc=han.xu@nxp.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=imx@lists.linux.dev \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=lhjeff911@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mhiramat@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=sunny.luo@amlogic.com \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox