From: Mark Brown <broonie@kernel.org>
To: Hans Zhang <18255117159@163.com>
Cc: sunny.luo@amlogic.com, xianwei.zhao@amlogic.com,
neil.armstrong@linaro.org, khilman@baylibre.com, han.xu@nxp.com,
haibo.chen@nxp.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, lhjeff911@gmail.com,
hayashi.kunihiko@socionext.com, mhiramat@kernel.org,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 03/10] spi: cadence-xspi: Use FIELD_MODIFY()
Date: Fri, 1 May 2026 09:52:42 +0900 [thread overview]
Message-ID: <afP5Wlzt-dTvnzii@sirena.co.uk> (raw)
In-Reply-To: <20260430155456.36998-4-18255117159@163.com>
[-- Attachment #1: Type: text/plain, Size: 524 bytes --]
On Thu, Apr 30, 2026 at 11:54:49PM +0800, Hans Zhang wrote:
> writel(clk_reg,
> cdns_xspi->auxbase + MRVL_XSPI_CLK_CTRL_AUX_REG);
> clk_reg = FIELD_PREP(MRVL_XSPI_CLK_DIV, i);
> - clk_reg &= ~MRVL_XSPI_CLK_DIV;
> - clk_reg |= FIELD_PREP(MRVL_XSPI_CLK_DIV, i);
> + FIELD_MODIFY(MRVL_XSPI_CLK_DIV, &clk_reg, i);
> clk_reg |= MRVL_XSPI_CLK_ENABLE;
> clk_reg |= MRVL_XSPI_IRQ_ENABLE;
> update_clk = true;
The existing code is a bit weird here, we could just delete the
modification entirely AFAICT.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-05-01 0:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 15:54 [PATCH 00/10] spi: Use FIELD_MODIFY() for bitfield operations Hans Zhang
2026-04-30 15:54 ` [PATCH 01/10] spi: amlogic-spifc-a1: Use FIELD_MODIFY() Hans Zhang
2026-04-30 15:54 ` [PATCH 02/10] spi: amlogic-spisg: " Hans Zhang
2026-04-30 15:54 ` [PATCH 03/10] spi: cadence-xspi: " Hans Zhang
2026-05-01 0:52 ` Mark Brown [this message]
2026-04-30 15:54 ` [PATCH 04/10] spi: meson-spicc: " Hans Zhang
2026-04-30 15:54 ` [PATCH 05/10] spi: nxp-xspi: " Hans Zhang
2026-04-30 15:54 ` [PATCH 06/10] spi: sn-f-ospi: " Hans Zhang
2026-04-30 15:54 ` [PATCH 07/10] spi: stm32-ospi: " Hans Zhang
2026-04-30 15:54 ` [PATCH 08/10] spi: stm32-qspi: " Hans Zhang
2026-04-30 15:54 ` [PATCH 09/10] spi: sunplus-sp7021: " Hans Zhang
2026-04-30 15:54 ` [PATCH 10/10] spi: uniphier: " Hans Zhang
2026-05-01 8:30 ` [PATCH 00/10] spi: Use FIELD_MODIFY() for bitfield operations David Laight
2026-05-05 4:23 ` Hans Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afP5Wlzt-dTvnzii@sirena.co.uk \
--to=broonie@kernel.org \
--cc=18255117159@163.com \
--cc=alexandre.torgue@foss.st.com \
--cc=haibo.chen@nxp.com \
--cc=han.xu@nxp.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=imx@lists.linux.dev \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=lhjeff911@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mhiramat@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=sunny.luo@amlogic.com \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox