* [PATCH] staging: media: imx: remove unnecessary out-of-memory error message
@ 2026-05-03 15:00 Shyam Sunder Reddy Padira
2026-05-04 18:54 ` Frank Li
0 siblings, 1 reply; 2+ messages in thread
From: Shyam Sunder Reddy Padira @ 2026-05-03 15:00 UTC (permalink / raw)
To: slongerbeam, p.zabel, mchehab, gregkh, s.hauer
Cc: Frank.Li, kernel, festevam, imx, linux-media, linux-staging,
linux-arm-kernel, linux-kernel, Shyam Sunder Reddy Padira
Remove dev_err() call after dma_alloc_coherent() failure.
checkpatch.pl reports this as an unnecessary out-of-memory
message because failure is already conveyed by returning
-ENOMEM, and the current message does not provide additional
useful debugging information.
Signed-off-by: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
---
drivers/staging/media/imx/imx-media-utils.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c
index 1b5af8945e6b..85b63993ef28 100644
--- a/drivers/staging/media/imx/imx-media-utils.c
+++ b/drivers/staging/media/imx/imx-media-utils.c
@@ -589,10 +589,8 @@ int imx_media_alloc_dma_buf(struct device *dev,
buf->len = PAGE_ALIGN(size);
buf->virt = dma_alloc_coherent(dev, buf->len, &buf->phys,
GFP_DMA | GFP_KERNEL);
- if (!buf->virt) {
- dev_err(dev, "%s: failed\n", __func__);
+ if (!buf->virt)
return -ENOMEM;
- }
return 0;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: media: imx: remove unnecessary out-of-memory error message
2026-05-03 15:00 [PATCH] staging: media: imx: remove unnecessary out-of-memory error message Shyam Sunder Reddy Padira
@ 2026-05-04 18:54 ` Frank Li
0 siblings, 0 replies; 2+ messages in thread
From: Frank Li @ 2026-05-04 18:54 UTC (permalink / raw)
To: slongerbeam, p.zabel, mchehab, gregkh, s.hauer,
Shyam Sunder Reddy Padira
Cc: Frank Li, kernel, festevam, imx, linux-media, linux-staging,
linux-arm-kernel, linux-kernel
On Sun, 03 May 2026 20:30:26 +0530, Shyam Sunder Reddy Padira wrote:
> Remove dev_err() call after dma_alloc_coherent() failure.
>
> checkpatch.pl reports this as an unnecessary out-of-memory
> message because failure is already conveyed by returning
> -ENOMEM, and the current message does not provide additional
> useful debugging information.
>
> [...]
Applied, thanks! switch stageing and media tags in subject to keep
consistent.
[1/1] staging: media: imx: remove unnecessary out-of-memory error message
Best regards,
--
Frank Li <Frank.Li@nxp.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-04 18:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-03 15:00 [PATCH] staging: media: imx: remove unnecessary out-of-memory error message Shyam Sunder Reddy Padira
2026-05-04 18:54 ` Frank Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox