[PATCH] ARM: kprobes: test: add MODULE_DESCRIPTION

[PATCH] ARM: kprobes: test: add MODULE_DESCRIPTION

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

All loadable modules must have a description, and since commit
6c6c1fc09de3 ("modpost: require a MODULE_DESCRIPTION()"), the kernel build
warns about it missing:

   WARNING: modpost: missing MODULE_DESCRIPTION() in arch/arm/probes/kprobes/test-kprobes.o

Add the missing description tags. Noticing that the existing license tag
is unnecessarily hidden in an #ifdef section, remove the #ifdef and
use conventional placing of the initcall and module_exit tags as well
as the license and description.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/probes/kprobes/test-core.c | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)

diff --git a/arch/arm/probes/kprobes/test-core.c b/arch/arm/probes/kprobes/test-core.c
index 7a2baa135f0f..2de28088dac8 100644
--- a/arch/arm/probes/kprobes/test-core.c
+++ b/arch/arm/probes/kprobes/test-core.c
@@ -1649,24 +1649,16 @@ static int __init run_all_tests(void)
 
 	return ret;
 }
-
+late_initcall(run_all_tests);
 
 /*
  * Module setup
  */
 
-#ifdef MODULE
-
 static void __exit kprobe_test_exit(void)
 {
 }
-
-module_init(run_all_tests)
 module_exit(kprobe_test_exit)
-MODULE_LICENSE("GPL");
 
-#else /* !MODULE */
-
-late_initcall(run_all_tests);
-
-#endif
+MODULE_DESCRIPTION("Test code for ARM kprobes");
+MODULE_LICENSE("GPL");
-- 
2.39.5

Re: [PATCH] ARM: kprobes: test: add MODULE_DESCRIPTION

[Randy Dunlap]

On 5/3/26 11:59 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> All loadable modules must have a description, and since commit
> 6c6c1fc09de3 ("modpost: require a MODULE_DESCRIPTION()"), the kernel build
> warns about it missing:
> 
>    WARNING: modpost: missing MODULE_DESCRIPTION() in arch/arm/probes/kprobes/test-kprobes.o
> 
> Add the missing description tags. Noticing that the existing license tag
> is unnecessarily hidden in an #ifdef section, remove the #ifdef and
> use conventional placing of the initcall and module_exit tags as well
> as the license and description.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  arch/arm/probes/kprobes/test-core.c | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/arm/probes/kprobes/test-core.c b/arch/arm/probes/kprobes/test-core.c
> index 7a2baa135f0f..2de28088dac8 100644
> --- a/arch/arm/probes/kprobes/test-core.c
> +++ b/arch/arm/probes/kprobes/test-core.c
> @@ -1649,24 +1649,16 @@ static int __init run_all_tests(void)
>  
>  	return ret;
>  }
> -
> +late_initcall(run_all_tests);
>  
>  /*
>   * Module setup
>   */
>  
> -#ifdef MODULE
> -
>  static void __exit kprobe_test_exit(void)
>  {
>  }
> -
> -module_init(run_all_tests)
>  module_exit(kprobe_test_exit)
> -MODULE_LICENSE("GPL");
>  
> -#else /* !MODULE */
> -
> -late_initcall(run_all_tests);
> -
> -#endif
> +MODULE_DESCRIPTION("Test code for ARM kprobes");
> +MODULE_LICENSE("GPL");

-- 
~Randy