* [PATCH v3] spi: s3c64xx: fix all kernel-doc warnings
@ 2026-05-06 17:51 Randy Dunlap
2026-05-07 1:18 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2026-05-06 17:51 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Krzysztof Kozlowski, Tudor Ambarus, Mark Brown,
Andi Shyti, linux-spi, linux-samsung-soc, linux-arm-kernel
Add kernel-doc for one struct member and use the correct function name
to eliminate kernel-doc warnings:
Warning: include/linux/platform_data/spi-s3c64xx.h:40 struct member
'polling' not described in 's3c64xx_spi_info'
Warning: include/linux/platform_data/spi-s3c64xx.h:51 expecting prototype
for s3c64xx_spi_set_platdata(). Prototype was for
s3c64xx_spi0_set_platdata() instead
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
v2: add tag; rebase & resend
v3: add Tudor's Rev-by: tag; rebase; add Mark to recipients
Cc: Mark Brown <broonie@kernel.org>
Cc: Andi Shyti <andi.shyti@kernel.org>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: linux-spi@vger.kernel.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
include/linux/platform_data/spi-s3c64xx.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-next-20260506.orig/include/linux/platform_data/spi-s3c64xx.h
+++ linux-next-20260506/include/linux/platform_data/spi-s3c64xx.h
@@ -30,6 +30,7 @@ struct s3c64xx_spi_csinfo {
* @src_clk_nr: Clock source index for the CLK_CFG[SPI_CLKSEL] field.
* @num_cs: Number of CS this controller emulates.
* @no_cs: Used when CS line is not connected.
+ * @polling: Using polling mode when %true (no 'dmas' property in devicetree)
* @cfg_gpio: Configure pins for this SPI controller.
*/
struct s3c64xx_spi_info {
@@ -41,7 +42,7 @@ struct s3c64xx_spi_info {
};
/**
- * s3c64xx_spi_set_platdata - SPI Controller configure callback by the board
+ * s3c64xx_spi0_set_platdata - SPI Controller configure callback by the board
* initialization code.
* @src_clk_nr: Clock the SPI controller is to use to generate SPI clocks.
* @num_cs: Number of elements in the 'cs' array.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v3] spi: s3c64xx: fix all kernel-doc warnings
2026-05-06 17:51 [PATCH v3] spi: s3c64xx: fix all kernel-doc warnings Randy Dunlap
@ 2026-05-07 1:18 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2026-05-07 1:18 UTC (permalink / raw)
To: linux-kernel, Randy Dunlap
Cc: Krzysztof Kozlowski, Tudor Ambarus, Andi Shyti, linux-spi,
linux-samsung-soc, linux-arm-kernel
On Wed, 06 May 2026 10:51:44 -0700, Randy Dunlap wrote:
> spi: s3c64xx: fix all kernel-doc warnings
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-7.2
Thanks!
[1/1] spi: s3c64xx: fix all kernel-doc warnings
https://git.kernel.org/broonie/spi/c/88f731e79629
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-07 1:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-06 17:51 [PATCH v3] spi: s3c64xx: fix all kernel-doc warnings Randy Dunlap
2026-05-07 1:18 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox