Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@kernel.org>
To: arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Sudeep Holla <sudeep.holla@kernel.org>,
	 Cristian Marussi <cristian.marussi@arm.com>
Subject: [PATCH v2 5/9] firmware: arm_scmi: Fall back to ACPI HID when "compatible" is absent
Date: Mon, 25 May 2026 21:42:43 +0100	[thread overview]
Message-ID: <20260525-acpi_scmi_pcc-v2-5-4f38938d08d8@arm.com> (raw)
In-Reply-To: <20260525-acpi_scmi_pcc-v2-0-4f38938d08d8@arm.com>

scmi_debugfs_common_setup() uses the "compatible" property to
populate the debugfs transport type string. ACPI-described SCMI
devices do not provide that DT property, so the string remains
NULL and debugfs setup falls through the allocation failure path.

Check the property lookup result and use the ACPI HID as the
fallback transport type for ACPI-described systems.

Signed-off-by: Sudeep Holla <sudeep.holla@kernel.org>
---
 drivers/firmware/arm_scmi/driver.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
index 75dda6d5e8b1..04a0d8202504 100644
--- a/drivers/firmware/arm_scmi/driver.c
+++ b/drivers/firmware/arm_scmi/driver.c
@@ -3028,8 +3028,9 @@ static struct scmi_debug_info *scmi_debugfs_common_setup(struct scmi_info *info)
 		return NULL;
 	}
 
-	fwnode_property_read_string(dev_fwnode(info->dev), "compatible",
-				    &c_ptr);
+	if (fwnode_property_read_string(dev_fwnode(info->dev), "compatible",
+					&c_ptr))
+		c_ptr = acpi_device_hid(ACPI_COMPANION(info->dev)) ?: "unknown";
 	dbg->type = kstrdup(c_ptr, GFP_KERNEL);
 	if (!dbg->type) {
 		kfree(dbg->name);

-- 
2.43.0



  parent reply	other threads:[~2026-05-25 20:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-25 20:42 [PATCH v2 0/9] firmware: arm_scmi: Refactoring and enablement of ACPI PCC transport Sudeep Holla
2026-05-25 20:42 ` [PATCH v2 1/9] firmware: arm_scmi: Fix OF node reference handling Sudeep Holla
2026-05-25 20:42 ` [PATCH v2 2/9] firmware: arm_scmi: Set fwnode for the generated SCMI platform device Sudeep Holla
2026-05-25 20:42 ` [PATCH v2 3/9] firmware: arm_scmi: Extend transport driver macro to support ACPI Sudeep Holla
2026-05-25 20:42 ` [PATCH v2 4/9] firmware: arm_scmi: Convert OF-only paths to generic fwnode in SCMI core Sudeep Holla
2026-05-28 16:32   ` Adam Young
2026-05-25 20:42 ` Sudeep Holla [this message]
2026-05-25 20:42 ` [PATCH v2 6/9] firmware: arm_scmi: Pass protocol ID to chan_available() transport callback Sudeep Holla
2026-05-25 20:42 ` [PATCH v2 7/9] firmware: arm_scmi: Refactor protocol device creation logic Sudeep Holla
2026-05-25 20:42 ` [PATCH v2 8/9] firmware: arm_scmi: transport: Add ACPI PCC transport Sudeep Holla
2026-05-28 17:29   ` Adam Young
2026-05-25 20:42 ` [PATCH v2 9/9] firmware: arm_scmi: Initialise all protocol devices and transport channels Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260525-acpi_scmi_pcc-v2-5-4f38938d08d8@arm.com \
    --to=sudeep.holla@kernel.org \
    --cc=arm-scmi@vger.kernel.org \
    --cc=cristian.marussi@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox