* [PATCH] soc: mediatek: pwrap: Remove obsolete NEED CONFIRM comments
@ 2026-05-22 13:45 Akari Tsuyukusa
2026-05-25 8:46 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 3+ messages in thread
From: Akari Tsuyukusa @ 2026-05-22 13:45 UTC (permalink / raw)
To: matthias.bgg, angelogioacchino.delregno
Cc: james.lo, linux-kernel, linux-arm-kernel, linux-mediatek,
Akari Tsuyukusa
Remove the obsolete "/* NEED CONFIRM */" comments from the MT8196
configuration. These values were previously confirmed during review,
but the placeholder comments were accidentally left behind.
Link: https://lore.kernel.org/all/2a117e5fe9fe0ece39e9165a463082ef42be973f.camel@mediatek.com/
Signed-off-by: Akari Tsuyukusa <akkun11.open@gmail.com>
---
drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index 0bcd85826375..87bcbfa2d5f1 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -2396,8 +2396,8 @@ static const struct pmic_wrapper_type pwrap_mt8183 = {
static const struct pmic_wrapper_type pwrap_mt8195 = {
.regs = mt8195_regs,
.type = PWRAP_MT8195,
- .arb_en_all = 0x777f, /* NEED CONFIRM */
- .int_en_all = 0x180000, /* NEED CONFIRM */
+ .arb_en_all = 0x777f,
+ .int_en_all = 0x180000,
.int1_en_all = 0,
.spi_w = PWRAP_MAN_CMD_SPI_WRITE,
.wdt_src = PWRAP_WDT_SRC_MASK_ALL,
--
2.54.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: mediatek: pwrap: Remove obsolete NEED CONFIRM comments
2026-05-22 13:45 [PATCH] soc: mediatek: pwrap: Remove obsolete NEED CONFIRM comments Akari Tsuyukusa
@ 2026-05-25 8:46 ` AngeloGioacchino Del Regno
2026-05-25 9:24 ` [PATCH v2] " Akari Tsuyukusa
0 siblings, 1 reply; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2026-05-25 8:46 UTC (permalink / raw)
To: Akari Tsuyukusa, matthias.bgg
Cc: james.lo, linux-kernel, linux-arm-kernel, linux-mediatek
On 5/22/26 15:45, Akari Tsuyukusa wrote:
> Remove the obsolete "/* NEED CONFIRM */" comments from the MT8196
s/mt8196/mt8195/g
> configuration. These values were previously confirmed during review,
> but the placeholder comments were accidentally left behind.
>
> Link: https://lore.kernel.org/all/2a117e5fe9fe0ece39e9165a463082ef42be973f.camel@mediatek.com/
> Signed-off-by: Akari Tsuyukusa <akkun11.open@gmail.com>
after which...
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 0bcd85826375..87bcbfa2d5f1 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -2396,8 +2396,8 @@ static const struct pmic_wrapper_type pwrap_mt8183 = {
> static const struct pmic_wrapper_type pwrap_mt8195 = {
> .regs = mt8195_regs,
> .type = PWRAP_MT8195,
> - .arb_en_all = 0x777f, /* NEED CONFIRM */
> - .int_en_all = 0x180000, /* NEED CONFIRM */
> + .arb_en_all = 0x777f,
> + .int_en_all = 0x180000,
> .int1_en_all = 0,
> .spi_w = PWRAP_MAN_CMD_SPI_WRITE,
> .wdt_src = PWRAP_WDT_SRC_MASK_ALL,
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] soc: mediatek: pwrap: Remove obsolete NEED CONFIRM comments
2026-05-25 8:46 ` AngeloGioacchino Del Regno
@ 2026-05-25 9:24 ` Akari Tsuyukusa
0 siblings, 0 replies; 3+ messages in thread
From: Akari Tsuyukusa @ 2026-05-25 9:24 UTC (permalink / raw)
To: matthias.bgg, angelogioacchino.delregno
Cc: james.lo, linux-kernel, linux-arm-kernel, linux-mediatek,
Akari Tsuyukusa
Remove the obsolete "/* NEED CONFIRM */" comments from the MT8195
configuration. These values were previously confirmed during review,
but the placeholder comments were accidentally left behind.
Link: https://lore.kernel.org/all/2a117e5fe9fe0ece39e9165a463082ef42be973f.camel@mediatek.com/
Signed-off-by: Akari Tsuyukusa <akkun11.open@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
changes in v2
- Fix commit message (MT8196 -> MT8195)
- Add Reviewed-by tag
drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index 0bcd85826375..87bcbfa2d5f1 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -2396,8 +2396,8 @@ static const struct pmic_wrapper_type pwrap_mt8183 = {
static const struct pmic_wrapper_type pwrap_mt8195 = {
.regs = mt8195_regs,
.type = PWRAP_MT8195,
- .arb_en_all = 0x777f, /* NEED CONFIRM */
- .int_en_all = 0x180000, /* NEED CONFIRM */
+ .arb_en_all = 0x777f,
+ .int_en_all = 0x180000,
.int1_en_all = 0,
.spi_w = PWRAP_MAN_CMD_SPI_WRITE,
.wdt_src = PWRAP_WDT_SRC_MASK_ALL,
--
2.54.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-25 9:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-22 13:45 [PATCH] soc: mediatek: pwrap: Remove obsolete NEED CONFIRM comments Akari Tsuyukusa
2026-05-25 8:46 ` AngeloGioacchino Del Regno
2026-05-25 9:24 ` [PATCH v2] " Akari Tsuyukusa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox