* [PATCH v1] clk: at91: keep securam node alive while mapping it
@ 2026-05-29 4:20 Yuho Choi
2026-05-29 21:02 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Yuho Choi @ 2026-05-29 4:20 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Nicolas Ferre, Alexandre Belloni,
Claudiu Beznea
Cc: Brian Masney, Kees Cook, Rafael J. Wysocki (Intel),
Thierry Reding, linux-clk, linux-arm-kernel, linux-kernel,
Yuho Choi
pmc_register_ops() gets an owned reference to the
"atmel,sama5d2-securam" node with of_find_compatible_node(). The
success path dropped that reference before passing the node to
of_iomap(), leaving of_iomap() to consume a node pointer after the caller
had released its reference.
Move of_node_put() after of_iomap() so the node remains referenced for
the mapping operation. The unavailable-node error path already releases
the reference.
Fixes: 4d21be864092 ("clk: at91: pmc: execute suspend/resume only for backup mode")
Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
---
drivers/clk/at91/pmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c
index b618a5e00b00..03a6c31d6aa8 100644
--- a/drivers/clk/at91/pmc.c
+++ b/drivers/clk/at91/pmc.c
@@ -180,9 +180,9 @@ static int __init pmc_register_ops(void)
of_node_put(np);
return -ENODEV;
}
- of_node_put(np);
at91_pmc_backup_suspend = of_iomap(np, 0);
+ of_node_put(np);
if (!at91_pmc_backup_suspend) {
pr_warn("%s(): unable to map securam\n", __func__);
return -ENOMEM;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1] clk: at91: keep securam node alive while mapping it
2026-05-29 4:20 [PATCH v1] clk: at91: keep securam node alive while mapping it Yuho Choi
@ 2026-05-29 21:02 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2026-05-29 21:02 UTC (permalink / raw)
To: Yuho Choi
Cc: Michael Turquette, Stephen Boyd, Nicolas Ferre, Claudiu Beznea,
Brian Masney, Kees Cook, Rafael J. Wysocki (Intel),
Thierry Reding, linux-clk, linux-arm-kernel, linux-kernel
On 29/05/2026 00:20:51-0400, Yuho Choi wrote:
> pmc_register_ops() gets an owned reference to the
> "atmel,sama5d2-securam" node with of_find_compatible_node(). The
> success path dropped that reference before passing the node to
> of_iomap(), leaving of_iomap() to consume a node pointer after the caller
> had released its reference.
>
> Move of_node_put() after of_iomap() so the node remains referenced for
> the mapping operation. The unavailable-node error path already releases
> the reference.
>
> Fixes: 4d21be864092 ("clk: at91: pmc: execute suspend/resume only for backup mode")
> Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> drivers/clk/at91/pmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c
> index b618a5e00b00..03a6c31d6aa8 100644
> --- a/drivers/clk/at91/pmc.c
> +++ b/drivers/clk/at91/pmc.c
> @@ -180,9 +180,9 @@ static int __init pmc_register_ops(void)
> of_node_put(np);
> return -ENODEV;
> }
> - of_node_put(np);
>
> at91_pmc_backup_suspend = of_iomap(np, 0);
> + of_node_put(np);
> if (!at91_pmc_backup_suspend) {
> pr_warn("%s(): unable to map securam\n", __func__);
> return -ENOMEM;
> --
> 2.43.0
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-29 21:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-29 4:20 [PATCH v1] clk: at91: keep securam node alive while mapping it Yuho Choi
2026-05-29 21:02 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox