Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] ARM: mvebu: Fix CPU node reference leak in get_cpu_clk()
@ 2026-06-15 18:59 Yuho Choi
  0 siblings, 0 replies; only message in thread
From: Yuho Choi @ 2026-06-15 18:59 UTC (permalink / raw)
  To: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Russell King
  Cc: linux-arm-kernel, linux-kernel, Yuho Choi

of_get_cpu_node() returns a reference to the CPU device node.
get_cpu_clk() only needs that node for of_clk_get(), but never drops the
reference after the clock lookup.

Drop the CPU node reference before returning the clock, covering both
the successful lookup and the IS_ERR() path.

Fixes: f6cec7cd0777 ("ARM: mvebu: remove device tree parsing for cpu nodes")
Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
---
 arch/arm/mach-mvebu/platsmp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-mvebu/platsmp.c b/arch/arm/mach-mvebu/platsmp.c
index 18384ea6862c..0f14d7376770 100644
--- a/arch/arm/mach-mvebu/platsmp.c
+++ b/arch/arm/mach-mvebu/platsmp.c
@@ -42,6 +42,7 @@ static struct clk *get_cpu_clk(int cpu)
 	if (WARN(!np, "missing cpu node\n"))
 		return NULL;
 	cpu_clk = of_clk_get(np, 0);
+	of_node_put(np);
 	if (WARN_ON(IS_ERR(cpu_clk)))
 		return NULL;
 	return cpu_clk;
-- 
2.43.0



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-06-15 18:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-15 18:59 [PATCH v1] ARM: mvebu: Fix CPU node reference leak in get_cpu_clk() Yuho Choi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox