Re: [PATCH net-next 1/2] dt-bindings: net: dsa: mediatek,mt7530: add econet,en7528-switch

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1856 bytes --]

On Fri, Jul 10, 2026 at 02:54:23PM +0400, Ahmed Naseef wrote:
> The EcoNet EN7528 MIPS SoC integrates an MT7530 Gigabit switch,
> memory-mapped in the SoC register space like the built-in switches of
> the MediaTek MT7988 and Airoha EN7581/AN7583 SoCs. Its four user ports
> are connected to integrated Gigabit PHYs and its CPU port is connected
> internally to the SoC Ethernet MAC.

Please note what actually makes this different from the other devices
such that it cannot use a fallback. It's not clear from this description
if the described features are shared with other devices or unique.
pw-bot: changes-requested

Thanks,
Conor.

> 
> Add the econet,en7528-switch compatible, with the same constraints as
> the other built-in switches.
> 
> Signed-off-by: Ahmed Naseef <naseefkm@gmail.com>
> ---
>  .../devicetree/bindings/net/dsa/mediatek,mt7530.yaml         | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> index 815a90808901..90b3582b7619 100644
> --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> @@ -100,6 +100,10 @@ properties:
>            Built-in switch of the Airoha AN7583 SoC
>          const: airoha,an7583-switch
>  
> +      - description:
> +          Built-in switch of the EcoNet EN7528 SoC
> +        const: econet,en7528-switch
> +
>    reg:
>      maxItems: 1
>  
> @@ -318,6 +322,7 @@ allOf:
>              - mediatek,mt7988-switch
>              - airoha,en7581-switch
>              - airoha,an7583-switch
> +            - econet,en7528-switch
>      then:
>        $ref: "#/$defs/builtin-dsa-port"
>        properties:
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]