* [PATCH] usb: chipidea: imx: fix missing ret assignment for dev_err_probe
@ 2026-07-10 7:08 Xu Yang
2026-07-10 15:37 ` Frank Li
0 siblings, 1 reply; 2+ messages in thread
From: Xu Yang @ 2026-07-10 7:08 UTC (permalink / raw)
To: peter.chen, gregkh, Frank.Li
Cc: s.hauer, kernel, festevam, linux-usb, imx, linux-arm-kernel,
linux-kernel
From: Xu Yang <xu.yang_2@nxp.com>
Assign the return value of dev_err_probe() to ret so that the correct
error code is propagated when goto err_clk is taken.
Fixes: 2e9762f45efb ("usb: chipidea: ci_hdrc_imx: use "wakeup" suffix for wakeup interrupt name")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/r/202607031656.FR3Xrved-lkp@intel.com/
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
drivers/usb/chipidea/ci_hdrc_imx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
index 56d2ba824a0b..282314eea7fc 100644
--- a/drivers/usb/chipidea/ci_hdrc_imx.c
+++ b/drivers/usb/chipidea/ci_hdrc_imx.c
@@ -528,7 +528,7 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
if (data->wakeup_irq > 0) {
irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s:wakeup", pdata.name);
if (!irq_name) {
- dev_err_probe(dev, -ENOMEM, "failed to create irq_name\n");
+ ret = dev_err_probe(dev, -ENOMEM, "failed to create irq_name\n");
goto err_clk;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] usb: chipidea: imx: fix missing ret assignment for dev_err_probe
2026-07-10 7:08 [PATCH] usb: chipidea: imx: fix missing ret assignment for dev_err_probe Xu Yang
@ 2026-07-10 15:37 ` Frank Li
0 siblings, 0 replies; 2+ messages in thread
From: Frank Li @ 2026-07-10 15:37 UTC (permalink / raw)
To: Xu Yang
Cc: peter.chen, gregkh, Frank.Li, s.hauer, kernel, festevam,
linux-usb, imx, linux-arm-kernel, linux-kernel
On Fri, Jul 10, 2026 at 03:08:34PM +0800, Xu Yang wrote:
> From: Xu Yang <xu.yang_2@nxp.com>
>
> Assign the return value of dev_err_probe() to ret so that the correct
> error code is propagated when goto err_clk is taken.
>
> Fixes: 2e9762f45efb ("usb: chipidea: ci_hdrc_imx: use "wakeup" suffix for wakeup interrupt name")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Closes: https://lore.kernel.org/r/202607031656.FR3Xrved-lkp@intel.com/
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
> drivers/usb/chipidea/ci_hdrc_imx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> index 56d2ba824a0b..282314eea7fc 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -528,7 +528,7 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
> if (data->wakeup_irq > 0) {
> irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s:wakeup", pdata.name);
> if (!irq_name) {
> - dev_err_probe(dev, -ENOMEM, "failed to create irq_name\n");
> + ret = dev_err_probe(dev, -ENOMEM, "failed to create irq_name\n");
Generally, -ENOMEM needn't print message,
just ret = -ENOMEM;
Frank
> goto err_clk;
> }
>
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-10 15:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-10 7:08 [PATCH] usb: chipidea: imx: fix missing ret assignment for dev_err_probe Xu Yang
2026-07-10 15:37 ` Frank Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox