From: Pan Chuang <panchuang@vivo.com>
To: Shuai Xue <xueshuai@linux.alibaba.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Frank Li <Frank.li@nxp.com>,
Xu Yang <xu.yang_2@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Ji Sheng Teoh <jisheng.teoh@starfivetech.com>,
Khuong Dinh <khuong@os.amperecomputing.com>,
linux-arm-kernel@lists.infradead.org (moderated list:ARM PMU
PROFILING AND DEBUGGING),
linux-perf-users@vger.kernel.org (open list:ARM PMU PROFILING
AND DEBUGGING), linux-kernel@vger.kernel.org (open list),
imx@lists.linux.dev (open list:ARM/FREESCALE IMX / MXC ARM
ARCHITECTURE),
linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM MAILING
LIST)
Cc: Pan Chuang <panchuang@vivo.com>
Subject: [PATCH 1/3] perf: Remove redundant dev_err()/dev_err_probe()
Date: Fri, 17 Jul 2026 18:31:17 +0800 [thread overview]
Message-ID: <20260717103123.34887-2-panchuang@vivo.com> (raw)
In-Reply-To: <20260717103123.34887-1-panchuang@vivo.com>
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/perf/alibaba_uncore_drw_pmu.c | 5 +----
drivers/perf/fsl_imx8_ddr_perf.c | 4 +---
drivers/perf/fsl_imx9_ddr_perf.c | 4 +---
drivers/perf/fujitsu_uncore_pmu.c | 2 +-
drivers/perf/qcom_l2_pmu.c | 5 +----
drivers/perf/qcom_l3_pmu.c | 5 +----
drivers/perf/starfive_starlink_pmu.c | 2 +-
drivers/perf/xgene_pmu.c | 4 +---
8 files changed, 8 insertions(+), 23 deletions(-)
diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c
index 74786a5dd6a2..fc934bccf4a6 100644
--- a/drivers/perf/alibaba_uncore_drw_pmu.c
+++ b/drivers/perf/alibaba_uncore_drw_pmu.c
@@ -449,11 +449,8 @@ static struct ali_drw_pmu_irq *__ali_drw_pmu_init_irq(struct platform_device
*/
ret = devm_request_irq(&pdev->dev, irq_num, ali_drw_pmu_isr,
IRQF_SHARED, dev_name(&pdev->dev), irq);
- if (ret < 0) {
- dev_err(&pdev->dev,
- "Fail to request IRQ:%d ret:%d\n", irq_num, ret);
+ if (ret < 0)
goto out_free;
- }
ret = irq_set_affinity_hint(irq_num, cpumask_of(irq->cpu));
if (ret)
diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c
index 3760ebe02674..dd8046265584 100644
--- a/drivers/perf/fsl_imx8_ddr_perf.c
+++ b/drivers/perf/fsl_imx8_ddr_perf.c
@@ -858,10 +858,8 @@ static int ddr_perf_probe(struct platform_device *pdev)
IRQF_NOBALANCING | IRQF_NO_THREAD,
DDR_CPUHP_CB_NAME,
pmu);
- if (ret < 0) {
- dev_err(&pdev->dev, "Request irq failed: %d", ret);
+ if (ret < 0)
goto ddr_perf_err;
- }
pmu->irq = irq;
ret = irq_set_affinity(pmu->irq, cpumask_of(pmu->cpu));
diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c
index 6fee5eb5087a..d59bc5ea3155 100644
--- a/drivers/perf/fsl_imx9_ddr_perf.c
+++ b/drivers/perf/fsl_imx9_ddr_perf.c
@@ -830,10 +830,8 @@ static int ddr_perf_probe(struct platform_device *pdev)
ret = devm_request_irq(&pdev->dev, irq, ddr_perf_irq_handler,
IRQF_NOBALANCING | IRQF_NO_THREAD,
DDR_CPUHP_CB_NAME, pmu);
- if (ret < 0) {
- dev_err(&pdev->dev, "Request irq failed: %d", ret);
+ if (ret < 0)
goto ddr_perf_err;
- }
pmu->irq = irq;
ret = irq_set_affinity(pmu->irq, cpumask_of(pmu->cpu));
diff --git a/drivers/perf/fujitsu_uncore_pmu.c b/drivers/perf/fujitsu_uncore_pmu.c
index ede652f757da..fa64146fcac6 100644
--- a/drivers/perf/fujitsu_uncore_pmu.c
+++ b/drivers/perf/fujitsu_uncore_pmu.c
@@ -526,7 +526,7 @@ static int fujitsu_uncore_pmu_probe(struct platform_device *pdev)
IRQF_NOBALANCING | IRQF_NO_THREAD,
name, uncorepmu);
if (ret)
- return dev_err_probe(dev, ret, "Failed to request IRQ:%d\n", irq);
+ return ret;
ret = irq_set_affinity(irq, cpumask_of(uncorepmu->cpu));
if (ret)
diff --git a/drivers/perf/qcom_l2_pmu.c b/drivers/perf/qcom_l2_pmu.c
index c0c522b10b72..29554cca22c5 100644
--- a/drivers/perf/qcom_l2_pmu.c
+++ b/drivers/perf/qcom_l2_pmu.c
@@ -869,11 +869,8 @@ static int l2_cache_pmu_probe_cluster(struct device *dev, void *data)
IRQF_NOBALANCING | IRQF_NO_THREAD |
IRQF_NO_AUTOEN,
"l2-cache-pmu", cluster);
- if (err) {
- dev_err(&pdev->dev,
- "Unable to request IRQ%d for L2 PMU counters\n", irq);
+ if (err)
return err;
- }
dev_info(&pdev->dev,
"Registered L2 cache PMU cluster %lld\n", fw_cluster_id);
diff --git a/drivers/perf/qcom_l3_pmu.c b/drivers/perf/qcom_l3_pmu.c
index c8d259dd1f80..e18d0f94e8d8 100644
--- a/drivers/perf/qcom_l3_pmu.c
+++ b/drivers/perf/qcom_l3_pmu.c
@@ -767,11 +767,8 @@ static int qcom_l3_cache_pmu_probe(struct platform_device *pdev)
ret = devm_request_irq(&pdev->dev, ret, qcom_l3_cache__handle_irq, 0,
name, l3pmu);
- if (ret) {
- dev_err(&pdev->dev, "Request for IRQ failed for slice @%pa\n",
- &memrc->start);
+ if (ret)
return ret;
- }
/* Add this instance to the list used by the offline callback */
ret = cpuhp_state_add_instance(CPUHP_AP_PERF_ARM_QCOM_L3_ONLINE, &l3pmu->node);
diff --git a/drivers/perf/starfive_starlink_pmu.c b/drivers/perf/starfive_starlink_pmu.c
index dc4e653761fc..98e5ccee2fdc 100644
--- a/drivers/perf/starfive_starlink_pmu.c
+++ b/drivers/perf/starfive_starlink_pmu.c
@@ -435,7 +435,7 @@ static int starlink_setup_irqs(struct starlink_pmu *starlink_pmu,
ret = devm_request_irq(&pdev->dev, irq, starlink_pmu_handle_irq,
0, STARLINK_PMU_PDEV_NAME, starlink_pmu);
if (ret)
- return dev_err_probe(&pdev->dev, ret, "Failed to request IRQ\n");
+ return ret;
starlink_pmu->irq = irq;
diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c
index e9e4871db08d..ab3623fab914 100644
--- a/drivers/perf/xgene_pmu.c
+++ b/drivers/perf/xgene_pmu.c
@@ -1876,10 +1876,8 @@ static int xgene_pmu_probe(struct platform_device *pdev)
rc = devm_request_irq(&pdev->dev, irq, xgene_pmu_isr,
IRQF_NOBALANCING | IRQF_NO_THREAD,
dev_name(&pdev->dev), xgene_pmu);
- if (rc) {
- dev_err(&pdev->dev, "Could not request IRQ %d\n", irq);
+ if (rc)
return rc;
- }
xgene_pmu->irq = irq;
--
2.34.1
next prev parent reply other threads:[~2026-07-17 10:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 10:31 [PATCH 0/3] perf: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-17 10:31 ` Pan Chuang [this message]
2026-07-17 11:06 ` [PATCH 1/3] perf: Remove redundant dev_err()/dev_err_probe() Xu Yang
2026-07-17 16:00 ` Frank Li
2026-07-17 10:31 ` [PATCH 2/3] perf: arm_cspmu: Remove redundant dev_err() Pan Chuang
2026-07-17 10:31 ` [PATCH 3/3] drivers/perf: hisi: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-20 4:05 ` Yushan Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717103123.34887-2-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=Frank.li@nxp.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jisheng.teoh@starfivetech.com \
--cc=kernel@pengutronix.de \
--cc=khuong@os.amperecomputing.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=s.hauer@pengutronix.de \
--cc=will@kernel.org \
--cc=xu.yang_2@nxp.com \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox