From: Pan Chuang <panchuang@vivo.com>
To: Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Besar Wicaksono <bwicaksono@nvidia.com>,
Ilkka Koskinen <ilkka@os.amperecomputing.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Ma Ke <make24@iscas.ac.cn>,
Chengwen Feng <fengchengwen@huawei.com>,
Yury Norov <ynorov@nvidia.com>, Pan Chuang <panchuang@vivo.com>,
linux-arm-kernel@lists.infradead.org (moderated list:ARM PMU
PROFILING AND DEBUGGING),
linux-perf-users@vger.kernel.org (open list:ARM PMU PROFILING
AND DEBUGGING), linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 2/3] perf: arm_cspmu: Remove redundant dev_err()
Date: Fri, 17 Jul 2026 18:31:18 +0800 [thread overview]
Message-ID: <20260717103123.34887-3-panchuang@vivo.com> (raw)
In-Reply-To: <20260717103123.34887-1-panchuang@vivo.com>
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/perf/arm_cspmu/arm_cspmu.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/perf/arm_cspmu/arm_cspmu.c b/drivers/perf/arm_cspmu/arm_cspmu.c
index e6292021f653..ae754363fba8 100644
--- a/drivers/perf/arm_cspmu/arm_cspmu.c
+++ b/drivers/perf/arm_cspmu/arm_cspmu.c
@@ -1070,10 +1070,8 @@ static int arm_cspmu_request_irq(struct arm_cspmu *cspmu)
ret = devm_request_irq(dev, irq, arm_cspmu_handle_irq,
IRQF_NOBALANCING | IRQF_NO_THREAD, dev_name(dev),
cspmu);
- if (ret) {
- dev_err(dev, "Could not request IRQ %d\n", irq);
+ if (ret)
return ret;
- }
cspmu->irq = irq;
--
2.34.1
next prev parent reply other threads:[~2026-07-17 10:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 10:31 [PATCH 0/3] perf: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-17 10:31 ` [PATCH 1/3] perf: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17 11:06 ` Xu Yang
2026-07-17 16:00 ` Frank Li
2026-07-17 10:31 ` Pan Chuang [this message]
2026-07-17 10:31 ` [PATCH 3/3] drivers/perf: hisi: " Pan Chuang
2026-07-20 4:05 ` Yushan Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717103123.34887-3-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=bwicaksono@nvidia.com \
--cc=fengchengwen@huawei.com \
--cc=ilkka@os.amperecomputing.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=mark.rutland@arm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=will@kernel.org \
--cc=ynorov@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox