* [PATCH 0/3] usb: Use %pe to print error pointers
@ 2026-07-19 12:55 Subasri S
2026-07-19 12:55 ` [PATCH 1/3] usb: chipidea: " Subasri S
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Subasri S @ 2026-07-19 12:55 UTC (permalink / raw)
To: Peter Chen, Greg Kroah-Hartman, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Duncan Sands,
Chas Williams, Minas Harutyunyan, Hans de Goede, Heikki Krogerus,
Badhri Jagan Sridharan
Cc: linux-usb, imx, linux-arm-kernel, linux-kernel, linux-atm-general,
netdev, Subasri S
This patchset replaces PTR_ERR() in format strings with
%pe format specifier across the USB subsystem. %pe prints
symbolic error names (e.g., -ENOMEM) instead of
raw numbers (e.g., -12), making error logs more readable.
These patches fix coccinelle reported warning: "Consider
using %pe to print PTR_ERR()" in usb subsystem.
The patches are grouped by subsystem:
1/3 - chipidea
2/3 - miscellaneous USB drivers
3/3 - typec
All patches are compile-tested on x86_64. Please let me know if
any more testing is needed for any patch.
Signed-off-by: Subasri S <subasris1210@gmail.com>
---
Subasri S (3):
usb: chipidea: Use %pe to print error pointers
usb: misc: Use %pe to print error pointers
usb: typec: Use %pe to print error pointers
drivers/usb/atm/usbatm.c | 4 ++--
drivers/usb/chipidea/ci_hdrc_imx.c | 12 ++++++------
drivers/usb/chipidea/core.c | 4 ++--
drivers/usb/core/hub.c | 4 ++--
drivers/usb/dwc2/pci.c | 4 ++--
drivers/usb/gadget/function/u_serial.c | 4 ++--
drivers/usb/misc/usb3503.c | 4 ++--
drivers/usb/typec/mux/pi3usb30532.c | 8 ++++----
drivers/usb/typec/tcpm/tcpm.c | 2 +-
drivers/usb/typec/wusb3801.c | 4 ++--
10 files changed, 25 insertions(+), 25 deletions(-)
---
base-commit: a13c140cc289c0b7b3770bce5b3ad42ab35074aa
change-id: 20260718-usb-ptr_err_patchset-7c5d1547bee7
Best regards,
--
Subasri S <subasris1210@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/3] usb: chipidea: Use %pe to print error pointers
2026-07-19 12:55 [PATCH 0/3] usb: Use %pe to print error pointers Subasri S
@ 2026-07-19 12:55 ` Subasri S
2026-07-19 12:55 ` [PATCH 2/3] usb: misc: " Subasri S
2026-07-19 12:55 ` [PATCH 3/3] usb: typec: " Subasri S
2 siblings, 0 replies; 5+ messages in thread
From: Subasri S @ 2026-07-19 12:55 UTC (permalink / raw)
To: Peter Chen, Greg Kroah-Hartman, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Duncan Sands,
Chas Williams, Minas Harutyunyan, Hans de Goede, Heikki Krogerus,
Badhri Jagan Sridharan
Cc: linux-usb, imx, linux-arm-kernel, linux-kernel, linux-atm-general,
netdev, Subasri S
Use the %pe format specifier instead of %ld with PTR_ERR() for printing
error pointers in imx_get_clks(), ci_hdrc_imx_probe(), and
ci_get_platdata(). This prints symbolic error names (e.g. -ENOMEM)
instead of errno numbers (e.g. -12), making error logs more readable.
This patch fixes coccinelle reported warnings:
./chipidea/ci_hdrc_imx.c:452:5-12: WARNING: Consider using %pe to print PTR_ERR()
./chipidea/ci_hdrc_imx.c:468:5-12: WARNING: Consider using %pe to print PTR_ERR()
./chipidea/ci_hdrc_imx.c:222:4-11: WARNING: Consider using %pe to print PTR_ERR()
./chipidea/ci_hdrc_imx.c:222:24-31: WARNING: Consider using %pe to print PTR_ERR()
./chipidea/core.c:684:4-11: WARNING: Consider using %pe to print PTR_ERR()
Compile-tested only.
Signed-off-by: Subasri S <subasris1210@gmail.com>
---
drivers/usb/chipidea/ci_hdrc_imx.c | 12 ++++++------
drivers/usb/chipidea/core.c | 4 ++--
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
index 56d2ba824a0b..7bfe37ed68ae 100644
--- a/drivers/usb/chipidea/ci_hdrc_imx.c
+++ b/drivers/usb/chipidea/ci_hdrc_imx.c
@@ -218,8 +218,8 @@ static int imx_get_clks(struct device *dev)
if (IS_ERR(data->clk)) {
ret = PTR_ERR(data->clk);
dev_err(dev,
- "Failed to get clks, err=%ld,%ld\n",
- PTR_ERR(data->clk), PTR_ERR(data->clk_ipg));
+ "Failed to get clks, err=%pe,%pe\n",
+ data->clk, data->clk_ipg);
return ret;
}
/* Get wakeup clock. Not all of the platforms need to
@@ -448,8 +448,8 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
pinctrl_hsic_idle = pinctrl_lookup_state(data->pinctrl, "idle");
if (IS_ERR(pinctrl_hsic_idle)) {
dev_err(dev,
- "pinctrl_hsic_idle lookup failed, err=%ld\n",
- PTR_ERR(pinctrl_hsic_idle));
+ "pinctrl_hsic_idle lookup failed, err=%pe\n",
+ pinctrl_hsic_idle);
ret = PTR_ERR(pinctrl_hsic_idle);
goto err_put;
}
@@ -464,8 +464,8 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
"active");
if (IS_ERR(data->pinctrl_hsic_active)) {
dev_err(dev,
- "pinctrl_hsic_active lookup failed, err=%ld\n",
- PTR_ERR(data->pinctrl_hsic_active));
+ "pinctrl_hsic_active lookup failed, err=%pe\n",
+ data->pinctrl_hsic_active);
ret = PTR_ERR(data->pinctrl_hsic_active);
goto err_put;
}
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 07563be0013f..09db8a4eace2 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -680,8 +680,8 @@ static int ci_get_platdata(struct device *dev,
/* no vbus regulator is needed */
platdata->reg_vbus = NULL;
} else if (IS_ERR(platdata->reg_vbus)) {
- dev_err(dev, "Getting regulator error: %ld\n",
- PTR_ERR(platdata->reg_vbus));
+ dev_err(dev, "Getting regulator error: %pe\n",
+ platdata->reg_vbus);
return PTR_ERR(platdata->reg_vbus);
}
/* Get TPL support */
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/3] usb: misc: Use %pe to print error pointers
2026-07-19 12:55 [PATCH 0/3] usb: Use %pe to print error pointers Subasri S
2026-07-19 12:55 ` [PATCH 1/3] usb: chipidea: " Subasri S
@ 2026-07-19 12:55 ` Subasri S
2026-07-19 12:55 ` [PATCH 3/3] usb: typec: " Subasri S
2 siblings, 0 replies; 5+ messages in thread
From: Subasri S @ 2026-07-19 12:55 UTC (permalink / raw)
To: Peter Chen, Greg Kroah-Hartman, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Duncan Sands,
Chas Williams, Minas Harutyunyan, Hans de Goede, Heikki Krogerus,
Badhri Jagan Sridharan
Cc: linux-usb, imx, linux-arm-kernel, linux-kernel, linux-atm-general,
netdev, Subasri S
Use the %pe format specifier instead of %ld with PTR_ERR() for printing
error pointers in various drivers across usb subsystem.
This prints symbolic error names (e.g.-ENOMEM) instead of
errno numbers (e.g. -12), making error logs more readable.
This patch fixes coccinelle reported warnings:
./misc/usb3503.c:206:5-12: WARNING: Consider using %pe to print PTR_ERR()
./atm/usbatm.c:983:14-21: WARNING: Consider using %pe to print PTR_ERR()
./core/hub.c:5675:6-13: WARNING: Consider using %pe to print PTR_ERR()
./gadget/function/u_serial.c:1315:24-31: WARNING: Consider using %pe to print PTR_ERR()
./dwc2/pci.c:72:3-10: WARNING: Consider using %pe to print PTR_ERR()
Compile tested only.
Signed-off-by: Subasri S <subasris1210@gmail.com>
---
drivers/usb/atm/usbatm.c | 4 ++--
drivers/usb/core/hub.c | 4 ++--
drivers/usb/dwc2/pci.c | 4 ++--
drivers/usb/gadget/function/u_serial.c | 4 ++--
drivers/usb/misc/usb3503.c | 4 ++--
5 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/atm/usbatm.c b/drivers/usb/atm/usbatm.c
index 9600e1ec0993..c78caa1b57c9 100644
--- a/drivers/usb/atm/usbatm.c
+++ b/drivers/usb/atm/usbatm.c
@@ -979,8 +979,8 @@ static int usbatm_heavy_init(struct usbatm_data *instance)
t = kthread_create(usbatm_do_heavy_init, instance, "%s",
instance->driver->driver_name);
if (IS_ERR(t)) {
- usb_err(instance, "%s: failed to create kernel_thread (%ld)!\n",
- __func__, PTR_ERR(t));
+ usb_err(instance, "%s: failed to create kernel_thread (%pe)!\n",
+ __func__, t);
return PTR_ERR(t);
}
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 5262e11c12cd..5e33e3984499 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -5671,8 +5671,8 @@ static void hub_port_connect_change(struct usb_hub *hub, int port1,
descr = usb_get_device_descriptor(udev);
if (IS_ERR(descr)) {
dev_dbg(&udev->dev,
- "can't read device descriptor %ld\n",
- PTR_ERR(descr));
+ "can't read device descriptor %pe\n",
+ descr);
} else {
if (descriptors_changed(udev, descr,
udev->bos)) {
diff --git a/drivers/usb/dwc2/pci.c b/drivers/usb/dwc2/pci.c
index f3a1e4232a31..9845327f95c5 100644
--- a/drivers/usb/dwc2/pci.c
+++ b/drivers/usb/dwc2/pci.c
@@ -68,8 +68,8 @@ static int dwc2_pci_probe(struct pci_dev *pci,
phy = usb_phy_generic_register();
if (IS_ERR(phy)) {
- dev_err(dev, "error registering generic PHY (%ld)\n",
- PTR_ERR(phy));
+ dev_err(dev, "error registering generic PHY (%pe)\n",
+ phy);
return PTR_ERR(phy);
}
diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c
index cdd1dfc666c4..da31e5cea0a5 100644
--- a/drivers/usb/gadget/function/u_serial.c
+++ b/drivers/usb/gadget/function/u_serial.c
@@ -1311,8 +1311,8 @@ int gserial_alloc_line_no_console(unsigned char *line_num)
tty_dev = tty_port_register_device(&port->port,
gs_tty_driver, port_num, NULL);
if (IS_ERR(tty_dev)) {
- pr_err("%s: failed to register tty for port %d, err %ld\n",
- __func__, port_num, PTR_ERR(tty_dev));
+ pr_err("%s: failed to register tty for port %d, err %pe\n",
+ __func__, port_num, tty_dev);
ret = PTR_ERR(tty_dev);
mutex_lock(&ports[port_num].lock);
diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c
index 759770a13260..3ac57d31376c 100644
--- a/drivers/usb/misc/usb3503.c
+++ b/drivers/usb/misc/usb3503.c
@@ -202,8 +202,8 @@ static int usb3503_probe(struct usb3503 *hub)
hub->clk = devm_clk_get_optional(dev, "refclk");
if (IS_ERR(hub->clk)) {
- dev_err(dev, "unable to request refclk (%ld)\n",
- PTR_ERR(hub->clk));
+ dev_err(dev, "unable to request refclk (%pe)\n",
+ hub->clk);
return PTR_ERR(hub->clk);
}
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/3] usb: typec: Use %pe to print error pointers
2026-07-19 12:55 [PATCH 0/3] usb: Use %pe to print error pointers Subasri S
2026-07-19 12:55 ` [PATCH 1/3] usb: chipidea: " Subasri S
2026-07-19 12:55 ` [PATCH 2/3] usb: misc: " Subasri S
@ 2026-07-19 12:55 ` Subasri S
2026-07-20 11:38 ` Badhri Jagan Sridharan
2 siblings, 1 reply; 5+ messages in thread
From: Subasri S @ 2026-07-19 12:55 UTC (permalink / raw)
To: Peter Chen, Greg Kroah-Hartman, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Duncan Sands,
Chas Williams, Minas Harutyunyan, Hans de Goede, Heikki Krogerus,
Badhri Jagan Sridharan
Cc: linux-usb, imx, linux-arm-kernel, linux-kernel, linux-atm-general,
netdev, Subasri S
Use the %pe format specifier instead of %ld with PTR_ERR() for printing
error pointers in various typec drivers. This prints symbolic
error names (e.g.-ENOMEM) instead of errno numbers (e.g. -12),
making error logs more readable.
This patch fixes coccinelle reported warnings:
./typec/tcpm/tcpm.c:4799:60-67: WARNING: Consider using %pe to print PTR_ERR()
./typec/mux/pi3usb30532.c:143:3-10: WARNING: Consider using %pe to print PTR_ERR()
./typec/mux/pi3usb30532.c:155:3-10: WARNING: Consider using %pe to print PTR_ERR()
./typec/wusb3801.c:281:5-12: WARNING: Consider using %pe to print PTR_ERR()
Compile tested only.
Signed-off-by: Subasri S <subasris1210@gmail.com>
---
drivers/usb/typec/mux/pi3usb30532.c | 8 ++++----
drivers/usb/typec/tcpm/tcpm.c | 2 +-
drivers/usb/typec/wusb3801.c | 4 ++--
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/typec/mux/pi3usb30532.c b/drivers/usb/typec/mux/pi3usb30532.c
index 985683fe49e9..a2357a28ecf4 100644
--- a/drivers/usb/typec/mux/pi3usb30532.c
+++ b/drivers/usb/typec/mux/pi3usb30532.c
@@ -139,8 +139,8 @@ static int pi3usb30532_probe(struct i2c_client *client)
pi->sw = typec_switch_register(dev, &sw_desc);
if (IS_ERR(pi->sw)) {
- dev_err(dev, "Error registering typec switch: %ld\n",
- PTR_ERR(pi->sw));
+ dev_err(dev, "Error registering typec switch: %pe\n",
+ pi->sw);
return PTR_ERR(pi->sw);
}
@@ -151,8 +151,8 @@ static int pi3usb30532_probe(struct i2c_client *client)
pi->mux = typec_mux_register(dev, &mux_desc);
if (IS_ERR(pi->mux)) {
typec_switch_unregister(pi->sw);
- dev_err(dev, "Error registering typec mux: %ld\n",
- PTR_ERR(pi->mux));
+ dev_err(dev, "Error registering typec mux: %pe\n",
+ pi->mux);
return PTR_ERR(pi->mux);
}
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index 89eec20a2064..ad10470ea73b 100644
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -4796,7 +4796,7 @@ static void tcpm_typec_connect(struct tcpm_port *port)
port->partner_desc.accessory = TYPEC_ACCESSORY_NONE;
partner = typec_register_partner(port->typec_port, &port->partner_desc);
if (IS_ERR(partner)) {
- dev_err(port->dev, "Failed to register partner (%ld)\n", PTR_ERR(partner));
+ dev_err(port->dev, "Failed to register partner (%pe)\n", partner);
return;
}
diff --git a/drivers/usb/typec/wusb3801.c b/drivers/usb/typec/wusb3801.c
index 6062875fb04a..86d13ab41670 100644
--- a/drivers/usb/typec/wusb3801.c
+++ b/drivers/usb/typec/wusb3801.c
@@ -277,8 +277,8 @@ static void wusb3801_hw_update(struct wusb3801 *wusb3801)
if (partner_type != WUSB3801_STAT_PARTNER_STANDBY) {
wusb3801->partner = typec_register_partner(port, &desc);
if (IS_ERR(wusb3801->partner))
- dev_err(dev, "Failed to register partner: %ld\n",
- PTR_ERR(wusb3801->partner));
+ dev_err(dev, "Failed to register partner: %pe\n",
+ wusb3801->partner);
}
data_role = pwr_role == TYPEC_SOURCE ? TYPEC_HOST : TYPEC_DEVICE;
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] usb: typec: Use %pe to print error pointers
2026-07-19 12:55 ` [PATCH 3/3] usb: typec: " Subasri S
@ 2026-07-20 11:38 ` Badhri Jagan Sridharan
0 siblings, 0 replies; 5+ messages in thread
From: Badhri Jagan Sridharan @ 2026-07-20 11:38 UTC (permalink / raw)
To: Subasri S
Cc: Peter Chen, Greg Kroah-Hartman, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Duncan Sands,
Chas Williams, Minas Harutyunyan, Hans de Goede, Heikki Krogerus,
linux-usb, imx, linux-arm-kernel, linux-kernel, linux-atm-general,
netdev
On Sun, Jul 19, 2026 at 5:56 AM Subasri S <subasris1210@gmail.com> wrote:
>
> Use the %pe format specifier instead of %ld with PTR_ERR() for printing
> error pointers in various typec drivers. This prints symbolic
> error names (e.g.-ENOMEM) instead of errno numbers (e.g. -12),
> making error logs more readable.
>
> This patch fixes coccinelle reported warnings:
> ./typec/tcpm/tcpm.c:4799:60-67: WARNING: Consider using %pe to print PTR_ERR()
> ./typec/mux/pi3usb30532.c:143:3-10: WARNING: Consider using %pe to print PTR_ERR()
> ./typec/mux/pi3usb30532.c:155:3-10: WARNING: Consider using %pe to print PTR_ERR()
> ./typec/wusb3801.c:281:5-12: WARNING: Consider using %pe to print PTR_ERR()
>
> Compile tested only.
>
> Signed-off-by: Subasri S <subasris1210@gmail.com>
Reviewed-by: Badhri Jagan Sridharan <badhri@google.com>
> ---
> drivers/usb/typec/mux/pi3usb30532.c | 8 ++++----
> drivers/usb/typec/tcpm/tcpm.c | 2 +-
> drivers/usb/typec/wusb3801.c | 4 ++--
> 3 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/usb/typec/mux/pi3usb30532.c b/drivers/usb/typec/mux/pi3usb30532.c
> index 985683fe49e9..a2357a28ecf4 100644
> --- a/drivers/usb/typec/mux/pi3usb30532.c
> +++ b/drivers/usb/typec/mux/pi3usb30532.c
> @@ -139,8 +139,8 @@ static int pi3usb30532_probe(struct i2c_client *client)
>
> pi->sw = typec_switch_register(dev, &sw_desc);
> if (IS_ERR(pi->sw)) {
> - dev_err(dev, "Error registering typec switch: %ld\n",
> - PTR_ERR(pi->sw));
> + dev_err(dev, "Error registering typec switch: %pe\n",
> + pi->sw);
> return PTR_ERR(pi->sw);
> }
>
> @@ -151,8 +151,8 @@ static int pi3usb30532_probe(struct i2c_client *client)
> pi->mux = typec_mux_register(dev, &mux_desc);
> if (IS_ERR(pi->mux)) {
> typec_switch_unregister(pi->sw);
> - dev_err(dev, "Error registering typec mux: %ld\n",
> - PTR_ERR(pi->mux));
> + dev_err(dev, "Error registering typec mux: %pe\n",
> + pi->mux);
> return PTR_ERR(pi->mux);
> }
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 89eec20a2064..ad10470ea73b 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -4796,7 +4796,7 @@ static void tcpm_typec_connect(struct tcpm_port *port)
> port->partner_desc.accessory = TYPEC_ACCESSORY_NONE;
> partner = typec_register_partner(port->typec_port, &port->partner_desc);
> if (IS_ERR(partner)) {
> - dev_err(port->dev, "Failed to register partner (%ld)\n", PTR_ERR(partner));
> + dev_err(port->dev, "Failed to register partner (%pe)\n", partner);
> return;
> }
>
> diff --git a/drivers/usb/typec/wusb3801.c b/drivers/usb/typec/wusb3801.c
> index 6062875fb04a..86d13ab41670 100644
> --- a/drivers/usb/typec/wusb3801.c
> +++ b/drivers/usb/typec/wusb3801.c
> @@ -277,8 +277,8 @@ static void wusb3801_hw_update(struct wusb3801 *wusb3801)
> if (partner_type != WUSB3801_STAT_PARTNER_STANDBY) {
> wusb3801->partner = typec_register_partner(port, &desc);
> if (IS_ERR(wusb3801->partner))
> - dev_err(dev, "Failed to register partner: %ld\n",
> - PTR_ERR(wusb3801->partner));
> + dev_err(dev, "Failed to register partner: %pe\n",
> + wusb3801->partner);
> }
>
> data_role = pwr_role == TYPEC_SOURCE ? TYPEC_HOST : TYPEC_DEVICE;
>
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-07-20 11:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-19 12:55 [PATCH 0/3] usb: Use %pe to print error pointers Subasri S
2026-07-19 12:55 ` [PATCH 1/3] usb: chipidea: " Subasri S
2026-07-19 12:55 ` [PATCH 2/3] usb: misc: " Subasri S
2026-07-19 12:55 ` [PATCH 3/3] usb: typec: " Subasri S
2026-07-20 11:38 ` Badhri Jagan Sridharan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox