[PATCH 0/9] watchdog: Remove redundant error messages on IRQ request failure

[PATCH 0/9] watchdog: Remove redundant error messages on IRQ request failure

[Pan Chuang]

Commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()")
added automatic error logging to devm_request_threaded_irq() and
devm_request_any_context_irq() via the new devm_request_result() helper,
which prints device name, IRQ number, handler functions, and error code
on failure.

Since devm_request_irq() is a static inline wrapper around
devm_request_threaded_irq(), it also benefits from this
automatic logging.

Remove the now-redundant dev_err() and dev_err_probe() calls
in watchdog drivers that follow these devm_request_*_irq()
functions, as the core now provides more detailed diagnostic
information on failure.

Pan Chuang (9):
  watchdog: bd96801_wdt: Remove redundant dev_err_probe()
  watchdog: cadence_wdt: Remove redundant dev_err()
  watchdog: intel-mid_wdt: Remove redundant dev_err()
  watchdog: keembay: Remove redundant dev_err_probe()
  watchdog: marvell_gti: Remove redundant dev_err_probe()
  watchdog: orion: Remove redundant dev_err()
  watchdog: realtek_otto: Remove redundant dev_err_probe()
  watchdog: sama5d4: Remove redundant dev_err()
  watchdog: sprd: Remove redundant dev_err()

 drivers/watchdog/bd96801_wdt.c      | 3 +--
 drivers/watchdog/cadence_wdt.c      | 6 +-----
 drivers/watchdog/intel-mid_wdt.c    | 4 +---
 drivers/watchdog/keembay_wdt.c      | 4 ++--
 drivers/watchdog/marvell_gti_wdt.c  | 2 +-
 drivers/watchdog/orion_wdt.c        | 8 ++------
 drivers/watchdog/realtek_otto_wdt.c | 2 +-
 drivers/watchdog/sama5d4_wdt.c      | 4 +---
 drivers/watchdog/sprd_wdt.c         | 4 +---
 9 files changed, 11 insertions(+), 26 deletions(-)

-- 
2.34.1

[PATCH 8/9] watchdog: sama5d4: Remove redundant dev_err()

[Pan Chuang]

Since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
devm_request_irq() automatically logs detailed error messages on
failure. Remove the now-redundant driver-specific dev_err() call.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/watchdog/sama5d4_wdt.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/watchdog/sama5d4_wdt.c b/drivers/watchdog/sama5d4_wdt.c
index 704b786cc2ec..ecdd9aeab79c 100644
--- a/drivers/watchdog/sama5d4_wdt.c
+++ b/drivers/watchdog/sama5d4_wdt.c
@@ -291,10 +291,8 @@ static int sama5d4_wdt_probe(struct platform_device *pdev)
 		ret = devm_request_irq(dev, irq, sama5d4_wdt_irq_handler,
 				       IRQF_SHARED | IRQF_IRQPOLL |
 				       IRQF_NO_SUSPEND, pdev->name, pdev);
-		if (ret) {
-			dev_err(dev, "cannot register interrupt handler\n");
+		if (ret)
 			return ret;
-		}
 	}
 
 	watchdog_init_timeout(wdd, wdt_timeout, dev);
-- 
2.34.1

Re: [PATCH 8/9] watchdog: sama5d4: Remove redundant dev_err()

[Alexandre Belloni]

On 22/07/2026 16:42:16+0800, Pan Chuang wrote:
> Since commit
> 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
> devm_request_irq() automatically logs detailed error messages on
> failure. Remove the now-redundant driver-specific dev_err() call.
> 
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
>  drivers/watchdog/sama5d4_wdt.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/sama5d4_wdt.c b/drivers/watchdog/sama5d4_wdt.c
> index 704b786cc2ec..ecdd9aeab79c 100644
> --- a/drivers/watchdog/sama5d4_wdt.c
> +++ b/drivers/watchdog/sama5d4_wdt.c
> @@ -291,10 +291,8 @@ static int sama5d4_wdt_probe(struct platform_device *pdev)
>  		ret = devm_request_irq(dev, irq, sama5d4_wdt_irq_handler,
>  				       IRQF_SHARED | IRQF_IRQPOLL |
>  				       IRQF_NO_SUSPEND, pdev->name, pdev);
> -		if (ret) {
> -			dev_err(dev, "cannot register interrupt handler\n");
> +		if (ret)
>  			return ret;
> -		}
>  	}
>  
>  	watchdog_init_timeout(wdd, wdt_timeout, dev);
> -- 
> 2.34.1
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com