* [PATCH 06/36] drm: remove conditional return with no effect
[not found] <20260723184538.3888637-1-ekffu200098@gmail.com>
@ 2026-07-23 18:45 ` Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 19/36] dmaengine: qcom_hidma: " Sang-Heon Jeon
` (2 subsequent siblings)
3 siblings, 0 replies; 4+ messages in thread
From: Sang-Heon Jeon @ 2026-07-23 18:45 UTC (permalink / raw)
To: Julia.Lawall, Philipp Zabel, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Frank Li,
Sascha Hauer, Lyude Paul, Danilo Krummrich, Neil Armstrong,
Jyri Sarha, Tomi Valkeinen
Cc: cocci, dri-devel, Fabio Estevam, imx, Jessica Zhang,
linux-arm-kernel, linux-kernel, nouveau, Pengutronix Kernel Team
Both branches of the check return the same value, so the check has
no effect. Remove it and return the value directly.
This is the result of running the Coccinelle script from
scripts/coccinelle/misc/cond_return_no_effect.cocci.
Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
drivers/gpu/drm/imx/ipuv3/imx-drm-core.c | 6 +-----
drivers/gpu/drm/nouveau/dispnv50/disp.c | 14 +++++---------
drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c | 7 +------
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 6 +-----
4 files changed, 8 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c b/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c
index 51a0ec043248..52a2334be799 100644
--- a/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c
+++ b/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c
@@ -55,11 +55,7 @@ static int imx_drm_atomic_check(struct drm_device *dev,
return ret;
/* Assign PRG/PRE channels and check if all constrains are satisfied. */
- ret = ipu_planes_assign_pre(dev, state);
- if (ret)
- return ret;
-
- return ret;
+ return ipu_planes_assign_pre(dev, state);
}
static const struct drm_mode_config_funcs imx_drm_mode_config_funcs = {
diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index 364227f5456f..e8fde399acae 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
@@ -301,19 +301,15 @@ nv50_dmac_create(struct nouveau_drm *drm,
if (ret)
return ret;
- ret = nvif_object_ctor(&dmac->base.user, "kmsVramCtxDma", NV50_DISP_HANDLE_VRAM,
- NV_DMA_IN_MEMORY,
- &(struct nv_dma_v0) {
+ return nvif_object_ctor(&dmac->base.user, "kmsVramCtxDma", NV50_DISP_HANDLE_VRAM,
+ NV_DMA_IN_MEMORY,
+ &(struct nv_dma_v0) {
.target = NV_DMA_V0_TARGET_VRAM,
.access = NV_DMA_V0_ACCESS_RDWR,
.start = 0,
.limit = device->info.ram_user - 1,
- }, sizeof(struct nv_dma_v0),
- &dmac->vram);
- if (ret)
- return ret;
-
- return ret;
+ }, sizeof(struct nv_dma_v0),
+ &dmac->vram);
}
/******************************************************************************
diff --git a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
index 2334b77f348c..16a02527285e 100644
--- a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
+++ b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
@@ -58,13 +58,8 @@ static int osd101t2587_panel_prepare(struct drm_panel *panel)
static int osd101t2587_panel_enable(struct drm_panel *panel)
{
struct osd101t2587_panel *osd101t2587 = ti_osd_panel(panel);
- int ret;
- ret = mipi_dsi_turn_on_peripheral(osd101t2587->dsi);
- if (ret)
- return ret;
-
- return ret;
+ return mipi_dsi_turn_on_peripheral(osd101t2587->dsi);
}
static const struct drm_display_mode default_mode_osd101t2587 = {
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 1d6c9a423a41..990805f1fea6 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -64,11 +64,7 @@ static int tilcdc_atomic_check(struct drm_device *dev,
* tilcdc ->atomic_check can update ->mode_changed if pixel format
* changes, hence will we check modeset changes again.
*/
- ret = drm_atomic_helper_check_modeset(dev, state);
- if (ret)
- return ret;
-
- return ret;
+ return drm_atomic_helper_check_modeset(dev, state);
}
static const struct drm_mode_config_funcs mode_config_funcs = {
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 19/36] dmaengine: qcom_hidma: remove conditional return with no effect
[not found] <20260723184538.3888637-1-ekffu200098@gmail.com>
2026-07-23 18:45 ` [PATCH 06/36] drm: remove conditional return with no effect Sang-Heon Jeon
@ 2026-07-23 18:45 ` Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 20/36] stm class: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 24/36] pinctrl: mediatek: " Sang-Heon Jeon
3 siblings, 0 replies; 4+ messages in thread
From: Sang-Heon Jeon @ 2026-07-23 18:45 UTC (permalink / raw)
To: Julia.Lawall, Sinan Kaya, Vinod Koul
Cc: cocci, dmaengine, Frank Li, linux-arm-kernel, linux-arm-msm,
linux-kernel
Both branches of the check return the same value, so the check has
no effect. Remove it and return the value directly.
This is the result of running the Coccinelle script from
scripts/coccinelle/misc/cond_return_no_effect.cocci.
Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
drivers/dma/qcom/hidma_ll.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/dma/qcom/hidma_ll.c b/drivers/dma/qcom/hidma_ll.c
index 53244e0e34a3..f081aa787f0c 100644
--- a/drivers/dma/qcom/hidma_ll.c
+++ b/drivers/dma/qcom/hidma_ll.c
@@ -677,11 +677,7 @@ int hidma_ll_setup(struct hidma_lldev *lldev)
/* configure interrupts */
hidma_ll_setup_irq(lldev, lldev->msi_support);
- rc = hidma_ll_enable(lldev);
- if (rc)
- return rc;
-
- return rc;
+ return hidma_ll_enable(lldev);
}
void hidma_ll_setup_irq(struct hidma_lldev *lldev, bool msi)
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 20/36] stm class: remove conditional return with no effect
[not found] <20260723184538.3888637-1-ekffu200098@gmail.com>
2026-07-23 18:45 ` [PATCH 06/36] drm: remove conditional return with no effect Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 19/36] dmaengine: qcom_hidma: " Sang-Heon Jeon
@ 2026-07-23 18:45 ` Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 24/36] pinctrl: mediatek: " Sang-Heon Jeon
3 siblings, 0 replies; 4+ messages in thread
From: Sang-Heon Jeon @ 2026-07-23 18:45 UTC (permalink / raw)
To: Julia.Lawall, Alexander Shishkin, Maxime Coquelin,
Alexandre Torgue
Cc: cocci, linux-arm-kernel, linux-kernel, linux-stm32
Both branches of the check return the same value, so the check has
no effect. Remove it and return the value directly.
This is the result of running the Coccinelle script from
scripts/coccinelle/misc/cond_return_no_effect.cocci.
Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
drivers/hwtracing/stm/core.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c
index f48c6a8a0654..edf3d69a84a9 100644
--- a/drivers/hwtracing/stm/core.c
+++ b/drivers/hwtracing/stm/core.c
@@ -602,17 +602,11 @@ static ssize_t notrace
stm_write(struct stm_device *stm, struct stm_output *output,
unsigned int chan, const char *buf, size_t count, struct stm_source_data *source)
{
- int err;
-
/* stm->pdrv is serialized against policy_mutex */
if (!stm->pdrv)
return -ENODEV;
- err = stm->pdrv->write(stm->data, output, chan, buf, count, source);
- if (err < 0)
- return err;
-
- return err;
+ return stm->pdrv->write(stm->data, output, chan, buf, count, source);
}
static ssize_t stm_char_write(struct file *file, const char __user *buf,
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 24/36] pinctrl: mediatek: remove conditional return with no effect
[not found] <20260723184538.3888637-1-ekffu200098@gmail.com>
` (2 preceding siblings ...)
2026-07-23 18:45 ` [PATCH 20/36] stm class: " Sang-Heon Jeon
@ 2026-07-23 18:45 ` Sang-Heon Jeon
3 siblings, 0 replies; 4+ messages in thread
From: Sang-Heon Jeon @ 2026-07-23 18:45 UTC (permalink / raw)
To: Julia.Lawall, Sean Wang, Linus Walleij, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: cocci, linux-arm-kernel, linux-gpio, linux-kernel, linux-mediatek
Both branches of the check return the same value, so the check has
no effect. Remove it and return the value directly.
This is the result of running the Coccinelle script from
scripts/coccinelle/misc/cond_return_no_effect.cocci.
Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
index 4918d38abfc2..a8ab982d8f21 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
@@ -1242,11 +1242,7 @@ int mtk_pinconf_adv_drive_set(struct mtk_pinctrl *hw,
if (err)
return err;
- err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DRV_E1, e1);
- if (err)
- return err;
-
- return err;
+ return mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DRV_E1, e1);
}
EXPORT_SYMBOL_GPL(mtk_pinconf_adv_drive_set);
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread