From: Eric Biggers <ebiggers@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-crypto@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Demi Marie Obenour <demiobenour@gmail.com>,
Bartosz Golaszewski <brgl@kernel.org>,
Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] crypto: qce - Replace with stub driver
Date: Fri, 31 Jul 2026 03:02:14 -0700 [thread overview]
Message-ID: <20260731100214.GA1927@quark> (raw)
In-Reply-To: <a28c2903-0976-4559-b870-4de5553ba9ab@kernel.org>
On Fri, Jul 31, 2026 at 11:06:28AM +0200, Krzysztof Kozlowski wrote:
> On 31/07/2026 07:08, Eric Biggers wrote:
> > None of the algorithms the QCE driver registers with the crypto API are
> > even close to being useful. They're massively outperformed by the
>
> The amount of patches you send towards removal of QCE is really
> stunning. Or rather worrying. This is like third approach or so.
Note that the crypto maintainer has already accepted a patch from
another developer to mark this driver as BROKEN.
> This is beyond comprehension and very unpleasant, because you actively
> work against the community with this approach.
"The community" is more than the hardware vendor.
I think the results of independent testing of this driver are incredibly
clear. The pending fixes do not fix the performance either, but
actually make it worse.
I have been asking for the inclusion of this driver to be justified for
many years. As far as I've ever been able to tell it's just a "checkbox
feature", which isn't something that really belongs upstream.
I care about the technical merit of the kernel's cryptographic algorithm
implementations.
- Eric
prev parent reply other threads:[~2026-07-31 10:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260731050838.158825-1-ebiggers@kernel.org>
2026-07-31 5:32 ` [PATCH] crypto: qce - Replace with stub driver Demi Marie Obenour
2026-07-31 7:42 ` Bartosz Golaszewski
2026-07-31 9:06 ` Krzysztof Kozlowski
2026-07-31 10:02 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731100214.GA1927@quark \
--to=ebiggers@kernel.org \
--cc=brgl@kernel.org \
--cc=demiobenour@gmail.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krzk@kernel.org \
--cc=kuldeep.singh@oss.qualcomm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox