Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tzu-Hao Wei <twei@axiado.com>
Cc: Shubhangini G <shubhangini@axiado.com>,
	 Prasad Bolisetty <pbolisetty@axiado.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Karthikeyan Mitran <kmitran@axiado.com>,
	 linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org
Subject: Re: [PATCH 1/2] dt-bindings: media: add axiado,ax3000-video
Date: Tue, 4 Aug 2026 09:55:55 +0200	[thread overview]
Message-ID: <20260804-healthy-versatile-barnacle-b58db9@quoll> (raw)
In-Reply-To: <b585130e-710a-434d-bf06-cc06f9bffc33@axiado.com>

On Tue, Aug 04, 2026 at 07:31:25AM +0800, Tzu-Hao Wei wrote:
> >> There is no local register interface for this driver to program: frame
> >> delivery is controlled entirely by the host-side display engine and
> >> the PCIe endpoint mapping that feeds the shared region, both external
> >> to this driver. A software polling timer schedules a workqueue item at
> >> the configured framerate, which copies frames from the WC-mapped
> >> shared region into vmalloc-backed vb2 buffers. Running the copy in a
> >> work item rather than directly in the timer callback keeps potentially
> >> multi-megabyte memcpy and per-pixel conversion work out of softirq
> >> context.
> > 
> > Then this is not a separate device. You just described a Linux driver.
> > 
> > I still wait for answers of my question above. You described getting
> > buffers only.
> > 
> 
> Thank you for the continued review.
> 
> To correctly represent this in device tree without describing a
> software driver as a hardware device, would moving the schema into
> /reserved-memory be the preferred approach for v2?
> 
> Specifically, we are considering moving it to:
> Documentation/devicetree/bindings/reserved-memory/axiado,ax3000-video-mem.yaml

I would rather suggest this should be part of the device handling the
host side of the device. Or is there none?

Again, how do you configure the frame parameters or start capturing the
data?

> 
> This would follow the same Devicetree architectural pattern as
> qcom,rmtfs-mem:
> Documentation/devicetree/bindings/reserved-memory/qcom,rmtfs-mem.yaml
> 
> Just as qcom,rmtfs-mem describes a reserved memory buffer used by
> remote processors and exports /dev/rmtfs_mem%d without hardware MMIO
> registers, clocks, or resets, axiado,ax3000-video describes the
> reserved memory buffer used by the AX3000 display pipeline and exports
> /dev/video0.
> 
> Does representing axiado,ax3000-video as a reserved-memory node look
> like the appropriate way to model this in v2?

So from a device we went now to pure memory... That's quite a change and
would prove this was completely bogus hardware description.

I actually fail to see any hardware here, because you could just
allocate whatever memory and pass it to your host, no? Why it has to be
a reserved memory?

Best regards,
Krzysztof



  reply	other threads:[~2026-08-04  7:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30  7:26 [PATCH 0/2] media: axiado: add AX3000/AX3005 V4L2 capture driver Tzu-Hao Wei
2026-07-30  7:26 ` [PATCH 1/2] dt-bindings: media: add axiado,ax3000-video Tzu-Hao Wei
2026-07-30  8:12   ` Krzysztof Kozlowski
2026-08-03  5:29     ` Tzu-Hao Wei
2026-08-03  6:28       ` Krzysztof Kozlowski
2026-08-03 23:31         ` Tzu-Hao Wei
2026-08-04  7:55           ` Krzysztof Kozlowski [this message]
2026-07-30  7:26 ` [PATCH 2/2] media: axiado: add V4L2 capture driver for AX3000/AX3005 SoC Tzu-Hao Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260804-healthy-versatile-barnacle-b58db9@quoll \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kmitran@axiado.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=pbolisetty@axiado.com \
    --cc=robh@kernel.org \
    --cc=shubhangini@axiado.com \
    --cc=twei@axiado.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox