From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tzu-Hao Wei <twei@axiado.com>,
Shubhangini G <shubhangini@axiado.com>,
Prasad Bolisetty <pbolisetty@axiado.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Karthikeyan Mitran <kmitran@axiado.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org
Subject: Re: [PATCH 1/2] dt-bindings: media: add axiado,ax3000-video
Date: Mon, 3 Aug 2026 08:28:05 +0200 [thread overview]
Message-ID: <9f689436-04c6-48d6-8342-7fac998f3910@kernel.org> (raw)
In-Reply-To: <a8383bd7-802b-41b0-897b-812b4a8fca33@axiado.com>
On 03/08/2026 07:29, Tzu-Hao Wei wrote:
> On 7/30/2026 4:12 PM, Krzysztof Kozlowski wrote:
>> On 30/07/2026 09:26, Tzu-Hao Wei wrote:
>>> Add a Device Tree binding for the Axiado AX3000 and AX3005 video
>>> capture path. There is no local register interface to describe: frames
>>> arrive asynchronously into a reserved memory region written by the
>>> host's display engine over PCIe, and this node only identifies that
>>> region.
>>>
>>> memory-region accepts an optional second entry for a host-written
>>> control mailbox, letting the driver detect the mode the host is
>>> actually driving instead of only echoing back the configured capture
>>> format.
>>>
>>> Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
>>> ---
>>> .../bindings/media/axiado,ax3000-video.yaml | 44 ++++++++++++++++++++++
>>> MAINTAINERS | 8 ++++
>>> 2 files changed, 52 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/media/axiado,ax3000-video.yaml b/Documentation/devicetree/bindings/media/axiado,ax3000-video.yaml
>>> new file mode 100644
>>> index 0000000000000000000000000000000000000000..c6d8d1843aac9f42869ff90a550b92d0bed7c16f
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/media/axiado,ax3000-video.yaml
>>> @@ -0,0 +1,44 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/media/axiado,ax3000-video.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Axiado AX3000 Video Controller
>>> +
>>> +maintainers:
>>> + - Shubhangini G <shubhangini@axiado.com>
>>> + - Tzu-Hao Wei <twei@axiado.com>
>>> + - Prasad Bolisetty <pbolisetty@axiado.com>
>>> +
>>> +description:
>>> + Axiado AX3000 video capture controller. Reads frames written by the
>>> + display engine into a shared reserved memory region and exposes them
>>> + as a V4L2 capture device.
>>
>> This is really incomplete. You need at least way to power things on,
>> reset them, provide clocks, sensors, data paths. Or at the very minimal:
>> START capturing the frames after configuring the resolution.
>>
>> It seems you described driver or just a piece of entire video pipeline.
>>
>
> Thanks for your feedback.
>
> The Axiado AX3000 and AX3005 SoCs expose a display capture path that
> delivers frames into a shared reserved memory region and exposes them
> as a standard V4L2 capture device via the videobuf2 framework.
>
> There is no local register interface for this driver to program: frame
> delivery is controlled entirely by the host-side display engine and
> the PCIe endpoint mapping that feeds the shared region, both external
> to this driver. A software polling timer schedules a workqueue item at
> the configured framerate, which copies frames from the WC-mapped
> shared region into vmalloc-backed vb2 buffers. Running the copy in a
> work item rather than directly in the timer callback keeps potentially
> multi-megabyte memcpy and per-pixel conversion work out of softirq
> context.
Then this is not a separate device. You just described a Linux driver.
I still wait for answers of my question above. You described getting
buffers only.
>
> To provide more context, this hardware path is designed for BMC iKVM
> applications. The physical data flow is:
> Host Display Engine -> PCIe -> BMC Shared Memory -> v4l2 (video0).
Great, not a device. Linux driver.
>
>>> +
>>> +properties:
>>> + compatible:
>>> + oneOf:
>>> + - const: axiado,ax3000-video
>>> + - items:
>>> + - const: axiado,ax3005-video
>>> + - const: axiado,ax3000-video
>>> +
>>> + memory-region:
>>> + minItems: 1
>>> + items:
>>> + - description: video frame buffer, shared with the display engine
>>> + - description: optional control mailbox, shared with the host
>>
>> Why is it optional?
>>
>
> The second memory region is optional because it is not available on all
> supported hardware configurations or use cases.
>
> For instance, another supported use case has the following data flow:
> vtconsole -> framebuffer -> Shared Memory -> v4l2 (video0).
Use case is irrelevant to actual hardware.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-08-03 6:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 7:26 [PATCH 0/2] media: axiado: add AX3000/AX3005 V4L2 capture driver Tzu-Hao Wei
2026-07-30 7:26 ` [PATCH 1/2] dt-bindings: media: add axiado,ax3000-video Tzu-Hao Wei
2026-07-30 8:12 ` Krzysztof Kozlowski
2026-08-03 5:29 ` Tzu-Hao Wei
2026-08-03 6:28 ` Krzysztof Kozlowski [this message]
2026-08-03 23:31 ` Tzu-Hao Wei
2026-08-04 7:55 ` Krzysztof Kozlowski
2026-07-30 7:26 ` [PATCH 2/2] media: axiado: add V4L2 capture driver for AX3000/AX3005 SoC Tzu-Hao Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f689436-04c6-48d6-8342-7fac998f3910@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kmitran@axiado.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pbolisetty@axiado.com \
--cc=robh@kernel.org \
--cc=shubhangini@axiado.com \
--cc=twei@axiado.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox