* [PATCH v2 0/2] arm64: dts: broadcom: bcm2712-d-rpi-5-b: add compatible
@ 2026-08-03 12:09 Gregor Herburger
2026-08-03 12:09 ` [PATCH v2 1/2] dt-bindings: arm: bcm2835: Add Raspberry Pi 5 d0 Stepping Gregor Herburger
2026-08-03 12:09 ` [PATCH v2 2/2] arm64: dts: broadcom: bcm2712-d-rpi-5-b: add compatible Gregor Herburger
0 siblings, 2 replies; 5+ messages in thread
From: Gregor Herburger @ 2026-08-03 12:09 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Florian Fainelli,
Broadcom internal kernel review list, Ray Jui, Scott Branden,
Eric Anholt, Stefan Wahren
Cc: devicetree, linux-rpi-kernel, linux-arm-kernel, linux-kernel,
Gregor Herburger
The bcm2712 found on the Raspberry Pi 5 is available in the d Stepping
and in a c Stepping. There are two separate dts files. The
bcm2712-rpi-5-b.dts for the c Stepping and the bcm2712-d-rpi-5-b.dts for
the d Stepping. The d stepping does not set its own compatible/model
string but uses "raspberrypi,5-model-b".
These two steppings are not compatible. Booting with the wrong dtb file
causes a crash at boot.
Add a compatibles string "raspberrypi,5-model-b-d0" to allow us to
distinguish between those two steppings.
---
Changes in v2:
- Removed the wrong oneOf
- Link to v1: https://patch.msgid.link/20260803-bcm2712-d-stepping-compatible-v1-0-401934357a44@linutronix.de
---
Gregor Herburger (2):
dt-bindings: arm: bcm2835: Add Raspberry Pi 5 d0 Stepping
arm64: dts: broadcom: bcm2712-d-rpi-5-b: add compatible
Documentation/devicetree/bindings/arm/bcm/bcm2835.yaml | 6 ++++++
arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts | 5 +++++
2 files changed, 11 insertions(+)
---
base-commit: 8ba098e6b6ff0db8edf28528d1552be261af30d4
change-id: 20260731-bcm2712-d-stepping-compatible-4b40f0c4bda5
Best regards,
--
Gregor Herburger <gregor.herburger@linutronix.de>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2 1/2] dt-bindings: arm: bcm2835: Add Raspberry Pi 5 d0 Stepping 2026-08-03 12:09 [PATCH v2 0/2] arm64: dts: broadcom: bcm2712-d-rpi-5-b: add compatible Gregor Herburger @ 2026-08-03 12:09 ` Gregor Herburger 2026-08-03 12:09 ` [PATCH v2 2/2] arm64: dts: broadcom: bcm2712-d-rpi-5-b: add compatible Gregor Herburger 1 sibling, 0 replies; 5+ messages in thread From: Gregor Herburger @ 2026-08-03 12:09 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Florian Fainelli, Broadcom internal kernel review list, Ray Jui, Scott Branden, Eric Anholt, Stefan Wahren Cc: devicetree, linux-rpi-kernel, linux-arm-kernel, linux-kernel, Gregor Herburger Add the Raspberry Pi 5 d0 Stepping to the schema. Signed-off-by: Gregor Herburger <gregor.herburger@linutronix.de> --- Documentation/devicetree/bindings/arm/bcm/bcm2835.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/bcm/bcm2835.yaml b/Documentation/devicetree/bindings/arm/bcm/bcm2835.yaml index 2729a542c4f3..32e1b01676d6 100644 --- a/Documentation/devicetree/bindings/arm/bcm/bcm2835.yaml +++ b/Documentation/devicetree/bindings/arm/bcm/bcm2835.yaml @@ -29,6 +29,12 @@ properties: - raspberrypi,5-model-b - const: brcm,bcm2712 + - description: BCM2712 based Boards d0 stepping + items: + - const: raspberrypi,5-model-b-d0 + - const: raspberrypi,5-model-b + - const: brcm,bcm2712 + - description: BCM2835 based Boards items: - enum: -- 2.47.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] arm64: dts: broadcom: bcm2712-d-rpi-5-b: add compatible 2026-08-03 12:09 [PATCH v2 0/2] arm64: dts: broadcom: bcm2712-d-rpi-5-b: add compatible Gregor Herburger 2026-08-03 12:09 ` [PATCH v2 1/2] dt-bindings: arm: bcm2835: Add Raspberry Pi 5 d0 Stepping Gregor Herburger @ 2026-08-03 12:09 ` Gregor Herburger 2026-08-04 7:48 ` Krzysztof Kozlowski 1 sibling, 1 reply; 5+ messages in thread From: Gregor Herburger @ 2026-08-03 12:09 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Florian Fainelli, Broadcom internal kernel review list, Ray Jui, Scott Branden, Eric Anholt, Stefan Wahren Cc: devicetree, linux-rpi-kernel, linux-arm-kernel, linux-kernel, Gregor Herburger The bcm2712 found on the Raspberry Pi 5 is available in the d Stepping and in a c Stepping. There are two separate dts files. The bcm2712-rpi-5-b.dts for the c Stepping and the bcm2712-d-rpi-5-b.dts for the d Stepping. The d stepping does not set its own compatible/model string but uses "raspberrypi,5-model-b". These two steppings are not compatible. Booting with the wrong dtb file causes a crash at boot. Add a compatibles string "raspberrypi,5-model-b-d0" to allow us to distinguish between those two steppings. Signed-off-by: Gregor Herburger <gregor.herburger@linutronix.de> --- arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts b/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts index 127be0fc27c2..11a38cd53401 100644 --- a/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts +++ b/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts @@ -3,6 +3,11 @@ #include "bcm2712-rpi-5-b.dts" +/ { + compatible = "raspberrypi,5-model-b-d0", "raspberrypi,5-model-b", "brcm,bcm2712"; + model = "Raspberry Pi 5 d0 Stepping"; +}; + &gio_aon { brcm,gpio-bank-widths = <15 6>; -- 2.47.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: broadcom: bcm2712-d-rpi-5-b: add compatible 2026-08-03 12:09 ` [PATCH v2 2/2] arm64: dts: broadcom: bcm2712-d-rpi-5-b: add compatible Gregor Herburger @ 2026-08-04 7:48 ` Krzysztof Kozlowski 2026-08-04 8:38 ` Gregor Herburger 0 siblings, 1 reply; 5+ messages in thread From: Krzysztof Kozlowski @ 2026-08-04 7:48 UTC (permalink / raw) To: Gregor Herburger Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Florian Fainelli, Broadcom internal kernel review list, Ray Jui, Scott Branden, Eric Anholt, Stefan Wahren, devicetree, linux-rpi-kernel, linux-arm-kernel, linux-kernel On Mon, Aug 03, 2026 at 02:09:25PM +0200, Gregor Herburger wrote: > The bcm2712 found on the Raspberry Pi 5 is available in the d Stepping > and in a c Stepping. There are two separate dts files. The > bcm2712-rpi-5-b.dts for the c Stepping and the bcm2712-d-rpi-5-b.dts for > the d Stepping. The d stepping does not set its own compatible/model > string but uses "raspberrypi,5-model-b". > > These two steppings are not compatible. Booting with the wrong dtb file Not compatible but... > causes a crash at boot. > > Add a compatibles string "raspberrypi,5-model-b-d0" to allow us to > distinguish between those two steppings. > > Signed-off-by: Gregor Herburger <gregor.herburger@linutronix.de> > --- > arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts b/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts > index 127be0fc27c2..11a38cd53401 100644 > --- a/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts > +++ b/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts > @@ -3,6 +3,11 @@ > > #include "bcm2712-rpi-5-b.dts" > > +/ { > + compatible = "raspberrypi,5-model-b-d0", "raspberrypi,5-model-b", "brcm,bcm2712"; this tells they are compatible. If compatibility was wrong since the beginning, you do not have to preserve the ABI. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: broadcom: bcm2712-d-rpi-5-b: add compatible 2026-08-04 7:48 ` Krzysztof Kozlowski @ 2026-08-04 8:38 ` Gregor Herburger 0 siblings, 0 replies; 5+ messages in thread From: Gregor Herburger @ 2026-08-04 8:38 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Florian Fainelli, Broadcom internal kernel review list, Ray Jui, Scott Branden, Eric Anholt, Stefan Wahren, devicetree, linux-rpi-kernel, linux-arm-kernel, linux-kernel On Tue, Aug 04, 2026 at 09:48:19AM +0200, Krzysztof Kozlowski wrote: > On Mon, Aug 03, 2026 at 02:09:25PM +0200, Gregor Herburger wrote: > > The bcm2712 found on the Raspberry Pi 5 is available in the d Stepping > > and in a c Stepping. There are two separate dts files. The > > bcm2712-rpi-5-b.dts for the c Stepping and the bcm2712-d-rpi-5-b.dts for > > the d Stepping. The d stepping does not set its own compatible/model > > string but uses "raspberrypi,5-model-b". > > > > These two steppings are not compatible. Booting with the wrong dtb file > > Not compatible but... > > > causes a crash at boot. > > > > Add a compatibles string "raspberrypi,5-model-b-d0" to allow us to > > distinguish between those two steppings. > > > > Signed-off-by: Gregor Herburger <gregor.herburger@linutronix.de> > > --- > > arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts b/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts > > index 127be0fc27c2..11a38cd53401 100644 > > --- a/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts > > +++ b/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts > > @@ -3,6 +3,11 @@ > > > > #include "bcm2712-rpi-5-b.dts" > > > > +/ { > > + compatible = "raspberrypi,5-model-b-d0", "raspberrypi,5-model-b", "brcm,bcm2712"; > > this tells they are compatible. If compatibility was wrong since the > beginning, you do not have to preserve the ABI. Ok understood. Will drop the fallback and make it either compatible = "raspberrypi,5-model-b-d0", "brcm,bcm2712"; or compatible = "raspberrypi,5-model-b", "brcm,bcm2712"; > > Best regards, > Krzysztof > Best regards, -- Gregor Herburger Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen Phone: +49 7556 25 999 35; Fax.: +49 7556 25 999 99 Hinweise zum Datenschutz finden Sie hier (Informations on data privacy can be found here): https://linutronix.de/legal/data-protection.php Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 806 | Geschäftsführer (Managing Directors): Dr. Wilfried Wessner, Katharina Kopp, Alexander Gieringer ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-08-04 8:38 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-08-03 12:09 [PATCH v2 0/2] arm64: dts: broadcom: bcm2712-d-rpi-5-b: add compatible Gregor Herburger 2026-08-03 12:09 ` [PATCH v2 1/2] dt-bindings: arm: bcm2835: Add Raspberry Pi 5 d0 Stepping Gregor Herburger 2026-08-03 12:09 ` [PATCH v2 2/2] arm64: dts: broadcom: bcm2712-d-rpi-5-b: add compatible Gregor Herburger 2026-08-04 7:48 ` Krzysztof Kozlowski 2026-08-04 8:38 ` Gregor Herburger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox