Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [soc:board-remove 173/217] drivers/gpio/gpio-tps65910.c:146:13: error: wrong type argument to unary exclamation mark
@ 2026-08-18 11:53 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-08-18 11:53 UTC (permalink / raw)
  To: Arnd Bergmann; +Cc: oe-kbuild-all, linux-arm-kernel, arm

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git board-remove
head:   057394422bc04420585b2790b230d8a1f350ace8
commit: 6b7810dfef678917c316dcac0f6a5281388e8a4e [173/217] mfd: tps65910: remove pdata based probing
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20260818/202608181929.NqAM96zH-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260818/202608181929.NqAM96zH-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202608181929.NqAM96zH-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/gpio/gpio-tps65910.c: In function 'tps65910_gpio_probe':
>> drivers/gpio/gpio-tps65910.c:146:13: error: wrong type argument to unary exclamation mark
     146 |         if (!pdata)
         |             ^


vim +146 drivers/gpio/gpio-tps65910.c

6fe02e9f46fda7 drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-19  103  
3836309d93462b drivers/gpio/gpio-tps65910.c Bill Pemberton           2012-11-19  104  static int tps65910_gpio_probe(struct platform_device *pdev)
2537df722d338a drivers/mfd/tps65910-gpio.c  Graeme Gregory           2011-05-02  105  {
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  106  	struct tps65910 *tps65910 = dev_get_drvdata(pdev->dev.parent);
6b7810dfef6789 drivers/gpio/gpio-tps65910.c Arnd Bergmann            2026-08-07  107  	struct tps65910_board pdata = {};
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  108  	struct tps65910_gpio *tps65910_gpio;
2537df722d338a drivers/mfd/tps65910-gpio.c  Graeme Gregory           2011-05-02  109  	int ret;
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  110  	int i;
2537df722d338a drivers/mfd/tps65910-gpio.c  Graeme Gregory           2011-05-02  111  
6dbe6c07f94f34 drivers/gpio/gpio-tps65910.c Andy Shevchenko          2021-12-06  112  	device_set_node(&pdev->dev, dev_fwnode(pdev->dev.parent));
6dbe6c07f94f34 drivers/gpio/gpio-tps65910.c Andy Shevchenko          2021-12-06  113  
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  114  	tps65910_gpio = devm_kzalloc(&pdev->dev,
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  115  				sizeof(*tps65910_gpio), GFP_KERNEL);
0661175a2ae7f8 drivers/gpio/gpio-tps65910.c Jingoo Han               2014-04-29  116  	if (!tps65910_gpio)
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  117  		return -ENOMEM;
2537df722d338a drivers/mfd/tps65910-gpio.c  Graeme Gregory           2011-05-02  118  
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  119  	tps65910_gpio->tps65910 = tps65910;
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  120  
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  121  	tps65910_gpio->gpio_chip.owner = THIS_MODULE;
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  122  	tps65910_gpio->gpio_chip.label = tps65910->i2c_client->name;
11ad14f86a7847 drivers/gpio/tps65910-gpio.c Jorge Eduardo Candelaria 2011-05-16  123  
11ad14f86a7847 drivers/gpio/tps65910-gpio.c Jorge Eduardo Candelaria 2011-05-16  124  	switch (tps65910_chip_id(tps65910)) {
11ad14f86a7847 drivers/gpio/tps65910-gpio.c Jorge Eduardo Candelaria 2011-05-16  125  	case TPS65910:
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  126  		tps65910_gpio->gpio_chip.ngpio = TPS65910_NUM_GPIO;
58956ba23e2dce drivers/gpio/tps65910-gpio.c Axel Lin                 2011-07-06  127  		break;
11ad14f86a7847 drivers/gpio/tps65910-gpio.c Jorge Eduardo Candelaria 2011-05-16  128  	case TPS65911:
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  129  		tps65910_gpio->gpio_chip.ngpio = TPS65911_NUM_GPIO;
58956ba23e2dce drivers/gpio/tps65910-gpio.c Axel Lin                 2011-07-06  130  		break;
11ad14f86a7847 drivers/gpio/tps65910-gpio.c Jorge Eduardo Candelaria 2011-05-16  131  	default:
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  132  		return -EINVAL;
11ad14f86a7847 drivers/gpio/tps65910-gpio.c Jorge Eduardo Candelaria 2011-05-16  133  	}
9fb1f39eb2d670 drivers/gpio/gpio-tps65910.c Linus Walleij            2013-12-04  134  	tps65910_gpio->gpio_chip.can_sleep = true;
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  135  	tps65910_gpio->gpio_chip.direction_input = tps65910_gpio_input;
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  136  	tps65910_gpio->gpio_chip.direction_output = tps65910_gpio_output;
d9d87d90cc0b10 drivers/gpio/gpio-tps65910.c Bartosz Golaszewski      2025-07-17  137  	tps65910_gpio->gpio_chip.set	= tps65910_gpio_set;
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  138  	tps65910_gpio->gpio_chip.get	= tps65910_gpio_get;
58383c78425e4e drivers/gpio/gpio-tps65910.c Linus Walleij            2015-11-04  139  	tps65910_gpio->gpio_chip.parent = &pdev->dev;
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  140  	tps65910_gpio->gpio_chip.base = -1;
2537df722d338a drivers/mfd/tps65910-gpio.c  Graeme Gregory           2011-05-02  141  
6b7810dfef6789 drivers/gpio/gpio-tps65910.c Arnd Bergmann            2026-08-07  142  	tps65910_parse_dt_for_gpio(&pdev->dev, tps65910,
6b7810dfef6789 drivers/gpio/gpio-tps65910.c Arnd Bergmann            2026-08-07  143  				tps65910_gpio->gpio_chip.ngpio,
6b7810dfef6789 drivers/gpio/gpio-tps65910.c Arnd Bergmann            2026-08-07  144  				&pdata);
6fe02e9f46fda7 drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-19  145  
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11 @146  	if (!pdata)
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  147  		goto skip_init;
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  148  
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  149  	/* Configure sleep control for gpios if provided */
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  150  	for (i = 0; i < tps65910_gpio->gpio_chip.ngpio; ++i) {
6b7810dfef6789 drivers/gpio/gpio-tps65910.c Arnd Bergmann            2026-08-07  151  		if (!pdata.en_gpio_sleep[i])
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  152  			continue;
2537df722d338a drivers/mfd/tps65910-gpio.c  Graeme Gregory           2011-05-02  153  
a233d4ebfc6f5b drivers/gpio/gpio-tps65910.c Michał Mirosław          2020-09-27  154  		ret = regmap_set_bits(tps65910->regmap,
9467d298e92455 drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-02-01  155  			TPS65910_GPIO0 + i, GPIO_SLEEP_MASK);
9467d298e92455 drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-02-01  156  		if (ret < 0)
9467d298e92455 drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-02-01  157  			dev_warn(tps65910->dev,
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  158  				"GPIO Sleep setting failed with err %d\n", ret);
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  159  	}
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  160  
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  161  skip_init:
96a03e867c70c7 drivers/gpio/gpio-tps65910.c Alexandru Ardelean       2021-05-21  162  	return devm_gpiochip_add_data(&pdev->dev, &tps65910_gpio->gpio_chip,
bf6e855a4e89e1 drivers/gpio/gpio-tps65910.c Laxman Dewangan          2016-02-22  163  				      tps65910_gpio);
9467d298e92455 drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-02-01  164  }
10bbc48d7a045c drivers/gpio/gpio-tps65910.c Laxman Dewangan          2012-05-11  165  

:::::: The code at line 146 was first introduced by commit
:::::: 10bbc48d7a045c022a54f637c0c6b72f0e38b519 gpio: Convert tps65910 to a platform driver

:::::: TO: Laxman Dewangan <ldewangan@nvidia.com>
:::::: CC: Samuel Ortiz <sameo@linux.intel.com>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-08-18 11:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-18 11:53 [soc:board-remove 173/217] drivers/gpio/gpio-tps65910.c:146:13: error: wrong type argument to unary exclamation mark kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox