* [PATCH] hwmon: aspeed-pwm-tacho: propagate reset deassert errors
@ 2026-08-30 12:50 Pengpeng Hou
2026-09-01 23:04 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Pengpeng Hou @ 2026-08-30 12:50 UTC (permalink / raw)
To: Guenter Roeck
Cc: Pengpeng Hou, Joel Stanley, Andrew Jeffery, Ryan Chen, Billy Tsai,
Philipp Zabel, linux-hwmon, linux-arm-kernel, linux-aspeed,
linux-kernel
aspeed_pwm_tacho_probe() installs its reset cleanup action and configures
the
controller after an unchecked reset deassertion.
Stop probing when the reset controller rejects the transition, before the
hwmon device becomes visible.
Fixes: 18c514cc0e02 ("hwmon: (aspeed-pwm-tacho) Deassert reset in probe")
Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
---
drivers/hwmon/aspeed-pwm-tacho.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c
index 1c5945d4ba377..bfce589c3fb1f 100644
--- a/drivers/hwmon/aspeed-pwm-tacho.c
+++ b/drivers/hwmon/aspeed-pwm-tacho.c
@@ -934,7 +934,9 @@ static int aspeed_pwm_tacho_probe(struct platform_device *pdev)
"missing or invalid reset controller device tree entry");
return PTR_ERR(priv->rst);
}
- reset_control_deassert(priv->rst);
+ ret = reset_control_deassert(priv->rst);
+ if (ret)
+ return ret;
ret = devm_add_action_or_reset(dev, aspeed_pwm_tacho_remove, priv);
if (ret)
base-commit: 08dbfad3f5040f5bdb6c529da20d6d4e81fefd72
--
2.50.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: aspeed-pwm-tacho: propagate reset deassert errors
2026-08-30 12:50 [PATCH] hwmon: aspeed-pwm-tacho: propagate reset deassert errors Pengpeng Hou
@ 2026-09-01 23:04 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2026-09-01 23:04 UTC (permalink / raw)
To: Pengpeng Hou
Cc: Joel Stanley, Andrew Jeffery, Ryan Chen, Billy Tsai,
Philipp Zabel, linux-hwmon, linux-arm-kernel, linux-aspeed,
linux-kernel
On Sun, Aug 30, 2026 at 08:50:44PM +0800, Pengpeng Hou wrote:
> aspeed_pwm_tacho_probe() installs its reset cleanup action and configures
> the
> controller after an unchecked reset deassertion.
>
> Stop probing when the reset controller rejects the transition, before the
> hwmon device becomes visible.
>
> Fixes: 18c514cc0e02 ("hwmon: (aspeed-pwm-tacho) Deassert reset in probe")
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-01 23:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-30 12:50 [PATCH] hwmon: aspeed-pwm-tacho: propagate reset deassert errors Pengpeng Hou
2026-09-01 23:04 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).