* [PATCH v2] arm64: dts: imx8mp-phyboard-pollux-peb-av-10: Fix SAI master assignment
@ 2026-08-31 5:12 Primoz Fiser
2026-08-31 6:33 ` Chancel Liu
2026-08-31 15:23 ` Frank.Li
0 siblings, 2 replies; 3+ messages in thread
From: Primoz Fiser @ 2026-08-31 5:12 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Peng Fan,
Yannic Moog, Shawn Guo
Cc: devicetree, imx, linux-arm-kernel, linux-kernel, upstream
The dailink_master label was placed on the codec sub-node instead of
the CPU sub-node, configuring the codec as I2S bitclock/frame master
with SAI2 as slave. On this board, BCLK and LRCLK are wired the other
way around: SAI2 must be bus master, with the codec as I2S slave.
Move dailink_master to the CPU sub-node so SAI2 drives BCLK and LRCLK,
fixing broken audio on the PHYTEC phyBOARD-Pollux-i.MX8MP board with
PEB-AV-10 Audio/Video expansion board. Also remove the spurious clocks
property from the codec sub-node, which had no effect in this topology.
Fixes: 7012f551081f ("arm64: dts: imx8mp pollux: add expansion board overlay")
Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
---
Changes in v2:
- reword commit message to avoid topology confusion
Link to v1: https://lore.kernel.org/all/20260827065556.2326079-1-primoz.fiser@norik.com/
.../boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi
index bb740f845855..8957b24a7ad2 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi
@@ -77,13 +77,12 @@ sound {
"MIC3R", "Microphone Jack",
"Microphone Jack", "Mic Bias";
- simple-audio-card,cpu {
+ dailink_master: simple-audio-card,cpu {
sound-dai = <&sai2>;
};
- dailink_master: simple-audio-card,codec {
+ simple-audio-card,codec {
sound-dai = <&codec>;
- clocks = <&clk IMX8MP_CLK_SAI2>;
};
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] arm64: dts: imx8mp-phyboard-pollux-peb-av-10: Fix SAI master assignment
2026-08-31 5:12 [PATCH v2] arm64: dts: imx8mp-phyboard-pollux-peb-av-10: Fix SAI master assignment Primoz Fiser
@ 2026-08-31 6:33 ` Chancel Liu
2026-08-31 15:23 ` Frank.Li
1 sibling, 0 replies; 3+ messages in thread
From: Chancel Liu @ 2026-08-31 6:33 UTC (permalink / raw)
To: Primoz Fiser, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Peng Fan, Yannic Moog, Shawn Guo
Cc: devicetree, imx, linux-arm-kernel, linux-kernel, upstream
> The dailink_master label was placed on the codec sub-node instead of
> the CPU sub-node, configuring the codec as I2S bitclock/frame master
> with SAI2 as slave. On this board, BCLK and LRCLK are wired the other
> way around: SAI2 must be bus master, with the codec as I2S slave.
>
> Move dailink_master to the CPU sub-node so SAI2 drives BCLK and LRCLK,
> fixing broken audio on the PHYTEC phyBOARD-Pollux-i.MX8MP board with
> PEB-AV-10 Audio/Video expansion board. Also remove the spurious clocks
> property from the codec sub-node, which had no effect in this topology.
>
> Fixes: 7012f551081f ("arm64: dts: imx8mp pollux: add expansion board overlay")
> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
Reviewed-by: Chancel Liu <chancel.liu@gmail.com>
Regards,
Chancel Liu
> ---
> Changes in v2:
> - reword commit message to avoid topology confusion
>
> Link to v1: https://lore.kernel.org/all/20260827065556.2326079-1-primoz.fiser@norik.com/
>
> .../boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi
> index bb740f845855..8957b24a7ad2 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi
> @@ -77,13 +77,12 @@ sound {
> "MIC3R", "Microphone Jack",
> "Microphone Jack", "Mic Bias";
>
> - simple-audio-card,cpu {
> + dailink_master: simple-audio-card,cpu {
> sound-dai = <&sai2>;
> };
>
> - dailink_master: simple-audio-card,codec {
> + simple-audio-card,codec {
> sound-dai = <&codec>;
> - clocks = <&clk IMX8MP_CLK_SAI2>;
> };
> };
> };
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] arm64: dts: imx8mp-phyboard-pollux-peb-av-10: Fix SAI master assignment
2026-08-31 5:12 [PATCH v2] arm64: dts: imx8mp-phyboard-pollux-peb-av-10: Fix SAI master assignment Primoz Fiser
2026-08-31 6:33 ` Chancel Liu
@ 2026-08-31 15:23 ` Frank.Li
1 sibling, 0 replies; 3+ messages in thread
From: Frank.Li @ 2026-08-31 15:23 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Peng Fan, Yannic Moog,
Shawn Guo, Primoz Fiser
Cc: Frank Li, devicetree, imx, linux-arm-kernel, linux-kernel,
upstream
From: Frank Li <Frank.Li@nxp.com>
On Mon, 31 Aug 2026 07:12:22 +0200, Primoz Fiser wrote:
> The dailink_master label was placed on the codec sub-node instead of
> the CPU sub-node, configuring the codec as I2S bitclock/frame master
> with SAI2 as slave. On this board, BCLK and LRCLK are wired the other
> way around: SAI2 must be bus master, with the codec as I2S slave.
>
> Move dailink_master to the CPU sub-node so SAI2 drives BCLK and LRCLK,
> fixing broken audio on the PHYTEC phyBOARD-Pollux-i.MX8MP board with
> PEB-AV-10 Audio/Video expansion board. Also remove the spurious clocks
> property from the codec sub-node, which had no effect in this topology.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: imx8mp-phyboard-pollux-peb-av-10: Fix SAI master assignment
commit: 1c3f5701bc0ff5cbe56bdae76157047d47051d44
Best regards,
--
Frank Li <Frank.Li@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-31 15:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-31 5:12 [PATCH v2] arm64: dts: imx8mp-phyboard-pollux-peb-av-10: Fix SAI master assignment Primoz Fiser
2026-08-31 6:33 ` Chancel Liu
2026-08-31 15:23 ` Frank.Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox