Re: [PATCH v5 2/4] dt-bindings: usb: generic-ehci: Document ST STM32MP2 SoC compatibles

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2755 bytes --]

On Tue, Sep 01, 2026 at 01:17:33AM +0200, Marek Vasut wrote:
> Document SoC compatibles for ST STM32MP23xx and STM32MP25xx series of
> SoC, so they can be used as more accurate compatible in SoC DTSI. The
> SoC uses access controllers, therefore document access-controllers DT
> property. For details, see access-controllers/access-controllers.yaml.
> 
> Signed-off-by: Marek Vasut <marex@nabladev.com>
> ---
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> Cc: linux-usb@vger.kernel.org
> ---
> V4: New patch
> V5: - Fix typo, clocs -> clocks
>     - List clocks entries as list of description:
> ---
>  .../devicetree/bindings/usb/generic-ehci.yaml | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> index 5d9dfea8e2160..908b02d9175e0 100644
> --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> @@ -57,6 +57,8 @@ properties:
>                - socionext,uniphier-ehci
>                - st,stm32mp13-ehci
>                - st,stm32mp15-ehci
> +              - st,stm32mp23-ehci
> +              - st,stm32mp25-ehci
>            - const: generic-ehci
>        - items:
>            - enum:
> @@ -82,6 +84,9 @@ properties:
>      minItems: 1
>      maxItems: 2
>  
> +  access-controllers:
> +    maxItems: 1
> +
>    dma-coherent: true
>  
>    interrupts:
> @@ -195,6 +200,23 @@ allOf:
>      else:
>        properties:
>          clock-names: false
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - st,stm32mp23-ehci
> +              - st,stm32mp25-ehci
> +    then:
> +      properties:
> +        clocks:
> +          items:
> +            - description: PHY clock
> +            - description: Bus clock
> +
> +      required:
> +        - access-controllers
> +        - clocks

Since the property is new, I think you should add

else: properties: access-controllers: false

even though it may mean a bit more of a restructure if another platform
wants access controllers.

pw-bot: changes-requested

Cheers,
Conor.

>  
>  unevaluatedProperties: false
>  
> -- 
> 2.53.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]