From: Marek Vasut <marex@nabladev.com>
To: Conor Dooley <conor@kernel.org>
Cc: linux-usb@vger.kernel.org, fabrice.gasnier@foss.st.com,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Conor Dooley <conor+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v5 2/4] dt-bindings: usb: generic-ehci: Document ST STM32MP2 SoC compatibles
Date: Wed, 2 Sep 2026 16:07:57 +0200 [thread overview]
Message-ID: <c3bad2f4-d371-4254-a6db-0af31fcf1a41@nabladev.com> (raw)
In-Reply-To: <20260901-buzz-mousiness-96fa5be618eb@spud>
On 9/1/26 7:54 PM, Conor Dooley wrote:
Hello Conor,
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - st,stm32mp23-ehci
>> + - st,stm32mp25-ehci
>> + then:
>> + properties:
>> + clocks:
>> + items:
>> + - description: PHY clock
>> + - description: Bus clock
>> +
>> + required:
>> + - access-controllers
>> + - clocks
>
> Since the property is new, I think you should add
>
> else: properties: access-controllers: false
>
> even though it may mean a bit more of a restructure if another platform
> wants access controllers.
I think Greg already picked the V5 in some form, I'll see what lands and
either send a V6 or a follow up patch, whichever you prefer.
Thanks !
next prev parent reply other threads:[~2026-09-03 4:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 23:17 [PATCH v5 0/4] arm64: dts: st: Add STM32MP2 USB support Marek Vasut
2026-08-31 23:17 ` [PATCH v5 1/4] dt-bindings: usb: generic-ohci: Document ST STM32MP2 SoC compatibles Marek Vasut
2026-09-01 10:11 ` Krzysztof Kozlowski
2026-08-31 23:17 ` [PATCH v5 2/4] dt-bindings: usb: generic-ehci: " Marek Vasut
2026-09-01 17:54 ` Conor Dooley
2026-09-02 14:07 ` Marek Vasut [this message]
2026-08-31 23:17 ` [PATCH v5 3/4] arm64: dts: st: Add USB nodes on stm32mp231 Marek Vasut
2026-08-31 23:17 ` [PATCH v5 4/4] arm64: dts: st: Add USB nodes on stm32mp251 Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3bad2f4-d371-4254-a6db-0af31fcf1a41@nabladev.com \
--to=marex@nabladev.com \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@foss.st.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox