Re: [PATCH v3 9/9] firmware: arm_scmi: Validate PCC shared memory signature

[Sudeep Holla <sudeep.holla@kernel.org>]

On Wed, Sep 02, 2026 at 04:31:10PM -0700, Jonathan Cameron wrote:
> On Wed, 2 Sep 2026 09:25:19 +0100
> Sudeep Holla <sudeep.holla@kernel.org> wrote:
> 
> > On Mon, Aug 24, 2026 at 01:24:50PM -0700, Jonathan Cameron wrote:
> > > On Thu, 13 Aug 2026 12:33:04 +0100
> > > Sudeep Holla <sudeep.holla@kernel.org> wrote:
> > >   
> > > > Validate the PCC shared memory signature when setting up an SCMI PCC
> > > > channel.
> > > > 
> > > > Reject channels whose shared memory signature does not encode
> > > > PCC_SIGNATURE combined with the PCC subspace ID, so misconfigured
> > > > firmware is caught before the transport starts using the shared memory
> > > > region.
> > > > 
> > > > Signed-off-by: Sudeep Holla <sudeep.holla@kernel.org>  
> > > Interesting there aren't more checks on this in the various PCC users.
> > > Question for another day perhaps.
> > >   
> > 
> > Tried cleaning up all but some platforms like Hisilicon kunpeng complained
> > it will break their platforms. So added a warning in the core but I want
> > to enforce stricter check here for SCMI PCC.
> 
> Fair enough.  I'd be tempted to check in core and add a quirks list
> for those broken platforms but meh, not my problem ;)
> 

Yes that is a possibility. One step at a time, lets keep warning for some
time and then handle broken systems as quirks. The warning is already in
place.

-- 
Regards,
Sudeep