* [PATCHv2] ARM: dts: BCM5301X: AC56U: add nvram node
@ 2026-09-10 0:12 Rosen Penev
2026-09-10 16:46 ` Florian Fainelli
0 siblings, 1 reply; 5+ messages in thread
From: Rosen Penev @ 2026-09-10 0:12 UTC (permalink / raw)
To: devicetree
Cc: Florian Fainelli, Hauke Mehrtens, Rafał Miłecki,
Broadcom internal kernel review list, Rob Herring,
Krzysztof Kozlowski, Conor Dooley,
moderated list:BROADCOM BCM5301X ARM ARCHITECTURE, open list
Add it and set for gmac0, which is the only GMAC used on this board.
nvram size found from a random bootlog online.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
v2: fix typo.
.../boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts b/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
index c80ac16ad949..9ab618a097b1 100644
--- a/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
+++ b/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
@@ -25,6 +25,15 @@ memory@0 {
<0x88000000 0x08000000>;
};
+ nvram@1c080000 {
+ compatible = "brcm,nvram";
+ reg = <0x1c080000 0x180000>;
+
+ et0macaddr: et0macaddr {
+ #nvmem-cell-cells = <1>;
+ };
+ };
+
leds {
compatible = "gpio-leds";
@@ -92,3 +101,8 @@ button-wps {
&usb3_phy {
status = "okay";
};
+
+&gmac0 {
+ nvmem-cells = <&et0macaddr 0>;
+ nvmem-cell-names = "mac-address";
+};
--
2.55.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCHv2] ARM: dts: BCM5301X: AC56U: add nvram node
2026-09-10 0:12 [PATCHv2] ARM: dts: BCM5301X: AC56U: add nvram node Rosen Penev
@ 2026-09-10 16:46 ` Florian Fainelli
2026-09-10 18:56 ` Rosen Penev
0 siblings, 1 reply; 5+ messages in thread
From: Florian Fainelli @ 2026-09-10 16:46 UTC (permalink / raw)
To: Rosen Penev, devicetree
Cc: Hauke Mehrtens, Rafał Miłecki,
Broadcom internal kernel review list, Rob Herring,
Krzysztof Kozlowski, Conor Dooley,
moderated list:BROADCOM BCM5301X ARM ARCHITECTURE, open list
On 9/9/26 17:12, Rosen Penev wrote:
> Add it and set for gmac0, which is the only GMAC used on this board.
>
> nvram size found from a random bootlog online.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> v2: fix typo.
> .../boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts b/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
> index c80ac16ad949..9ab618a097b1 100644
> --- a/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
> @@ -25,6 +25,15 @@ memory@0 {
> <0x88000000 0x08000000>;
> };
>
> + nvram@1c080000 {
> + compatible = "brcm,nvram";
> + reg = <0x1c080000 0x180000>;
Why is not the nvram node moved to bcm5301x.dtsi given it is common to
all of the chips?
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCHv2] ARM: dts: BCM5301X: AC56U: add nvram node
2026-09-10 16:46 ` Florian Fainelli
@ 2026-09-10 18:56 ` Rosen Penev
2026-09-11 18:50 ` Rosen Penev
0 siblings, 1 reply; 5+ messages in thread
From: Rosen Penev @ 2026-09-10 18:56 UTC (permalink / raw)
To: Florian Fainelli
Cc: devicetree, Hauke Mehrtens, Rafał Miłecki,
Broadcom internal kernel review list, Rob Herring,
Krzysztof Kozlowski, Conor Dooley,
moderated list:BROADCOM BCM5301X ARM ARCHITECTURE, open list
On Thu, Sep 10, 2026 at 9:46 AM Florian Fainelli
<florian.fainelli@broadcom.com> wrote:
>
> On 9/9/26 17:12, Rosen Penev wrote:
> > Add it and set for gmac0, which is the only GMAC used on this board.
> >
> > nvram size found from a random bootlog online.
> >
> > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> > ---
> > v2: fix typo.
> > .../boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts b/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
> > index c80ac16ad949..9ab618a097b1 100644
> > --- a/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
> > +++ b/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
> > @@ -25,6 +25,15 @@ memory@0 {
> > <0x88000000 0x08000000>;
> > };
> >
> > + nvram@1c080000 {
> > + compatible = "brcm,nvram";
> > + reg = <0x1c080000 0x180000>;
>
> Why is not the nvram node moved to bcm5301x.dtsi given it is common to
> all of the chips?
To avoid probe errors on hardware where sizes are unknown.
> --
> Florian
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCHv2] ARM: dts: BCM5301X: AC56U: add nvram node
2026-09-10 18:56 ` Rosen Penev
@ 2026-09-11 18:50 ` Rosen Penev
0 siblings, 0 replies; 5+ messages in thread
From: Rosen Penev @ 2026-09-11 18:50 UTC (permalink / raw)
To: Florian Fainelli
Cc: devicetree, Hauke Mehrtens, Rafał Miłecki,
Broadcom internal kernel review list, Rob Herring,
Krzysztof Kozlowski, Conor Dooley,
moderated list:BROADCOM BCM5301X ARM ARCHITECTURE, open list
On Thu, Sep 10, 2026 at 11:56 AM Rosen Penev <rosenp@gmail.com> wrote:
>
> On Thu, Sep 10, 2026 at 9:46 AM Florian Fainelli
> <florian.fainelli@broadcom.com> wrote:
> >
> > On 9/9/26 17:12, Rosen Penev wrote:
> > > Add it and set for gmac0, which is the only GMAC used on this board.
> > >
> > > nvram size found from a random bootlog online.
> > >
> > > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> > > ---
> > > v2: fix typo.
> > > .../boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts | 14 ++++++++++++++
> > > 1 file changed, 14 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts b/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
> > > index c80ac16ad949..9ab618a097b1 100644
> > > --- a/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
> > > +++ b/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
> > > @@ -25,6 +25,15 @@ memory@0 {
> > > <0x88000000 0x08000000>;
> > > };
> > >
> > > + nvram@1c080000 {
> > > + compatible = "brcm,nvram";
> > > + reg = <0x1c080000 0x180000>;
> >
> > Why is not the nvram node moved to bcm5301x.dtsi given it is common to
> > all of the chips?
> To avoid probe errors on hardware where sizes are unknown.
I looked at this again. It makes no sense to centralize:
+ nvram@1c080000 {
+ compatible = "brcm,nvram";
+ reg = <0x1c080000 0x180000>;
The reg and @ values are correct here but not for all devices. There's
also nvram@1e3f0000 and nvram@1e1f0000 as examples.
> > --
> > Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCHv2] ARM: dts: BCM5301X: AC56U: add nvram node
@ 2026-09-11 19:18 Rosen Penev
0 siblings, 0 replies; 5+ messages in thread
From: Rosen Penev @ 2026-09-11 19:18 UTC (permalink / raw)
To: devicetree
Cc: Florian Fainelli, Hauke Mehrtens, Rafał Miłecki,
Broadcom internal kernel review list, Rob Herring,
Krzysztof Kozlowski, Conor Dooley,
moderated list:BROADCOM BCM5301X ARM ARCHITECTURE, open list
Add it and set MAC for gmac2, to avoid having to handle in userspaace.
nvram size found from a random bootlog online.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
v2: set gmac2 MAC instead.
.../boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts b/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
index c80ac16ad949..708599f8c4be 100644
--- a/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
+++ b/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
@@ -25,6 +25,15 @@ memory@0 {
<0x88000000 0x08000000>;
};
+ nvram@1c080000 {
+ compatible = "brcm,nvram";
+ reg = <0x1c080000 0x180000>;
+
+ et0macaddr: et0macaddr {
+ #nvmem-cell-cells = <1>;
+ };
+ };
+
leds {
compatible = "gpio-leds";
@@ -92,3 +101,8 @@ button-wps {
&usb3_phy {
status = "okay";
};
+
+&gmac2 {
+ nvmem-cells = <&et0macaddr 0>;
+ nvmem-cell-names = "mac-address";
+};
--
2.55.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-09-11 19:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-10 0:12 [PATCHv2] ARM: dts: BCM5301X: AC56U: add nvram node Rosen Penev
2026-09-10 16:46 ` Florian Fainelli
2026-09-10 18:56 ` Rosen Penev
2026-09-11 18:50 ` Rosen Penev
-- strict thread matches above, loose matches on Subject: below --
2026-09-11 19:18 Rosen Penev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox